From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"kw@linux.com" <kw@linux.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"mani@kernel.org" <mani@kernel.org>,
"robh@kernel.org" <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] PCI: dwc: Fix index 0 incorrectly being interpreted as a free ATU slot
Date: Tue, 5 Mar 2024 09:05:59 +0000 [thread overview]
Message-ID: <ZebgdpKt7x2hDivM@fedora> (raw)
In-Reply-To: <20240304224616.1238966-1-Frank.Li@nxp.com>
On Mon, Mar 04, 2024 at 05:46:16PM -0500, Frank Li wrote:
> dw_pcie_ep_inbound_atu()
> {
> ...
> if (!ep->bar_to_atu[bar])
> free_win = find_first_zero_bit(ep->ib_window_map, pci->num_ib_windows);
> else
> free_win = ep->bar_to_atu[bar];
> ...
> }
>
> The atu index 0 is valid case for atu number. The find_first_zero_bit()
> will return 6 when second time call into this function if atu is 0. Suppose
> it should use branch 'free_win = ep->bar_to_atu[bar]'.
>
> Change 'bar_to_atu' to free_win + 1. Initialize bar_to_atu as 0 to indicate
> it have not allocate atu to the bar.
>
> Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> Closes: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon/T/#u
> Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() update inbound map address")
> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Tested-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2024-03-05 9:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 22:46 [PATCH v2 1/1] PCI: dwc: Fix index 0 incorrectly being interpreted as a free ATU slot Frank Li
2024-03-05 9:05 ` Niklas Cassel [this message]
2024-03-13 11:09 ` Niklas Cassel
2024-03-20 8:53 ` Niklas Cassel
2024-03-20 14:29 ` Frank Li
2024-03-21 8:16 ` Niklas Cassel
2024-03-21 16:21 ` Frank Li
2024-03-21 16:41 ` Bjorn Helgaas
2024-03-21 17:13 ` Manivannan Sadhasivam
2024-03-21 18:07 ` Bjorn Helgaas
2024-03-22 5:26 ` Manivannan Sadhasivam
2024-03-22 6:19 ` Niklas Cassel
2024-03-22 19:21 ` Bjorn Helgaas
2024-04-02 5:12 ` Manivannan Sadhasivam
2024-04-02 9:23 ` Niklas Cassel
2024-04-02 16:05 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZebgdpKt7x2hDivM@fedora \
--to=niklas.cassel@wdc.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.