From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63A35C54798 for ; Tue, 5 Mar 2024 09:19:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA65910E390; Tue, 5 Mar 2024 09:19:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="didpZooB"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D40B10E390 for ; Tue, 5 Mar 2024 09:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709630359; x=1741166359; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=GbtQB64Y6QTDkZJuvGs1Wb38iQE/cNm8JxBFDHqukvg=; b=didpZooBQ4VhvAlROwtVgT7oDDesgKkRl9GYXaKe/1kJRAd2S4d8GeTR pcuDPN7e4JhiGYMlyx6z2ZwqIV7S7cgBM7hh3Yf1LTC+od0FLVh+qnKE3 jwA742A5YeHHrmi+a8j86WLHU53GwDzBgckaQDX3sMM4Ob5wjeiUItLE2 LnZDiQj7x6i9YBaG3KI3GXXwuS1BBHTh6k4YX8IRu7IWnyRYY3sLl7+6a BXwSrPboQpXARZUOtIBSeRhI7txLtL4wL3AmdWDax2Yxx4SS8Gs6Im6bk ENY5cIHvezNWkC0dEEji5F5csWS0B+XxE+8F/c/+Br2sCPp/fENizkDKs A==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="7988405" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="7988405" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 01:19:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="827773678" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="827773678" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 05 Mar 2024 01:19:15 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 05 Mar 2024 11:19:14 +0200 Date: Tue, 5 Mar 2024 11:19:14 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Lisovskiy, Stanislav" Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc Message-ID: References: <20240301143600.1334-1-ville.syrjala@linux.intel.com> <20240301143600.1334-2-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 05, 2024 at 11:08:56AM +0200, Lisovskiy, Stanislav wrote: > On Tue, Mar 05, 2024 at 10:50:01AM +0200, Ville Syrjälä wrote: > > On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote: > > > On Fri, Mar 01, 2024 at 04:35:53PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > In preparation for doing a more sensible pipe vs. transcoder > > > > handling for bigjoiner let's rename the crtc/crtc_state in the > > > > top level crtc_enable/disable and the DDI encoder hooks to > > > > include "master" in the name. This way they won't collide with > > > > the per-pipe stuff. > > > > > > > > Note that at this point this is (at least partially) telling > > > > lies as we still run through some of these for slave pipes as > > > > well. But I wanted to get the huge rename out of the way so > > > > it won't clutter the functional patches so much. > > > > > > > > TODO: or perhaps use some other names for the per-pipe stuff instead? > > > > > > > > Signed-off-by: Ville Syrjälä > > > > > > I will then review now the patches which you could merge before the bigjoiner > > > stuff could be finished. > > > > I just sent a separate series with the disable_pipes bitmask > > stuff. > > I already reviewed all the patches, including that one, if there were > no changes, I guess you can apply that r-b there as well. Sure. Thanks. > > > > > > Checked this patch I guess, you were also talking that this renaming might > > > be not the best idea. > > > I also wonder whether should we really emphasize things like "master"/"slave" > > > in function names. I thought that one idea in our refactoring was to unify > > > joined pipes handling so that there are no(or at least almost no) explicit code > > > paths/function names for masters/slaves. > > > > There are no master vs. slave functions. The split is going to be > > transcoder/port vs. pipe. > > In practice thats what you want to achieve, the functions which also include encoder > programming and/or handling joined pipes you wanted to add master in the name. I wanted clarity which crtc state is for which purpose. But I think we achieve that by naming the per-pipe variables a bit differently instead (eg. pipe_crtc + pipe_crtc_state). -- Ville Syrjälä Intel