From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CE71C54798 for ; Tue, 5 Mar 2024 10:19:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A12681129DF; Tue, 5 Mar 2024 10:19:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UKMcoSjC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD59A1129DE; Tue, 5 Mar 2024 10:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709633940; x=1741169940; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BF/pBSiXdbQyOEIM8kTA33A2GgG45f64qyPk+qc59Eg=; b=UKMcoSjCvXi1ZMAzcg9A7qbPiizNYzspE9XO8FeE4Pbiyns1fIatZG89 I3XFZKaHrvdFFBYQtc3tOsRKSzdYZ7XJr5qQzjkGz2n+6qGHrNzNeKfxC 3sNoid7cV5NspmM5hI17+hFgfqlDQsG5vXbOPpCPytTW8nZMipdRMkZI1 IaDZ4MKIBXMcB7NWUTHS/jfsJLpoPwwioJBoAbn3AevHL93p4YViWiZRu /cXPXfy6bUTtjUGdEBAucznqU1XJQ9uPDVzK0WmOKW9k+dE1AsG0IlrOC DdhJfDuAffSIr4tqYeHjAWYazFYcxvBoS4YmXgMrxzNZCwsOsdtsyNkPt w==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="14821807" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="14821807" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 02:18:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="14003443" Received: from unknown (HELO intel.com) ([10.247.118.75]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 02:18:52 -0800 Date: Tue, 5 Mar 2024 11:18:45 +0100 From: Andi Shyti To: Joonas Lahtinen Cc: Andi Shyti , dri-devel , intel-gfx , Chris Wilson , Matt Roper , John Harrison , Tvrtko Ursulin , stable@vger.kernel.org, Andi Shyti , Tvrtko Ursulin Subject: Re: [PATCH v3 1/4] drm/i915/gt: Refactor uabi engine class/instance list creation Message-ID: References: <20240229232859.70058-1-andi.shyti@linux.intel.com> <20240229232859.70058-2-andi.shyti@linux.intel.com> <170963369058.35653.11240745207600457716@jlahtine-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170963369058.35653.11240745207600457716@jlahtine-mobl.ger.corp.intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Joonas, ... > > void intel_engines_driver_register(struct drm_i915_private *i915) > > { > > - u16 name_instance, other_instance = 0; > > + u16 class_instance[I915_LAST_UABI_ENGINE_CLASS + 1] = { }; > > Do you mean this to be size I915_LAST_UABI_ENGINE_CLASS + 2? Because ... Yes, this is an oversight. I was playing around with indexes to optimize the code a bit more and I forgot to restore this back. Thanks, Andi > > > > @@ -222,15 +224,14 @@ void intel_engines_driver_register(struct drm_i915_private *i915) > > > > GEM_BUG_ON(engine->class >= ARRAY_SIZE(uabi_classes)); > > engine->uabi_class = uabi_classes[engine->class]; > > - if (engine->uabi_class == I915_NO_UABI_CLASS) { > > - name_instance = other_instance++; > > - } else { > > - GEM_BUG_ON(engine->uabi_class >= > > - ARRAY_SIZE(i915->engine_uabi_class_count)); > > - name_instance = > > - i915->engine_uabi_class_count[engine->uabi_class]++; > > - } > > - engine->uabi_instance = name_instance; > > + > > + if (engine->uabi_class == I915_NO_UABI_CLASS) > > + uabi_class = I915_LAST_UABI_ENGINE_CLASS + 1; > > .. otherwise this ... > > > + else > > + uabi_class = engine->uabi_class; > > + > > + GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance)); > > .. will trigger this assertion? > > Regards, Joonas