From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sean Young <sean@mess.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h
Date: Tue, 5 Mar 2024 19:37:47 +0200 [thread overview]
Message-ID: <ZedYa962KkB4A3Pp@smile.fi.intel.com> (raw)
In-Reply-To: <ZebisPvr_eFPm_0o@gofer.mess.org>
On Tue, Mar 05, 2024 at 09:15:28AM +0000, Sean Young wrote:
> On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
...
> > -#include <linux/of_gpio.h>
>
> This does not build, I get errors saying of_property_read_bool() is undefined.
> I think we need linux/of.h instead of linux/of_gpio.h.
Oh, good catch! The header block there is a mess.
I will replace this patch by something better, I'll Cc you.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-03-05 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 18:03 [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h Andy Shevchenko
2024-03-05 9:15 ` Sean Young
2024-03-05 17:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZedYa962KkB4A3Pp@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.