All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Marco Elver <elver@google.com>
Cc: kernel test robot <oliver.sang@intel.com>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Michal Hocko <mhocko@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [linux-next:master] [mm,page_owner] 4bedfb314b: BUG:KASAN:null-ptr-deref_in_init_page_owner
Date: Tue, 5 Mar 2024 19:38:42 +0100	[thread overview]
Message-ID: <Zedmst0pEtGuY6B6@localhost.localdomain> (raw)
In-Reply-To: <ZedlIv2ECH08KJcM@localhost.localdomain>

On Tue, Mar 05, 2024 at 07:32:02PM +0100, Oscar Salvador wrote:
> On Tue, Mar 05, 2024 at 02:02:35PM +0100, Marco Elver wrote:
> > On Tue, 5 Mar 2024 at 10:26, Oscar Salvador <osalvador@suse.de> wrote:
> > > Marco, could it be that stackdepot was too overloaded, that by the time
> > > page_owner gets initialized, there are no more space for its stacks, and
> > > hence return 0-handles?.
> > 
> > That's possible. But it's unclear to me what exactly happens. Are you
> > able to reproduce the issue? (I haven't been able to because the
> > config enables CFI which seems to cause other issues for me,
> > presumably toolchain related. :-/ )
> 
> I am out of luck here, I cannot reproduce the issue.
> I set up the environment just as [1] says, building the kernel with
> their config and launching bin/lkp just as [1] states, but it
> boots fine here.

But they point out to 

commit 4bedfb314bdd85c1662ecc46fa25b33b998f994d (HEAD, bisection)
Author: Oscar Salvador <osalvador@suse.de>
Date:   Thu Feb 15 22:59:03 2024 +0100

    mm,page_owner: maintain own list of stack_records structs

which the only thing it does is to retrieve the stack_record for
{dummy,failure}.handle and increment their refcount and link them.
I am pretty sure the problem comes from either dummy_handle or
failure_handle being 0 and the stack_record we get is NULL.

I will come up with a patch to guard this scenario, although I did not
think this could happen at this early stage (stack_records returning
NULL).
 

-- 
Oscar Salvador
SUSE Labs

  reply	other threads:[~2024-03-05 18:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  6:08 [linux-next:master] [mm,page_owner] 4bedfb314b: BUG:KASAN:null-ptr-deref_in_init_page_owner kernel test robot
2024-03-05  9:27 ` Oscar Salvador
2024-03-05 13:02   ` Marco Elver
2024-03-05 18:32     ` Oscar Salvador
2024-03-05 18:38       ` Oscar Salvador [this message]
2024-03-06  7:19         ` Oscar Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zedmst0pEtGuY6B6@localhost.localdomain \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=mhocko@suse.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.