From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 432C6C5475B for ; Wed, 6 Mar 2024 09:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0C1vWvpThk9LFBq5lMa+8FHc/z2raOYhMCzGiVt452k=; b=44X27x4Nj9SzZfqzQgzduK83Jp WVscbJU2C91oU7alsAETN/m5a91dobDbEqnGe6TOLWEXQ7/HdIecIj510PA5zRyQB4HSaUT0UDVgN fzV/mJPbBApCDyHmLEe44ACoTHCNuHvwXCncuOQ7hNb8rDjXHUdstLPa76D38TQdiIVIWJ1LPifJN ZBNxmvkax/RZxRR/2z4S6G2VhkWYOd2VGnmI87aAtXP7BVKn+nX9/R84Y92pwucOEqm7LkutYeJIG oqj0U3siyhzAzrG1GdEbhR2Wqnr9TA9gwhLcPwLG0j+e5u26d1ILB/JDvtl5/lR0DhtYT8Kr6P9oI ebvfEdvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhnts-0000000HFRW-35Sk; Wed, 06 Mar 2024 09:49:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhntp-0000000HFPf-2fLr; Wed, 06 Mar 2024 09:49:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 101F21FB; Wed, 6 Mar 2024 01:49:53 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A8093F738; Wed, 6 Mar 2024 01:49:14 -0800 (PST) Date: Wed, 6 Mar 2024 09:49:11 +0000 From: Cristian Marussi To: Flash Liu =?utf-8?B?KOWKieeCs+WCsyk=?= Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , wsd_upstream , Cylen Yao =?utf-8?B?KOWnmueri+S4iSk=?= , "sudeep.holla@arm.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] firmware: arm_scmi: Avoid to call mbox_client_txdone on txdone_irq mode Message-ID: References: <20240201095754.25374-1-flash.liu@mediatek.com> <053cb4a2edfe576412942daed2f7055b2ba9e207.camel@mediatek.com> <56e1b2f5adbca437a14b738e1c58a054f6302fcd.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56e1b2f5adbca437a14b738e1c58a054f6302fcd.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_014921_885005_12FE3FFF X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Mar 06, 2024 at 06:13:48AM +0000, Flash Liu (劉炳傳) wrote: > Hi Cristian, > > Kindly ping :) > Hi Pin-Chuan, sorry for the delay...I have NOT forgot :D, indeed I was just testing yesterday with some mailbox IP of ours equipped with a TxAck IRQ and I would have some question for you because I've seen some anomalies while using this: does your solution work reliably in your setup ALSO when multiple SCMI transactions are attempted ? (like cpufreq issuing cmds while polling a sensor from some other thread) ...I'll dig deeper today in this matter, but my current suspect is that using the mailbox TXAck IRQ to let the controller tick the internal mailbox queues does not play well with SCMI, since the SCMI TX channel is really the SCMI "a2p" bidirectional channel and it is associated with just only one shmem area used to hold both the egressing CMD and to receive the incoming REPLY from the platform: so if you let the controller tick the queues as soon as you received the TXAck you are telling the mailbox subsystem to queue another message on the same area while you are not really done, since only the client know when it's done with the whole SCMI transaction and the reply has been fetched. Indeed, for these reasons we have the BUSY/FREE bit in the shmem to protect it from pending new requests until the previous one has completed, but when the waited-for reply comes in, the platform would have cleared the BUSY bit and let the new queued message overwrite the pending reply prematurely, and one message is lost... ...but as said I want to delve deeper into this, as of now just suppositions and maybe I am just missing something more that has to be configured properly... Thanks, Cristian > Thanks. > Pin-Chuan > > On Fri, 2024-02-02 at 20:36 +0800, Pin-Chuan Liu wrote: > > Hi Cristian, > > > > Thanks for kindly review and explains. Yeah, I have ever tried > > another > > way to skip the call (i.e. let mark_txdone be null). However, it > > looks > > not easy and also to backport. > > > > Awaiting your test results and further suggestions, thanks. > > > > Regards, > > Pin-Chuan > > > > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43359C54E41 for ; Wed, 6 Mar 2024 09:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1JuyItk3p+gSCL7ZOe7X++1AYKgYsrj94f/LiA16UQ=; b=GcHuY+W4crNc+q Id1ZlUANDf4idu5TGdcAM4b1A5Ike5x/LSfzg+/G4hhA3hXLTBDmGhmpcpazutGANx4RYiBrepdLl cYx4ZAA23R+eYZ1eOd4lZLKtkfpp0eXG60yNmk0qgwTBVT5ln2Psa58IdY0N+AawCLzwV3QkeG4zU F6bxV1g+VRCkN+Yhb2vE0wdsybjlhkvGEmtvQk2P9P5gh/rdtUitEC8gn9ZNVEwo4T/p/5N9LfQ6b QPvFjZHee20uJBzG/5BcG1qEBiuVVIqHVexKdth/qzB4jdRYxrsrMBX7FlsgMfLWBTT2oRO2sMZ4E NBVEJ6dXKFGFC05cBXlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhnts-0000000HFRQ-0x4c; Wed, 06 Mar 2024 09:49:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhntp-0000000HFPf-2fLr; Wed, 06 Mar 2024 09:49:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 101F21FB; Wed, 6 Mar 2024 01:49:53 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A8093F738; Wed, 6 Mar 2024 01:49:14 -0800 (PST) Date: Wed, 6 Mar 2024 09:49:11 +0000 From: Cristian Marussi To: Flash Liu =?utf-8?B?KOWKieeCs+WCsyk=?= Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , wsd_upstream , Cylen Yao =?utf-8?B?KOWnmueri+S4iSk=?= , "sudeep.holla@arm.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] firmware: arm_scmi: Avoid to call mbox_client_txdone on txdone_irq mode Message-ID: References: <20240201095754.25374-1-flash.liu@mediatek.com> <053cb4a2edfe576412942daed2f7055b2ba9e207.camel@mediatek.com> <56e1b2f5adbca437a14b738e1c58a054f6302fcd.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56e1b2f5adbca437a14b738e1c58a054f6302fcd.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_014921_885005_12FE3FFF X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMDYsIDIwMjQgYXQgMDY6MTM6NDhBTSArMDAwMCwgRmxhc2ggTGl1ICjlionn grPlgrMpIHdyb3RlOgo+IEhpIENyaXN0aWFuLAo+IAo+IEtpbmRseSBwaW5nIDopCj4gCgpIaSBQ aW4tQ2h1YW4sCgpzb3JyeSBmb3IgdGhlIGRlbGF5Li4uSSBoYXZlIE5PVCBmb3Jnb3QgOkQsIGlu ZGVlZCBJIHdhcyBqdXN0IHRlc3RpbmcKeWVzdGVyZGF5IHdpdGggc29tZSBtYWlsYm94IElQIG9m IG91cnMgZXF1aXBwZWQgd2l0aCBhIFR4QWNrIElSUSBhbmQgSQp3b3VsZCBoYXZlIHNvbWUgcXVl c3Rpb24gZm9yIHlvdSBiZWNhdXNlIEkndmUgc2VlbiBzb21lIGFub21hbGllcyB3aGlsZQp1c2lu ZyB0aGlzOiBkb2VzIHlvdXIgc29sdXRpb24gd29yayByZWxpYWJseSBpbiB5b3VyIHNldHVwIEFM U08gd2hlbgptdWx0aXBsZSBTQ01JIHRyYW5zYWN0aW9ucyBhcmUgYXR0ZW1wdGVkID8gKGxpa2Ug Y3B1ZnJlcSBpc3N1aW5nIGNtZHMKd2hpbGUgcG9sbGluZyBhIHNlbnNvciBmcm9tIHNvbWUgb3Ro ZXIgdGhyZWFkKQoKLi4uSSdsbCBkaWcgZGVlcGVyIHRvZGF5IGluIHRoaXMgbWF0dGVyLCBidXQg bXkgY3VycmVudCBzdXNwZWN0IGlzIHRoYXQKdXNpbmcgdGhlIG1haWxib3ggVFhBY2sgSVJRIHRv IGxldCB0aGUgY29udHJvbGxlciB0aWNrIHRoZSBpbnRlcm5hbCBtYWlsYm94CnF1ZXVlcyBkb2Vz IG5vdCBwbGF5IHdlbGwgd2l0aCBTQ01JLCBzaW5jZSB0aGUgU0NNSSBUWCBjaGFubmVsIGlzIHJl YWxseSB0aGUKU0NNSSAiYTJwIiBiaWRpcmVjdGlvbmFsIGNoYW5uZWwgYW5kIGl0IGlzIGFzc29j aWF0ZWQgd2l0aCBqdXN0IG9ubHkgb25lIHNobWVtCmFyZWEgdXNlZCB0byBob2xkIGJvdGggdGhl IGVncmVzc2luZyBDTUQgYW5kIHRvIHJlY2VpdmUgdGhlIGluY29taW5nIFJFUExZCmZyb20gdGhl IHBsYXRmb3JtOiBzbyBpZiB5b3UgbGV0IHRoZSBjb250cm9sbGVyIHRpY2sgdGhlIHF1ZXVlcyBh cyBzb29uIGFzIHlvdQpyZWNlaXZlZCB0aGUgVFhBY2sgeW91IGFyZSB0ZWxsaW5nIHRoZSBtYWls Ym94IHN1YnN5c3RlbSB0byBxdWV1ZSBhbm90aGVyIG1lc3NhZ2UKb24gdGhlIHNhbWUgYXJlYSB3 aGlsZSB5b3UgYXJlIG5vdCByZWFsbHkgZG9uZSwgc2luY2Ugb25seSB0aGUgY2xpZW50IGtub3cK d2hlbiBpdCdzIGRvbmUgd2l0aCB0aGUgd2hvbGUgU0NNSSB0cmFuc2FjdGlvbiBhbmQgdGhlIHJl cGx5IGhhcyBiZWVuIGZldGNoZWQuCgpJbmRlZWQsIGZvciB0aGVzZSByZWFzb25zIHdlIGhhdmUg dGhlIEJVU1kvRlJFRSBiaXQgaW4gdGhlIHNobWVtIHRvIHByb3RlY3QgaXQKZnJvbSBwZW5kaW5n IG5ldyByZXF1ZXN0cyB1bnRpbCB0aGUgcHJldmlvdXMgb25lIGhhcyBjb21wbGV0ZWQsIGJ1dCB3 aGVuIHRoZQp3YWl0ZWQtZm9yIHJlcGx5IGNvbWVzIGluLCB0aGUgcGxhdGZvcm0gd291bGQgaGF2 ZSBjbGVhcmVkIHRoZSBCVVNZIGJpdCBhbmQKbGV0IHRoZSBuZXcgcXVldWVkIG1lc3NhZ2Ugb3Zl cndyaXRlIHRoZSBwZW5kaW5nIHJlcGx5IHByZW1hdHVyZWx5LCBhbmQgb25lCm1lc3NhZ2UgaXMg bG9zdC4uLgoKLi4uYnV0IGFzIHNhaWQgSSB3YW50IHRvIGRlbHZlIGRlZXBlciBpbnRvIHRoaXMs IGFzIG9mIG5vdyBqdXN0IHN1cHBvc2l0aW9ucwphbmQgbWF5YmUgSSBhbSBqdXN0IG1pc3Npbmcg c29tZXRoaW5nIG1vcmUgdGhhdCBoYXMgdG8gYmUgY29uZmlndXJlZApwcm9wZXJseS4uLgoKVGhh bmtzLApDcmlzdGlhbgoKPiBUaGFua3MuCj4gUGluLUNodWFuCj4gCj4gT24gRnJpLCAyMDI0LTAy LTAyIGF0IDIwOjM2ICswODAwLCBQaW4tQ2h1YW4gTGl1IHdyb3RlOgo+ID4gSGkgQ3Jpc3RpYW4s Cj4gPgo+ID4gVGhhbmtzIGZvciBraW5kbHkgcmV2aWV3IGFuZCBleHBsYWlucy4gWWVhaCwgSSBo YXZlIGV2ZXIgdHJpZWQKPiA+IGFub3RoZXIKPiA+IHdheSB0byBza2lwIHRoZSBjYWxsIChpLmUu IGxldCBtYXJrX3R4ZG9uZSBiZSBudWxsKS4gSG93ZXZlciwgaXQKPiA+IGxvb2tzCj4gPiBub3Qg ZWFzeSBhbmQgYWxzbyB0byBiYWNrcG9ydC4KPiA+Cj4gPiBBd2FpdGluZyB5b3VyIHRlc3QgcmVz dWx0cyBhbmQgZnVydGhlciBzdWdnZXN0aW9ucywgdGhhbmtzLgo+ID4KPiA+IFJlZ2FyZHMsCj4g PiBQaW4tQ2h1YW4KPiA+Cj4gCj4gCj4gKioqKioqKioqKioqKiBNRURJQVRFSyBDb25maWRlbnRp YWxpdHkgTm90aWNlICoqKioqKioqKioqKioqKioqKioqCj4gVGhlIGluZm9ybWF0aW9uIGNvbnRh aW5lZCBpbiB0aGlzIGUtbWFpbCBtZXNzYWdlIChpbmNsdWRpbmcgYW55Cj4gYXR0YWNobWVudHMp IG1heSBiZSBjb25maWRlbnRpYWwsIHByb3ByaWV0YXJ5LCBwcml2aWxlZ2VkLCBvciBvdGhlcndp c2UKPiBleGVtcHQgZnJvbSBkaXNjbG9zdXJlIHVuZGVyIGFwcGxpY2FibGUgbGF3cy4gSXQgaXMg aW50ZW5kZWQgdG8gYmUKPiBjb252ZXllZCBvbmx5IHRvIHRoZSBkZXNpZ25hdGVkIHJlY2lwaWVu dChzKS4gQW55IHVzZSwgZGlzc2VtaW5hdGlvbiwKPiBkaXN0cmlidXRpb24sIHByaW50aW5nLCBy ZXRhaW5pbmcgb3IgY29weWluZyBvZiB0aGlzIGUtbWFpbCAoaW5jbHVkaW5nIGl0cwo+IGF0dGFj aG1lbnRzKSBieSB1bmludGVuZGVkIHJlY2lwaWVudChzKSBpcyBzdHJpY3RseSBwcm9oaWJpdGVk IGFuZCBtYXkKPiBiZSB1bmxhd2Z1bC4gSWYgeW91IGFyZSBub3QgYW4gaW50ZW5kZWQgcmVjaXBp ZW50IG9mIHRoaXMgZS1tYWlsLCBvciBiZWxpZXZlCj4gdGhhdCB5b3UgaGF2ZSByZWNlaXZlZCB0 aGlzIGUtbWFpbCBpbiBlcnJvciwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyCj4gaW1tZWRpYXRl bHkgKGJ5IHJlcGx5aW5nIHRvIHRoaXMgZS1tYWlsKSwgZGVsZXRlIGFueSBhbmQgYWxsIGNvcGll cyBvZgo+IHRoaXMgZS1tYWlsIChpbmNsdWRpbmcgYW55IGF0dGFjaG1lbnRzKSBmcm9tIHlvdXIg c3lzdGVtLCBhbmQgZG8gbm90Cj4gZGlzY2xvc2UgdGhlIGNvbnRlbnQgb2YgdGhpcyBlLW1haWwg dG8gYW55IG90aGVyIHBlcnNvbi4gVGhhbmsgeW91IQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=