From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Chandan Babu R <chandanbabu@kernel.org>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [BUG REPORT] General protection fault while discarding extents on XFS on next-20240305
Date: Wed, 6 Mar 2024 06:45:44 -0800 [thread overview]
Message-ID: <ZeiBmGXgxNmgyjs4@infradead.org> (raw)
In-Reply-To: <ZeiAQv6ACQgIrsA-@kbusch-mbp>
On Wed, Mar 06, 2024 at 07:40:02AM -0700, Keith Busch wrote:
> Oh my mistake: xfs_discard_extents() does this in a loop and chains
> along the previous iteration's bio. Your update is needed and looks
> good.
Yeah, the whole point for the in/out biop parameter is to allow
this kind of chaining.
next prev parent reply other threads:[~2024-03-06 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:19 [BUG REPORT] General protection fault while discarding extents on XFS on next-20240305 Chandan Babu R
2024-03-06 12:35 ` Christoph Hellwig
2024-03-06 14:36 ` Keith Busch
2024-03-06 14:40 ` Keith Busch
2024-03-06 14:45 ` Christoph Hellwig [this message]
2024-03-06 15:18 ` Christoph Hellwig
2024-03-06 20:51 ` Dave Chinner
2024-03-06 22:16 ` Christoph Hellwig
2024-03-07 9:21 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeiBmGXgxNmgyjs4@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.