From: Ido Schimmel <idosch@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Simon Horman <horms@kernel.org>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next v4 2/7] net: nexthop: Add NHA_OP_FLAGS
Date: Wed, 6 Mar 2024 19:22:12 +0200 [thread overview]
Message-ID: <ZeimRPbhmo4m012Z@shredder> (raw)
In-Reply-To: <b66eaea956cb860a38c7ea77bf8571e386de5221.1709727981.git.petrm@nvidia.com>
On Wed, Mar 06, 2024 at 01:49:16PM +0100, Petr Machata wrote:
> In order to add per-nexthop statistics, but still not increase netlink
> message size for consumers that do not care about them, there needs to be a
> toggle through which the user indicates their desire to get the statistics.
> To that end, add a new attribute, NHA_OP_FLAGS. The idea is to be able to
> use the attribute for carrying of arbitrary operation-specific flags, i.e.
> not make it specific for get / dump.
>
> Add the new attribute to get and dump policies, but do not actually allow
> any flags yet -- those will come later as the flags themselves are defined.
> Add the necessary parsing code.
>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> Reviewed-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2024-03-06 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:49 [PATCH net-next v4 0/7] Support for nexthop group statistics Petr Machata
2024-03-06 12:49 ` [PATCH net-next v4 1/7] net: nexthop: Adjust netlink policy parsing for a new attribute Petr Machata
2024-03-09 15:02 ` Eric Dumazet
2024-03-09 17:50 ` David Ahern
2024-03-06 12:49 ` [PATCH net-next v4 2/7] net: nexthop: Add NHA_OP_FLAGS Petr Machata
2024-03-06 17:22 ` Ido Schimmel [this message]
2024-03-06 12:49 ` [PATCH net-next v4 3/7] net: nexthop: Add nexthop group entry stats Petr Machata
2024-03-06 12:49 ` [PATCH net-next v4 4/7] net: nexthop: Expose nexthop group stats to user space Petr Machata
2024-03-06 12:49 ` [PATCH net-next v4 5/7] net: nexthop: Add hardware statistics notifications Petr Machata
2024-03-06 12:49 ` [PATCH net-next v4 6/7] net: nexthop: Add ability to enable / disable hardware statistics Petr Machata
2024-03-06 12:49 ` [PATCH net-next v4 7/7] net: nexthop: Expose nexthop group HW stats to user space Petr Machata
2024-03-08 10:40 ` [PATCH net-next v4 0/7] Support for nexthop group statistics patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeimRPbhmo4m012Z@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.