From: Zhao Liu <zhao1.liu@linux.intel.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Prasad Pandit" <ppandit@redhat.com>,
qemu-devel@nongnu.org, "Xiaoling Song" <xiaoling.song@intel.com>,
"Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH 07/14] tests/unit/test-smp-parse: Bump max_cpus to 4096
Date: Thu, 7 Mar 2024 15:03:26 +0800 [thread overview]
Message-ID: <ZelmvuFwIuANB7bU@intel.com> (raw)
In-Reply-To: <90b8cc0e-3ad7-4121-8797-41cb65903fa8@redhat.com>
Hi Thomas,
> > /*
> > - * config: -smp 512
> > + * config: -smp 4096
> > * The test machine should tweak the supported max CPUs to
> > - * 511 (MAX_CPUS - 1) for testing.
> > + * 4095 (MAX_CPUS - 1) for testing.
> > */
> > - .config = SMP_CONFIG_GENERIC(T, MAX_CPUS, F, 0, F, 0, F, 0, F, 0),
> > - .expect_error = "Invalid SMP CPUs 512. The max CPUs supported "
> > - "by machine '" SMP_MACHINE_NAME "' is 511",
> > + .config = SMP_CONFIG_GENERIC(T, 4096, F, 0, F, 0, F, 0, F, 0),
> > + .expect_error = "Invalid SMP CPUs 4096. The max CPUs supported "
>
> You could maybe use stringify(MAX_CPUS) in above line
> (but it won't work for the 4095 below, so it's maybe not worth the effort)
Yes, it's also because of corner cases like 4095 that I don't do such a
thorough cleanup here.
> > + "by machine '" SMP_MACHINE_NAME "' is 4095",
> > },
> > };
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Thanks!
Zhao
next prev parent reply other threads:[~2024-03-07 6:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:53 [PATCH 00/14] Cleanup on SMP and its test Zhao Liu
2024-03-06 9:53 ` [PATCH 01/14] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations Zhao Liu
2024-03-06 9:53 ` [PATCH 02/14] hw/core/machine-smp: Deprecate unsupported "parameter=1" " Zhao Liu
2024-03-07 6:22 ` Thomas Huth
2024-03-07 7:07 ` Zhao Liu
2024-03-06 9:53 ` [PATCH 03/14] hw/core/machine-smp: Simplify variables' initialization in machine_parse_smp_config() Zhao Liu
2024-03-08 13:20 ` Thomas Huth
2024-03-08 15:33 ` Zhao Liu
2024-03-10 11:55 ` Prasad Pandit
2024-03-11 5:20 ` Zhao Liu
2024-03-13 10:52 ` Prasad Pandit
2024-03-18 8:06 ` Zhao Liu
2024-03-18 11:18 ` Prasad Pandit
2024-03-06 9:53 ` [PATCH 04/14] hw/core/machine-smp: Calculate total CPUs once " Zhao Liu
2024-03-06 20:56 ` Philippe Mathieu-Daudé
2024-03-06 9:53 ` [PATCH 05/14] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case Zhao Liu
2024-03-08 13:22 ` Thomas Huth
2024-03-06 9:53 ` [PATCH 06/14] tests/unit/test-smp-parse: Use CPU number macros in invalid topology case Zhao Liu
2024-03-06 9:54 ` [PATCH 07/14] tests/unit/test-smp-parse: Bump max_cpus to 4096 Zhao Liu
2024-03-07 6:01 ` Thomas Huth
2024-03-07 7:03 ` Zhao Liu [this message]
2024-03-06 9:54 ` [PATCH 08/14] tests/unit/test-smp-parse: Make test cases aware of the book/drawer Zhao Liu
2024-03-06 9:54 ` [PATCH 09/14] tests/unit/test-smp-parse: Test "books" parameter in -smp Zhao Liu
2024-03-06 9:54 ` [PATCH 10/14] tests/unit/test-smp-parse: Test "drawers" " Zhao Liu
2024-03-06 9:54 ` [PATCH 11/14] tests/unit/test-smp-parse: Test "drawers" and "books" combination case Zhao Liu
2024-03-07 6:07 ` Thomas Huth
2024-03-06 9:54 ` [PATCH 12/14] tests/unit/test-smp-parse: Test the full 7-levels topology hierarchy Zhao Liu
2024-03-06 9:54 ` [PATCH 13/14] tests/unit/test-smp-parse: Test smp_props.has_clusters Zhao Liu
2024-03-06 9:54 ` [PATCH 14/14] tests/unit/test-smp-parse: Test "parameter=0" SMP configurations Zhao Liu
2024-03-07 6:11 ` Thomas Huth
2024-03-06 21:07 ` [PATCH 00/14] Cleanup on SMP and its test Philippe Mathieu-Daudé
2024-03-07 7:25 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZelmvuFwIuANB7bU@intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=xiaoling.song@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.