From: Niklas Cassel <cassel@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: Igor Pylypiv <ipylypiv@google.com>,
Damien Le Moal <dlemoal@kernel.org>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Hannes Reinecke <hare@suse.de>,
Xiang Chen <chenxiang66@hisilicon.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
TJ Adams <tadamsjr@google.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group
Date: Thu, 7 Mar 2024 10:59:32 +0100 [thread overview]
Message-ID: <ZemQBLMcJP617WDC@ryzen> (raw)
In-Reply-To: <c3ebaa55-d05b-4f11-83a8-2a0fb85044cf@oracle.com>
On Thu, Mar 07, 2024 at 08:55:51AM +0000, John Garry wrote:
> On 06/03/2024 20:56, Igor Pylypiv wrote:
> > > > ---
> > > > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> > > > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
> > > Is there a reason why you didn't patch:
> > > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
> > >
> > I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> > that v1 HW doesn't support SATA so I dropped the change.
>
> If you are going to do another spin, then maybe update the commit message
> with this.
+1
John, now I'm curious, do you know why hisi_sas_v1_hw.c is implemented
as a libsas driver (instead of a regular SCSI driver), if it doesn't
support SATA?
Was perhaps v2_hw and v3_hw implemented as a libsas driver first
(since they support SATA), and v1_hw support was added later,
so that it could reuse much of the parts of the existing driver?
Kind regards,
Niklas
next prev parent reply other threads:[~2024-03-07 9:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:22 [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices Igor Pylypiv
2024-03-06 10:54 ` Niklas Cassel
2024-03-06 19:28 ` Igor Pylypiv
2024-03-07 9:51 ` Niklas Cassel
2024-03-07 21:41 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 1:22 ` [PATCH v7 4/7] scsi: mvsas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 21:13 ` Igor Pylypiv
2024-03-07 9:52 ` Niklas Cassel
2024-03-07 20:35 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 5/7] scsi: hisi_sas: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 20:56 ` Igor Pylypiv
2024-03-07 8:55 ` John Garry
2024-03-07 9:59 ` Niklas Cassel [this message]
2024-03-07 11:17 ` John Garry
2024-03-06 1:22 ` [PATCH v7 6/7] scsi: aic94xx: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 21:17 ` Igor Pylypiv
2024-03-06 1:22 ` [PATCH v7 7/7] scsi: isci: " Igor Pylypiv
2024-03-06 10:55 ` Niklas Cassel
2024-03-06 10:54 ` [PATCH v7 0/7] NCQ Priority sysfs sttributes for libsas Niklas Cassel
2024-03-06 21:33 ` Igor Pylypiv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZemQBLMcJP617WDC@ryzen \
--to=cassel@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=bvanassche@acm.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.