From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9674E51C45; Thu, 7 Mar 2024 20:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709843565; cv=none; b=inqJJ8lcajPL4/Rv/HGBSrmzlX3zI15Kevl2Ddu19Wvw2Id7SowbFzKFoBw6InXtijAsD1lu0ECsYP31znaG296puzlbK+//nfB4VieUVEedRxNmc+7P1u2DdFUFTNAQW3leQPDiHBnJSHjCP68AeBhU6xlQsI04nWGQmwMV4Cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709843565; c=relaxed/simple; bh=/eQrZoho3Wzd/75riAoruvb3tT+NYdsxycvt61HCYmQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i4DABe3y7CnsL/JC3tBCXVUsBUEPozNmPl87cRUojRb5EZFsp9jcJlqWvEzGRcGQtVfX2prvVwhLeITAP28CZrLOcOFNVc1Yc5ByoS+3O4qX8jJDASyf0ea/XkZUcwaEDc1CJzKAXlTEuGm7tHKwpwmeM4C6s0ydgbjcQ4xKRPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XNX5GCMv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XNX5GCMv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F8FCC433C7; Thu, 7 Mar 2024 20:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709843565; bh=/eQrZoho3Wzd/75riAoruvb3tT+NYdsxycvt61HCYmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNX5GCMvQd5p6SjKBCBDsFaGBKXnIVmmhZvMc1W8pH447n17fUwmEaDyqLyMdbSQY 2t/EYdMtL7v6Nl2hsDlwbc9m5lgDCP7fYvhYNJZBZ1dONwb2FB//LuqX/4/7Uk4Jhf BZw+mbfxjqaWkZ4slSudIrtB/RAVrWEZUeRqB4zyd4FhD13s+mPETJg1AQIgvqC07t gFDWnbqkvP5UQr1Pi5SxnaPKw13PzGDvJsIvpdMiKMsyPLRyE2G2Vh+ejhfqw3xCaU 16m8UQ+otYlGXUAF+Q0tqKVPdpJ+XnkCyonux+8lyDex7cu5Hq3m6XRAZxkAkNsMje yLa33Z8NVr1PA== Date: Thu, 7 Mar 2024 21:32:34 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 05/10] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> On Mon, Mar 04, 2024 at 02:52:17PM +0530, Manivannan Sadhasivam wrote: > The goal of the dw_pcie_ep_init_complete() API is to initialize the DWC > specific registers post registering the controller with the EP framework. > > But the naming doesn't reflect its functionality and causes confusion. So, > let's rename it to dw_pcie_ep_init_registers() to make it clear that it > initializes the DWC specific registers. > > Reviewed-by: Frank Li > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Niklas Cassel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE4A1C54798 for ; Thu, 7 Mar 2024 20:33:29 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XNX5GCMv; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrLbr4qj6z3vs3 for ; Fri, 8 Mar 2024 07:33:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XNX5GCMv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=cassel@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrLb35Bxrz3vb5 for ; Fri, 8 Mar 2024 07:32:47 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B4401CE262C; Thu, 7 Mar 2024 20:32:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F8FCC433C7; Thu, 7 Mar 2024 20:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709843565; bh=/eQrZoho3Wzd/75riAoruvb3tT+NYdsxycvt61HCYmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNX5GCMvQd5p6SjKBCBDsFaGBKXnIVmmhZvMc1W8pH447n17fUwmEaDyqLyMdbSQY 2t/EYdMtL7v6Nl2hsDlwbc9m5lgDCP7fYvhYNJZBZ1dONwb2FB//LuqX/4/7Uk4Jhf BZw+mbfxjqaWkZ4slSudIrtB/RAVrWEZUeRqB4zyd4FhD13s+mPETJg1AQIgvqC07t gFDWnbqkvP5UQr1Pi5SxnaPKw13PzGDvJsIvpdMiKMsyPLRyE2G2Vh+ejhfqw3xCaU 16m8UQ+otYlGXUAF+Q0tqKVPdpJ+XnkCyonux+8lyDex7cu5Hq3m6XRAZxkAkNsMje yLa33Z8NVr1PA== Date: Thu, 7 Mar 2024 21:32:34 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Subject: Re: [PATCH v9 05/10] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@ lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 04, 2024 at 02:52:17PM +0530, Manivannan Sadhasivam wrote: > The goal of the dw_pcie_ep_init_complete() API is to initialize the DWC > specific registers post registering the controller with the EP framework. > > But the naming doesn't reflect its functionality and causes confusion. So, > let's rename it to dw_pcie_ep_init_registers() to make it clear that it > initializes the DWC specific registers. > > Reviewed-by: Frank Li > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Niklas Cassel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A611C54798 for ; Thu, 7 Mar 2024 20:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DoNUIQ0GLM2e0yEmJPlbunNHaUG5uElWJZZxOhw7SmM=; b=3vBK8PKMH/RaAw U8w587O3tz3Y6fDwXbXXX8rfOjoMBZHX4MUTqVJeOdgxjVJGYy7ZKIOKqUZrfhLLGl3iG1kkLHnjJ knWQHhrh/BnVaT4ovr2/8aivmckkEn8wLtJM8zsWI0YdL71zQpt1SgYnCa95Q6clOyKQMTZ4WEsXb ASf9lXW0Bis3yCgtAy89oxyWAaijbRNAk9AvqkOIa+036Nc8MWHjWawePh4rbuKh0dItrAZz4ZeoX cKOz0LnSlfT42hVhAqx6D02yRI60Dgl/LEDB1GSdYFNRduBSYcUdaBbhsYKcsP+Xpv2NnBLQpml7/ K1oa4OOXeaGkrkFB8X3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riKQ9-00000006Ico-0P7j; Thu, 07 Mar 2024 20:32:53 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riKQ3-00000006IbR-3oct for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2024 20:32:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B4401CE262C; Thu, 7 Mar 2024 20:32:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F8FCC433C7; Thu, 7 Mar 2024 20:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709843565; bh=/eQrZoho3Wzd/75riAoruvb3tT+NYdsxycvt61HCYmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNX5GCMvQd5p6SjKBCBDsFaGBKXnIVmmhZvMc1W8pH447n17fUwmEaDyqLyMdbSQY 2t/EYdMtL7v6Nl2hsDlwbc9m5lgDCP7fYvhYNJZBZ1dONwb2FB//LuqX/4/7Uk4Jhf BZw+mbfxjqaWkZ4slSudIrtB/RAVrWEZUeRqB4zyd4FhD13s+mPETJg1AQIgvqC07t gFDWnbqkvP5UQr1Pi5SxnaPKw13PzGDvJsIvpdMiKMsyPLRyE2G2Vh+ejhfqw3xCaU 16m8UQ+otYlGXUAF+Q0tqKVPdpJ+XnkCyonux+8lyDex7cu5Hq3m6XRAZxkAkNsMje yLa33Z8NVr1PA== Date: Thu, 7 Mar 2024 21:32:34 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, Frank Li Subject: Re: [PATCH v9 05/10] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240304-pci-dbi-rework-v9-5-29d433d99cda@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_123250_702179_17E1D372 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2024 at 02:52:17PM +0530, Manivannan Sadhasivam wrote: > The goal of the dw_pcie_ep_init_complete() API is to initialize the DWC > specific registers post registering the controller with the EP framework. > > But the naming doesn't reflect its functionality and causes confusion. So, > let's rename it to dw_pcie_ep_init_registers() to make it clear that it > initializes the DWC specific registers. > > Reviewed-by: Frank Li > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Niklas Cassel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel