All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Justinien Bouron <justinien.bouron@gmail.com>
Cc: armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net,
	kraxel@redhat.com, marcandre.lureau@redhat.com,
	pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] input-linux: Add option to not grab a device upon guest startup
Date: Fri, 8 Mar 2024 08:42:08 +0000	[thread overview]
Message-ID: <ZerPYH7KkLpmgTEV@redhat.com> (raw)
In-Reply-To: <20240308033827.2835989-1-justinien.bouron@gmail.com>

On Thu, Mar 07, 2024 at 07:38:27PM -0800, Justinien Bouron wrote:
> > This last two lines doesn't make sense to me. Isn't the grab
> > toggling entirely in control of the QEMU process, regardless
> > of what state the guest is at ?
> 
> Actually, you're right, they do not make sense. This issue of having the guest
> taking a while to start and the toggle keys not working, only seem to appear
> when running the VM under libvirt. I was not able to reproduce this issue when
> running qemu directly from the command line. So either this is a libvirt issue
> or something related to my setup (VFIO with GPU passthrough, so a lot can go
> wrong).
> 
> Should I send a new version of the patch with an updated commit message that
> does not mention this issue?

If that probem does not exist, what is the compelling reason to
add this patch ?

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2024-03-08  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  6:28 [PATCH] input-linux: Add option to not grab a device upon guest startup Justinien Bouron
2024-03-07  9:54 ` Daniel P. Berrangé
2024-03-08  3:38   ` Justinien Bouron
2024-03-08  8:42     ` Daniel P. Berrangé [this message]
2024-03-08 14:34       ` Justinien Bouron
2024-03-15  2:36 ` Justinien Bouron
2024-03-15  6:06   ` Marc-André Lureau
2024-03-15  6:07 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZerPYH7KkLpmgTEV@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=justinien.bouron@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.