From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19261C5475B for ; Fri, 8 Mar 2024 14:56:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5BA11138DD; Fri, 8 Mar 2024 14:56:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Sb4RnSeQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 001991138DD for ; Fri, 8 Mar 2024 14:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709909766; x=1741445766; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=HdMJ6tH65M+a6boZG2S6HfMEPzn/p5gGtttY5K6b984=; b=Sb4RnSeQoFSbf+6j9de+rPyHtbur6UT88BlNdDlBhqykwV1CNNmfx3R0 Kd5F7PygPJiQKFeWeFVMfasBneMlDNYispjkqZAAcnjZ78+xgOlltmStm V+HP2sCBTCC+ZeAuaR8dWrgmlRs+T5wPNdNIGhJSndcELN3Tpf66FkhJu NKtTzBAQVK1Us/Sx6SywOMyDo68mKV043C6k2Psyai7SMZ6KYlBXhYsKR aYyPOwuzzLDU3oUH7pzAfW71QYP7gIPhuODsiZ9nF9DEeWpg7Yvje/1qu uTkgKYQ/2BuN6eAbf5ylSTV8M4/wPEkMJrrVUCSTKPUcDhap8o36vsw/z Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="7576667" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="7576667" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 06:56:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="827775257" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="827775257" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 08 Mar 2024 06:56:02 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 08 Mar 2024 16:56:01 +0200 Date: Fri, 8 Mar 2024 16:56:01 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jouni =?iso-8859-1?Q?H=F6gander?= Cc: intel-gfx@lists.freedesktop.org, Jani Nikula Subject: Re: [PATCH v5 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond Message-ID: References: <20240308110039.3900838-1-jouni.hogander@intel.com> <20240308110039.3900838-5-jouni.hogander@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 08, 2024 at 04:39:55PM +0200, Ville Syrjälä wrote: > On Fri, Mar 08, 2024 at 01:00:38PM +0200, Jouni Högander wrote: > > IO buffer wake time used for IO wake calculation is dependent on port clock > > on LunarLake and beyond. Take this into account in get_io_buffer_wake_time. > > > > Bspec: 65450 > > > > v2: add own io_wake_time helper for LunarLake > > > > Signed-off-by: Jouni Högander > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > > index 747761efa4be..e3daaf05d640 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -1165,11 +1165,23 @@ static int tgl_io_buffer_wake_time(void) > > return 10; > > } > > > > +static int lnl_io_buffer_wake_time(int port_clock) > > +{ > > + if (port_clock > 270000) > > + return 10; > > + else if (port_clock > 162000) > > + return 11; > > + else > > + return 15; > > +} > > These numbers are only listed in the MTL section of bspec. There > is nothing like this in the LNL PHY power section AFAICS. Windows appears to use fixed 12us here. > > > + > > static int io_buffer_wake_time(const struct intel_crtc_state *crtc_state) > > { > > struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev); > > > > - if (DISPLAY_VER(i915) >= 12) > > + if (DISPLAY_VER(i915) >= 20) > > + return lnl_io_buffer_wake_time(crtc_state->port_clock); > > + else if (DISPLAY_VER(i915) >= 12) > > return tgl_io_buffer_wake_time(); > > else > > return skl_io_buffer_wake_time(); > > -- > > 2.34.1 > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel