Re: [PATCH] drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote:
> Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure
> after linux-next include refactoring.

any lore link so we can use with a 'Closes:' tag?
and perhaps a reported-by?

> 
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tursulin@ursulin.net>
> ---
>  drivers/gpu/drm/i915/i915_memcpy.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_memcpy.c b/drivers/gpu/drm/i915/i915_memcpy.c
> index ba82277254b7..cc41974cee74 100644
> --- a/drivers/gpu/drm/i915/i915_memcpy.c
> +++ b/drivers/gpu/drm/i915/i915_memcpy.c
> @@ -25,6 +25,8 @@
>  #include <linux/kernel.h>
>  #include <linux/string.h>
>  #include <linux/cpufeature.h>
> +#include <linux/bug.h>
> +#include <linux/build_bug.h>

git grep BUILD_BUG_ON drivers/gpu/drm/i915/
output

vs

git grep build_bug.h drivers/gpu/drm/i915/
output

tells me that we likely need this in many more files...

but not opposed to move with this faster and come back later with
other fixes if this unblocks people:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  #include <asm/fpu/api.h>
>  
>  #include "i915_memcpy.h"
> -- 
> 2.43.2
>