All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <msnitzer@redhat.com>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	dm-devel@lists.linux.dev
Subject: Re: [PATCH] dm-integrity: align the outgoing bio in integrity_recheck
Date: Fri, 22 Mar 2024 20:58:44 +0800	[thread overview]
Message-ID: <Zf2AhG0r8vcRMvLi@fedora> (raw)
In-Reply-To: <f4149577-ac28-b4f2-1a89-37845c197677@redhat.com>

On Fri, Mar 22, 2024 at 01:32:30PM +0100, Mikulas Patocka wrote:
> 
> 
> On Fri, 22 Mar 2024, Ming Lei wrote:
> 
> > If logical block becomes mismatched by reconfiguration, the whole DM stack can't work:
> > 
> > - at the beginning, DM is over NVMe(512 bs), DM & NVMe lbs is 512
> > - later, nvme is reconfigured and its lbs becomes 4k, but DM's lbs can't
> > be updated
> > - then unaligned IO is submitted to NVMe
> > 
> > So DM _never_ works with mis-matched logical block size because of
> > reconfigure, and same with MD.
> 
> It can work. If a filesystem has 4k block size and it is used on a block

Here 'work' means it supports any allowed block size, instead of 4KB only
or if balabala...

The DM device advertises its lbs as 512, application & FS should be
free to read/write 512 aligned data, right?


Thanks, 
Ming


  reply	other threads:[~2024-03-22 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 16:48 [PATCH] dm-integrity: align the outgoing bio in integrity_recheck Mikulas Patocka
2024-03-22  1:41 ` Ming Lei
2024-03-22 10:30   ` Mikulas Patocka
2024-03-22 12:03     ` Ming Lei
2024-03-22 12:32       ` Mikulas Patocka
2024-03-22 12:58         ` Ming Lei [this message]
2024-03-22 15:53       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zf2AhG0r8vcRMvLi@fedora \
    --to=ming.lei@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=mpatocka@redhat.com \
    --cc=msnitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.