From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29CED604BC for ; Fri, 22 Mar 2024 17:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711129739; cv=none; b=RZbShqUnh2FZSQJwiakHhThNL+bqevR+wcS6oE5fdrZDnrHa+uiKtUCuvICsWeNcRLbEOEWUSryjLYbXjUGTqHWji3kJfDLuQYNTc4QSsGCkoBGv1YseiycE98N4/V6JuB+HEMF3lGS+1bBJKg10pEPb1kNQWGlcyNvxQLxcwF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711129739; c=relaxed/simple; bh=r+4PuloVCi8RDOAoyLYF9VmfzCqPgx10kp/bvJjIT/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lkDvAdj2FgT0epdgYdzYmo17DMA1NQm0pU842J9uuOUpl+vjupPLwbf8a5j7cskKStNcmdOnI/WqEnzSQDtrKlhbP/EVok0YZkIA8K+k5SGNOrokROE4syVa3s6GMnvtJn81Uhm4F03PJIT9oGn8meJrNVCG0sjloITSj6cusxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uyo/gwlZ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uyo/gwlZ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-413f8c8192eso7775e9.0 for ; Fri, 22 Mar 2024 10:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711129736; x=1711734536; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Mzqp/6dLgjMqKDQyf3mrQct0p3T2914IUgA3ZIQhwEo=; b=uyo/gwlZ+Gnh/pAeOd7xnbka/IeM9WNbURPgG0ybEGZkaxsE4kd5Nu2/bLawsU7VSt G6urUY/bITaEFPN6977GP2wBgrCL4S8h+bUdYwi1Lo2DRTmZ0u6hJNSADjh3mqD4dEzo mn8bY1bHFcxmg2z5RzIDGahTP3uRu3YA/yYMoBS1XjA50YlsOXw5592QVp/srKU5cqbz +UHaiolZJtLHOPHSgM0DPhbt35RCpvZNkR6wwyUMxbCGnt+AWbly7mAX4uMMY2NsEYtg HcfvZrgfJgj9NhjBwcqVL73ygGb52snPy68hI4gnO9yUdHXt7lcNNF1zpO4IUchC8YLS jY4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711129736; x=1711734536; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mzqp/6dLgjMqKDQyf3mrQct0p3T2914IUgA3ZIQhwEo=; b=cn6JyBZOfQqpRSzNxlYnHMwxez5DDL7xkPhrwHsNErQHyK5/oKTCMgyED+10RT/nZR Ghpq/iktu+q+XiRFAVefmUjxtbvjkBU8wnNKU4SLHf71ktlqv5AR4W41stSqcT87pUoD TlqRUCqyswE1+vjn2ZDWjMlTKDc74aU2HmLgcVAvtaRcVS+04/r19KFtYdo8l8Qb5QI4 mzVSyterr5A2fIDWFv5mhIveiyL3NJ3RSexWNmC0G/n6Bpln1OGUS2ow9u/k1L81u/Kq VMqvJTPBB3LxpKjEzV8HgtYgIu5sYJqTKIAzNJLuRhTIo8kiuaAOIdWszfV5bqXavltP +PHQ== X-Gm-Message-State: AOJu0YzPpzCam4pbuV/AjP4x1w+l0oDZZf7ucWFFPr6MCPrEvXh6Ek5m 3Ma+73AyFThtKCCN8jDPnL2bHXyFSrP1qBfBS5qVdL9Ky8ShlF0BPLMEdNXlTQ== X-Google-Smtp-Source: AGHT+IGHu63FaJns9JaXXBeuHGQZAWu5RyrwAL0IsGUibXz84z8HGlng2x1LsE39qLp74E9EsXarBg== X-Received: by 2002:a7b:c40a:0:b0:414:11:ec14 with SMTP id k10-20020a7bc40a000000b004140011ec14mr534253wmi.6.1711129736458; Fri, 22 Mar 2024 10:48:56 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id d1-20020a05600c34c100b004147dd0915dsm152246wmq.21.2024.03.22.10.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 10:48:55 -0700 (PDT) Date: Fri, 22 Mar 2024 17:48:52 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 01/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Hi Jason, On Mon, Mar 04, 2024 at 07:43:49PM -0400, Jason Gunthorpe wrote: > The SVA code is wired to assume that the SVA is programmed onto the > mm->pasid. The current core code always does this, so it is fine. > > Add a check for clarity. > > Tested-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > index 2610e82c0ecd0d..347c2fdd865c1a 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > @@ -581,6 +581,9 @@ static int arm_smmu_sva_set_dev_pasid(struct iommu_domain *domain, > int ret = 0; > struct mm_struct *mm = domain->mm; > > + if (mm_get_enqcmd_pasid(mm) != id) > + return -EINVAL; > + I am not sure if that is needed, the only caller in the tree is the IOMMU code and it does the right thing, as that check is removed later anyway, I don’t think this patch adds much. > mutex_lock(&sva_lock); > ret = __arm_smmu_sva_bind(dev, id, mm); > mutex_unlock(&sva_lock); > -- > 2.43.2 Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A182FC54E71 for ; Fri, 22 Mar 2024 17:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nU7mGqx2b0iRiw/y9+hfN73EtEV4NatAkxbLLiuog08=; b=w+cldSrVu1uY4L nTzigzYErFiSzovV1GAV97E/cXITqKHGmoNgBSZAnwq+H2z9bIYFUVLCKZykDEDYR39mU3rudJPy5 A9gJdwZfQl4jD9GjVZTrvxUKYVr+AHdmrH6f4QESM7FWlKTqWKRHV8/vM+9/Zso1K1yYSUCZ7OIXx /kzsHLIHs4CvvOgehEN3Y5r1wmZqEcYUpmjuW2GP9p0DNZKunvzTiStCmmitx0ze58FZLJOJdWkUj py58bILmlCwPqSpEujsiiL9nQWLVPbnC3GlrAFSeUq+GE3ePloT53WKuvl5A0KmhFsIxeKd+SFsgV Kr17SA6z6MBDCu9B/cjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnj0p-00000008DjH-3H7L; Fri, 22 Mar 2024 17:49:03 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnj0m-00000008DiE-0SgO for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 17:49:01 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-413f8c8192eso7785e9.0 for ; Fri, 22 Mar 2024 10:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711129736; x=1711734536; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Mzqp/6dLgjMqKDQyf3mrQct0p3T2914IUgA3ZIQhwEo=; b=ihci7+p1Bg81PUetbKYq9RhHT3b0E3qCKZ7BCaKYXlkefROki1pv9H9Y2IUVMZ4x40 yj7Tvn3JPsrsUkDFcjgR38Ptk9I0aC4eGLykLze3LOvZ3pxtY0H4R0iY3ChMj82Imkth +VPBlcWDZQsk0/3DKiFDlH1U5IH2nsC+wScDhiWtl9qT0z2EmXYQhURySEJpic1OSndj gk+dHl2BIlfy25wApnz0Jw0RGj7Yc8/VS0zSmEaAezRN0FYcYzI4u677WoTdauUcS5ti zZiZYq23zO5jUkmagsadtLyymVliRLUzsjMWPZgYeYsd3ST0JQH9Mfno/aAFFxzjZV9Z 532Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711129736; x=1711734536; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mzqp/6dLgjMqKDQyf3mrQct0p3T2914IUgA3ZIQhwEo=; b=brufWmianhbCsmPHAdN9jXb2a3ZvBtWsmwq9k6LdAlCu+WTn5zEKIt4qegFsL3ClFk B+tdk2QKSPacs7y9q6uRrYJ4O98EpqbU9SLwFIfFOwbsB5q0YVgBIY64UkdhABCNRQ5B a4oUWSSbpAYlVagq1eJRwFpRLKKJRCdBWH6Dw7RcMyUnUgYtGklQjY/gyThN2qgKleIk r78BgR5g6A3hjwgfjloTcsmhTSJPAnqpJniI2IXjjEbyNMxG0TCj4+s0RJJJOa+80SV+ 0hdu+iQw351UWvfz9uie8NyAnY7AcZsi6AEWUuIkHeZR1ci7j7VPl24m9srojpRY6Ewz BAZQ== X-Forwarded-Encrypted: i=1; AJvYcCX2Ddzspc9iUpYtl/wqkBYI8uuDzHeu/XpTUGqcbT5wb6kf44qkf8mdzcKL0SkHCtcVRA6ACovpQj3rTS6Bz36ktVAc350l0nEYraaQpWnwU1VeHO0= X-Gm-Message-State: AOJu0Yy08H8KtID+13fQtRouzpkBZ1pMxgDtqbWf2cTGG9WblYQL2xz4 YKYXbFyqsQWv3MV9zgT6aeUWDst0ewxwel0kYt7XBWQG6GZQNs2xP0bGv8HURA== X-Google-Smtp-Source: AGHT+IGHu63FaJns9JaXXBeuHGQZAWu5RyrwAL0IsGUibXz84z8HGlng2x1LsE39qLp74E9EsXarBg== X-Received: by 2002:a7b:c40a:0:b0:414:11:ec14 with SMTP id k10-20020a7bc40a000000b004140011ec14mr534253wmi.6.1711129736458; Fri, 22 Mar 2024 10:48:56 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id d1-20020a05600c34c100b004147dd0915dsm152246wmq.21.2024.03.22.10.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 10:48:55 -0700 (PDT) Date: Fri, 22 Mar 2024 17:48:52 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 01/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_104900_221584_3059BA31 X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwNzo0Mzo0OVBNIC0wNDAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gVGhlIFNWQSBjb2RlIGlzIHdpcmVkIHRvIGFzc3VtZSB0aGF0 IHRoZSBTVkEgaXMgcHJvZ3JhbW1lZCBvbnRvIHRoZQo+IG1tLT5wYXNpZC4gVGhlIGN1cnJlbnQg Y29yZSBjb2RlIGFsd2F5cyBkb2VzIHRoaXMsIHNvIGl0IGlzIGZpbmUuCj4gCj4gQWRkIGEgY2hl Y2sgZm9yIGNsYXJpdHkuCj4gCj4gVGVzdGVkLWJ5OiBOaWNvbGluIENoZW4gPG5pY29saW5jQG52 aWRpYS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMtc3Zh LmMgfCAzICsrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLXN2YS5jIGIv ZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMtc3ZhLmMKPiBpbmRleCAy NjEwZTgyYzBlY2QwZC4uMzQ3YzJmZGQ4NjVjMWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9pb21t dS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMtc3ZhLmMKPiArKysgYi9kcml2ZXJzL2lvbW11 L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My1zdmEuYwo+IEBAIC01ODEsNiArNTgxLDkgQEAg c3RhdGljIGludCBhcm1fc21tdV9zdmFfc2V0X2Rldl9wYXNpZChzdHJ1Y3QgaW9tbXVfZG9tYWlu ICpkb21haW4sCj4gIAlpbnQgcmV0ID0gMDsKPiAgCXN0cnVjdCBtbV9zdHJ1Y3QgKm1tID0gZG9t YWluLT5tbTsKPiAgCj4gKwlpZiAobW1fZ2V0X2VucWNtZF9wYXNpZChtbSkgIT0gaWQpCj4gKwkJ cmV0dXJuIC1FSU5WQUw7Cj4gKwpJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMgbmVlZGVkLCB0aGUg b25seSBjYWxsZXIgaW4gdGhlIHRyZWUgaXMgdGhlIElPTU1VIGNvZGUKYW5kIGl0IGRvZXMgdGhl IHJpZ2h0IHRoaW5nLCBhcyB0aGF0IGNoZWNrIGlzIHJlbW92ZWQgbGF0ZXIgYW55d2F5LCBJIGRv buKAmXQKdGhpbmsgdGhpcyBwYXRjaCBhZGRzIG11Y2guCgo+ICAJbXV0ZXhfbG9jaygmc3ZhX2xv Y2spOwo+ICAJcmV0ID0gX19hcm1fc21tdV9zdmFfYmluZChkZXYsIGlkLCBtbSk7Cj4gIAltdXRl eF91bmxvY2soJnN2YV9sb2NrKTsKPiAtLSAKPiAyLjQzLjIKClRoYW5rcywKTW9zdGFmYQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=