From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2A36E5EE for ; Fri, 22 Mar 2024 19:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711134438; cv=none; b=LITHmRFRJ9LBDDC4BwtKNcdlB8B6Vmzq1UQCx4bjGJBtAWBU+uEorgEzzp20A1nQCztKc19e5RBmxM2z0AVS4/pJJCajfjjBYlt3C0OlF6md9xQu87lpfH+1J4FhmO4agOOKMenc4RNvPfZZ4Nd1hSt438FImlBmdjLcAuEmru0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711134438; c=relaxed/simple; bh=5clcENVPl84v7thAD523MC8hq38AuZBiMpmV/P8IXN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u0gU5P2eJs3Fid0M7rcSHn7zFp6LB6wqWivqtfnBAy1HTP960zabSxMUSN7uvd1zpTE5GGTwScCRCfhHpZYW+XFmWljMs87DLmwsvRxo9ASDs/VKvLHZeLWfJjAchxMz6fvJSyRN8MeC8mOf5jLLnmbKZGD1AI6kHaoMrcLP5a0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GasikVqr; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GasikVqr" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-413f8c8192eso14925e9.0 for ; Fri, 22 Mar 2024 12:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711134435; x=1711739235; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LYZVGNnxMtJXmO/rMtm5YPA7SokYhXE01EEUSWS+tyg=; b=GasikVqrJktaOYlx370eaM9zq74Oi//j4eAfMYZfW5fKGW8bYlhrEfJCqe0D7klKke RZZ6pUnH/ZYjnd00+jXuzzlG1NenMBImzkYnO9OrTGsr6dXNLyVTguFsIMfc02SFiR8S 8oFFXmD2HPzM4f3MQlomohcIkSbV7lh26Rb8MwsnoZJ7SZbnDxCBqPXCun9U5xsRKeZf iWlQkoMIwsT87zNxzmxUxvDVrD5FjqAr6HOyUjNUT1SOxxcWRnTHR5a3ync85S8hDOsO EQI7zW+BidPh9CU42K4oaX8ILl/7SjMVG4KA/flD4Ow7OXjK8rvsqQryK8OYlsSKbxLR krQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134435; x=1711739235; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYZVGNnxMtJXmO/rMtm5YPA7SokYhXE01EEUSWS+tyg=; b=p9IUyQruR9mgBAQjh2nT4JC2j5c1ajUelQtUoYtEDuG6xz3Ef1XjQvZgi6w3dfzxVb joY3B5tyx0Tcs4oScQEFqRvCroduXN8hoZqdp1zb0rtGa27LyZgQAhiojhs5AM32RvHL r8KM6u0ysMEMig7O1+bOWTO1mjkGuuDkxXQslAF09Jvnw4NSN6TnRvnQU39v3ku+jAfN b8CidcDP9cH7ipH6/UkckRR0i9kvrg2kVJou/uMMlse3sGMeQ0+G/hEZraxlBRhAF8Py mNK3EYl/1ZG4AvgN0fsk0YuRLpUSHfskChqYESSO1KgqcTBbPBd424O5cPDyXpeWX6F+ Xo9w== X-Gm-Message-State: AOJu0Yw/bOekSrbTtIAR7A6RGwvfQ++kk1QadZGgW8sivXDHqz6t4gT/ m5u0h5RPSWhFUFMWUBWf0MIuFvht43XaDeZotIWnFey0nMPkKhExbn9ymBFw/g== X-Google-Smtp-Source: AGHT+IHNc62m491wU+HcWk/9byQ0VfDf2/ltTaBrjP1Nag9akn0HzUFm/eSmTJ1AFlgyZ9X7wmhRpA== X-Received: by 2002:a05:600c:1d22:b0:414:76df:2d42 with SMTP id l34-20020a05600c1d2200b0041476df2d42mr414216wms.4.1711134434744; Fri, 22 Mar 2024 12:07:14 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id u12-20020a056000038c00b0033e456f6e7csm2773566wrf.1.2024.03.22.12.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:07:14 -0700 (PDT) Date: Fri, 22 Mar 2024 19:07:10 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 08/27] iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <8-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Hi Jason, On Mon, Mar 04, 2024 at 07:43:56PM -0400, Jason Gunthorpe wrote: > No reason to force callers to do two steps. Make arm_smmu_get_cd_ptr() > able to return an entry in all cases except OOM I believe the current code is more clear, as it is explicit about which path is expected to allocate. As there are many callers for arm_smmu_get_cd_ptr() directly and indirectly, and it read-modify-writes the cdtable, it would be a pain to debug not knowing which one could allocate, and this patch only abstracts one allocating call, so it is not much code less. For example, (again I don’t know much about SVA) I think there might be a race condition as follows: arm_smmu_attach_dev arm_smmu_domain_finalise() => set domain stage [....] arm_smmu_get_cd_ptr() => RMW master->cd_table arm_smmu_sva_set_dev_pasid __arm_smmu_sva_bind Check stage is valid [...] arm_smmu_write_ctx_desc arm_smmu_get_cd_ptr => RMW master->cd_table If this path is true though, I guess the in current code, we would need some barriers in arm_smmu_get_cd_ptr(), arm_smmu_get_cd_ptr() > Tested-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index e25dbb982feeee..2dd6cb17112e98 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -106,6 +106,7 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { > > static int arm_smmu_domain_finalise(struct arm_smmu_domain *smmu_domain, > struct arm_smmu_device *smmu); > +static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master); > > static void parse_driver_options(struct arm_smmu_device *smmu) > { > @@ -1231,6 +1232,11 @@ struct arm_smmu_cd *arm_smmu_get_cd_ptr(struct arm_smmu_master *master, > struct arm_smmu_device *smmu = master->smmu; > struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table; > > + if (!master->cd_table.cdtab) { > + if (arm_smmu_alloc_cd_tables(master)) > + return NULL; > + } > + > if (cd_table->s1fmt == STRTAB_STE_0_S1FMT_LINEAR) > return (struct arm_smmu_cd *)(cd_table->cdtab + > ssid * CTXDESC_CD_DWORDS); > @@ -2719,12 +2725,6 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > struct arm_smmu_cd target_cd; > struct arm_smmu_cd *cdptr; > > - if (!master->cd_table.cdtab) { > - ret = arm_smmu_alloc_cd_tables(master); > - if (ret) > - goto out_list_del; > - } > - > cdptr = arm_smmu_get_cd_ptr(master, IOMMU_NO_PASID); > if (!cdptr) { > ret = -ENOMEM; > -- > 2.43.2 > Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B848C47DD9 for ; Fri, 22 Mar 2024 19:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AKQMoXwN6P8HInR+tOWeZ1HyIzUmGjP0o7Z6uSKQ4/w=; b=GiDNCz2+qyIcIU +B6wdfpCZiz6amI7hjOY3C/MPyzkCbh6ASv8XhRf5MYg7TaEHNe8lXTUqz5JKbEKyN3fNw7cYyqjl YSr32LqZIqnhvDwWJ6/W7xJSBqGPDNMbkTPgPJSkCN2OY0/uDDVYMHPZ/UBwxyIU+zv0jJn6pWnbK u8xjvjC9BBD+4mR668XWeVmva6eKVbDqNo9krRYtZ/ZbKS65XPlwykm/6llF9A9G3rNfsHlbvBfTR +dCty84Tcuuvm7QddHVKjvQzxoLgaXqKL0KPE7vlLdi30VGboNDCUanw64D8vxAG/IuN57ZT6YA5d tsZo0bB2XaFncNbv4xtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnkEa-00000008S4b-3mPE; Fri, 22 Mar 2024 19:07:20 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnkEX-00000008S41-2ZbC for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 19:07:19 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-413f8c8192eso14905e9.0 for ; Fri, 22 Mar 2024 12:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711134435; x=1711739235; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LYZVGNnxMtJXmO/rMtm5YPA7SokYhXE01EEUSWS+tyg=; b=mobR5NabPJqhD3qX0bxPFkb/P57FCDkQSI8pf3FoUzZbwzCFMl9KdSC85Q3qP9SmGL 3jpEIrg/E8WL/l7L9KMb/p2Mfj1iCqHWhhQYBvwZKYRDM7iTxOHZq1PBnFWl+E1xNYPT A3N7UC3o+cex1oxPZZwsvqS2/EjMg+ENOMtN2HWaX3OZHnRdXRJ2hGfcPx79TqDNMPoV 84n5gt47z7+3hvSN6xIzdha1boLUijQvhRO2yvohrEPX1RX9dFR0GrsKbxqoXaF0cJbd Tu81rf18KG0y9f4TY5Apwhwt3F26RikMCeOH/Zc3Xt2xM790KP3PB+mvJh2LXpknVB5h VpYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134435; x=1711739235; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYZVGNnxMtJXmO/rMtm5YPA7SokYhXE01EEUSWS+tyg=; b=lvGj4GpuQKeFOjDgbvML/iQEUwvbnpW84pweWIcAFnfOqmj3y+PvHmvE5I/e5TbK5q 4/nFu928eQQqADUeFUNTuxJz+nH99J688+GSAcAyXRH19y/ayyKfI8OFOdjGk4xKNCKc vjFR7qV/61OY1E6D0akqfF715JnZCn0iZcIJUSOnaYqbz7iLarP1tLCX5WyV8YZ7vakf cpKzW1ms5E3CTCEnGnxl047H7oUvOUI2TcWrLs58sB83TNPt6scRK6KeVisrGVUmuP3f Yj4bJb05L804SpFrnwXgQHOYy7ygYP3G0xJ/PS107j8/q5/d1HwNw/1SSXnAKnxXTwDu BZkA== X-Forwarded-Encrypted: i=1; AJvYcCUtcSPqqVRI92tP9csHQ+ZWoI0MU09vgHkz7sLvda4mZKuXCrsi0h9A+xh6ga4sxODSSjWaP4CKe52vVtPEcMt3TDxiXxSkx5OzoIVLKxAIOAbXkdo= X-Gm-Message-State: AOJu0YzRonbyixjhCrs8pX+WHSqENvJPHsJ76GG65n4ieFHKPUD521SS 4Gn/vTwqd7FyUXunmQiUT0QIlEk1NR3UXeohhiki7V8OV4gbABtDS3MmJR6LDA== X-Google-Smtp-Source: AGHT+IHNc62m491wU+HcWk/9byQ0VfDf2/ltTaBrjP1Nag9akn0HzUFm/eSmTJ1AFlgyZ9X7wmhRpA== X-Received: by 2002:a05:600c:1d22:b0:414:76df:2d42 with SMTP id l34-20020a05600c1d2200b0041476df2d42mr414216wms.4.1711134434744; Fri, 22 Mar 2024 12:07:14 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id u12-20020a056000038c00b0033e456f6e7csm2773566wrf.1.2024.03.22.12.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:07:14 -0700 (PDT) Date: Fri, 22 Mar 2024 19:07:10 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 08/27] iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <8-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_120717_681855_8B1F916D X-CRM114-Status: GOOD ( 24.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwNzo0Mzo1NlBNIC0wNDAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gTm8gcmVhc29uIHRvIGZvcmNlIGNhbGxlcnMgdG8gZG8gdHdv IHN0ZXBzLiBNYWtlIGFybV9zbW11X2dldF9jZF9wdHIoKQo+IGFibGUgdG8gcmV0dXJuIGFuIGVu dHJ5IGluIGFsbCBjYXNlcyBleGNlcHQgT09NCgpJIGJlbGlldmUgdGhlIGN1cnJlbnQgY29kZSBp cyBtb3JlIGNsZWFyLCBhcyBpdCBpcyBleHBsaWNpdCBhYm91dCB3aGljaCBwYXRoCmlzIGV4cGVj dGVkIHRvIGFsbG9jYXRlLgoKQXMgdGhlcmUgYXJlIG1hbnkgY2FsbGVycyBmb3IgYXJtX3NtbXVf Z2V0X2NkX3B0cigpIGRpcmVjdGx5IGFuZCBpbmRpcmVjdGx5LAphbmQgaXQgcmVhZC1tb2RpZnkt d3JpdGVzIHRoZSBjZHRhYmxlLCBpdCB3b3VsZCBiZSBhIHBhaW4gdG8gZGVidWcgbm90Cmtub3dp bmcgd2hpY2ggb25lIGNvdWxkIGFsbG9jYXRlLCBhbmQgdGhpcyBwYXRjaCBvbmx5IGFic3RyYWN0 cyBvbmUKYWxsb2NhdGluZyBjYWxsLCBzbyBpdCBpcyBub3QgbXVjaCBjb2RlIGxlc3MuCgpGb3Ig ZXhhbXBsZSwgKGFnYWluIEkgZG9u4oCZdCBrbm93IG11Y2ggYWJvdXQgU1ZBKSBJIHRoaW5rIHRo ZXJlIG1pZ2h0IGJlIGEKcmFjZSBjb25kaXRpb24gYXMgZm9sbG93czoKYXJtX3NtbXVfYXR0YWNo X2RldgoJYXJtX3NtbXVfZG9tYWluX2ZpbmFsaXNlKCkgPT4gc2V0IGRvbWFpbiBzdGFnZQoJWy4u Li5dCglhcm1fc21tdV9nZXRfY2RfcHRyKCkgPT4gUk1XIG1hc3Rlci0+Y2RfdGFibGUKCmFybV9z bW11X3N2YV9zZXRfZGV2X3Bhc2lkCglfX2FybV9zbW11X3N2YV9iaW5kCgkJQ2hlY2sgc3RhZ2Ug aXMgdmFsaWQKCQlbLi4uXQoJCWFybV9zbW11X3dyaXRlX2N0eF9kZXNjCgkJCWFybV9zbW11X2dl dF9jZF9wdHIgPT4gUk1XIG1hc3Rlci0+Y2RfdGFibGUKCklmIHRoaXMgcGF0aCBpcyB0cnVlIHRo b3VnaCwgSSBndWVzcyB0aGUgaW4gY3VycmVudCBjb2RlLCB3ZSB3b3VsZCBuZWVkIHNvbWUKYmFy cmllcnMgaW4gYXJtX3NtbXVfZ2V0X2NkX3B0cigpLCBhcm1fc21tdV9nZXRfY2RfcHRyKCkKCj4g VGVzdGVkLWJ5OiBOaWNvbGluIENoZW4gPG5pY29saW5jQG52aWRpYS5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9p b21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyB8IDEyICsrKysrKy0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jIGIvZHJp dmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYwo+IGluZGV4IGUyNWRiYjk4 MmZlZWVlLi4yZGQ2Y2IxNzExMmU5OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS9h cm0tc21tdS12My9hcm0tc21tdS12My5jCj4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNt bXUtdjMvYXJtLXNtbXUtdjMuYwo+IEBAIC0xMDYsNiArMTA2LDcgQEAgc3RhdGljIHN0cnVjdCBh cm1fc21tdV9vcHRpb25fcHJvcCBhcm1fc21tdV9vcHRpb25zW10gPSB7Cj4gIAo+ICBzdGF0aWMg aW50IGFybV9zbW11X2RvbWFpbl9maW5hbGlzZShzdHJ1Y3QgYXJtX3NtbXVfZG9tYWluICpzbW11 X2RvbWFpbiwKPiAgCQkJCSAgICBzdHJ1Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11KTsKPiArc3Rh dGljIGludCBhcm1fc21tdV9hbGxvY19jZF90YWJsZXMoc3RydWN0IGFybV9zbW11X21hc3RlciAq bWFzdGVyKTsKPiAgCj4gIHN0YXRpYyB2b2lkIHBhcnNlX2RyaXZlcl9vcHRpb25zKHN0cnVjdCBh cm1fc21tdV9kZXZpY2UgKnNtbXUpCj4gIHsKPiBAQCAtMTIzMSw2ICsxMjMyLDExIEBAIHN0cnVj dCBhcm1fc21tdV9jZCAqYXJtX3NtbXVfZ2V0X2NkX3B0cihzdHJ1Y3QgYXJtX3NtbXVfbWFzdGVy ICptYXN0ZXIsCj4gIAlzdHJ1Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11ID0gbWFzdGVyLT5zbW11 Owo+ICAJc3RydWN0IGFybV9zbW11X2N0eF9kZXNjX2NmZyAqY2RfdGFibGUgPSAmbWFzdGVyLT5j ZF90YWJsZTsKPiAgCj4gKwlpZiAoIW1hc3Rlci0+Y2RfdGFibGUuY2R0YWIpIHsKPiArCQlpZiAo YXJtX3NtbXVfYWxsb2NfY2RfdGFibGVzKG1hc3RlcikpCj4gKwkJCXJldHVybiBOVUxMOwo+ICsJ fQo+ICsKPiAgCWlmIChjZF90YWJsZS0+czFmbXQgPT0gU1RSVEFCX1NURV8wX1MxRk1UX0xJTkVB UikKPiAgCQlyZXR1cm4gKHN0cnVjdCBhcm1fc21tdV9jZCAqKShjZF90YWJsZS0+Y2R0YWIgKwo+ ICAJCQkJCSAgICAgIHNzaWQgKiBDVFhERVNDX0NEX0RXT1JEUyk7Cj4gQEAgLTI3MTksMTIgKzI3 MjUsNiBAQCBzdGF0aWMgaW50IGFybV9zbW11X2F0dGFjaF9kZXYoc3RydWN0IGlvbW11X2RvbWFp biAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAkJc3RydWN0IGFybV9zbW11X2NkIHRh cmdldF9jZDsKPiAgCQlzdHJ1Y3QgYXJtX3NtbXVfY2QgKmNkcHRyOwo+ICAKPiAtCQlpZiAoIW1h c3Rlci0+Y2RfdGFibGUuY2R0YWIpIHsKPiAtCQkJcmV0ID0gYXJtX3NtbXVfYWxsb2NfY2RfdGFi bGVzKG1hc3Rlcik7Cj4gLQkJCWlmIChyZXQpCj4gLQkJCQlnb3RvIG91dF9saXN0X2RlbDsKPiAt CQl9Cj4gLQo+ICAJCWNkcHRyID0gYXJtX3NtbXVfZ2V0X2NkX3B0cihtYXN0ZXIsIElPTU1VX05P X1BBU0lEKTsKPiAgCQlpZiAoIWNkcHRyKSB7Cj4gIAkJCXJldCA9IC1FTk9NRU07Cj4gLS0gCj4g Mi40My4yCj4KVGhhbmtzLApNb3N0YWZhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==