From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA827827C for ; Fri, 22 Mar 2024 19:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711134918; cv=none; b=SsXUVGO+gqskMcua71K/Gb8Mq+GJMoSPty+CEfzyymAyQOg5CeSBXAq7uE1EwL9qg55ZPOpWiqxIx6+QoIS4uasXW9CgEW3dZ1nx1tYqYwAP71y2t7FjoQzAUgBEtQNgIXIP00xAZjz26FENWpDoNA7eCKYSuZTx8xCItS/UUh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711134918; c=relaxed/simple; bh=nquismUMtJbdmPgTSsZdryuDeqLxycmHVim+dtrmKe8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NPDtVRYN6554Dv53db6MfiFpQ+p7bQ3MgbjhHoRCkFnkVapqhOmU2w2MjJjcEslZrbeXjtDwCxZ+D82lOGJ4gsVdyuiMsPmtiRn4nJwTj1fkISmxnN2lIHm2A3GZ849O5bmSQdJcl+CIlRWI+Yuw5uvV7LBcbntNfhIhJ2YCDiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UjrEyny6; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UjrEyny6" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41428b378b9so14135e9.1 for ; Fri, 22 Mar 2024 12:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711134916; x=1711739716; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iBmwPWfj+P0UyE+jUv3x1rbO+OO3VlNB3fzoExTZCpI=; b=UjrEyny6wn7gvweu3B7Oph5ENnkuj26xBxj0RSfWYrJmMvU+jsDPsMn+4D+6JV3hVx /LqrkxuxEvquGnnjZTXnsvhtuM8Dcnmmax2VOPiuJuEHy0BoSFl+Xo9l/HekmHIZPJ5c bTAQIhSNkVKL2G4xqWLsZlBNfQD0gk/YFc8ylS9dF+AIDmlaf1UWVEMOlPMSe6A6Fm0Z wl+JY2hiu1KKrzURBpcBG+N5tsIO7yiXbYbWskYPTY7diFFIzrRskPG8vQzqpwWx+ob5 qw7QYz3QpctnTbKt0qyf0MWNR2qMGik+kP+JYdZEhOqqjwetLQKHcSXvWe4c2/QhKaeH 5ogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134916; x=1711739716; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iBmwPWfj+P0UyE+jUv3x1rbO+OO3VlNB3fzoExTZCpI=; b=fmMTL2h0mPEwVmspUI4oRgM4A8U7VuNfhVxFLjYCLqCaL9qyKgcrlWvcatGy5Vcx6+ 7JA18+wKr0a9MZT/GNvdqNp75HTZLlOJJjA9GjRmOgg0au32u4t5IRHwIMNEGUFfvvWt 9KXEUFFnZOT0/4AP/bi6rSyjOWrY3pS2rPAhfx/wBu7gtg/W+5E5AjNQ01QnAfy4wJAR SwNB+Lcfr1alU2HmCVgJgDLHtFoYk4swqy9JW/g81jtR6exHCqHEpjdhjdSONNs7Mhp4 vaUSg7xr5uxwAISSWbXVjHSbEkR6f8zhzmDlfKOmEunozw7vNtKNEJLV3gqcchudWsDp zG2w== X-Gm-Message-State: AOJu0YwM+0DRru5+PylPbr1Hu1Wg87+fHXAYmh7XrPa33kOR+XNTboYn dqL0qoaNjLTkhibaQmTG6vAfF+Sd4/LHiQxC4Ju8itg4ajgN7MrDfU2POCFOhQ== X-Google-Smtp-Source: AGHT+IFCfF66X3KOP2ZhTbkhD7eO1ULUJHDki2BPmbB/rZoGnUCW/kWVXFNirPzcY13hMF06gu5a/Q== X-Received: by 2002:a05:600c:3b94:b0:413:f266:c654 with SMTP id n20-20020a05600c3b9400b00413f266c654mr520651wms.1.1711134915484; Fri, 22 Mar 2024 12:15:15 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id v9-20020a5d43c9000000b0033ec9007bacsm2679247wrr.20.2024.03.22.12.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:15:14 -0700 (PDT) Date: Fri, 22 Mar 2024 19:15:11 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 09/27] iommu/arm-smmu-v3: Allocate the CD table entry in advance Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <9-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> Hi Jason, On Mon, Mar 04, 2024 at 07:43:57PM -0400, Jason Gunthorpe wrote: > Avoid arm_smmu_attach_dev() having to undo the changes to the > smmu_domain->devices list, acquire the cdptr earlier so we don't need to > handle that error. > > Now there is a clear break in arm_smmu_attach_dev() where all the > prep-work has been done non-disruptively and we commit to making the HW > change, which cannot fail. > > This completes transforming arm_smmu_attach_dev() so that it does not > disturb the HW if it fails. > > Tested-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 24 +++++++-------------- > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 2dd6cb17112e98..39081d828a2132 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2676,6 +2676,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > struct arm_smmu_device *smmu; > struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); > struct arm_smmu_master *master; > + struct arm_smmu_cd *cdptr; > > if (!fwspec) > return -ENOENT; > @@ -2704,6 +2705,12 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > if (ret) > return ret; > > + if (smmu_domain->stage == ARM_SMMU_DOMAIN_S1) { > + cdptr = arm_smmu_get_cd_ptr(master, IOMMU_NO_PASID); > + if (!cdptr) > + return -ENOMEM; > + } > + > /* > * Prevent arm_smmu_share_asid() from trying to change the ASID > * of either the old or new domain while we are working on it. > @@ -2723,13 +2730,6 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > switch (smmu_domain->stage) { > case ARM_SMMU_DOMAIN_S1: { > struct arm_smmu_cd target_cd; > - struct arm_smmu_cd *cdptr; > - > - cdptr = arm_smmu_get_cd_ptr(master, IOMMU_NO_PASID); > - if (!cdptr) { > - ret = -ENOMEM; > - goto out_list_del; > - } > > arm_smmu_make_s1_cd(&target_cd, master, smmu_domain); > arm_smmu_write_cd_entry(master, IOMMU_NO_PASID, cdptr, > @@ -2746,16 +2746,8 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > } > > arm_smmu_enable_ats(master, smmu_domain); > - goto out_unlock; > - > -out_list_del: > - spin_lock_irqsave(&smmu_domain->devices_lock, flags); > - list_del_init(&master->domain_head); > - spin_unlock_irqrestore(&smmu_domain->devices_lock, flags); > - > -out_unlock: > mutex_unlock(&arm_smmu_asid_lock); > - return ret; > + return 0; > } > > static int arm_smmu_attach_dev_ste(struct device *dev, > -- > 2.43.2 > I believe this is fine, I couldn’t break it. With the comment on the previous patch, where we explicitly allocate the CD here and not inside arm_smmu_get_cd_ptr(). Reviewed-by: Mostafa Saleh Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E956CC54E71 for ; Fri, 22 Mar 2024 19:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qwKM5FgffkeODkIf9NFsln6AtkMJN/swK2fOORs9iUA=; b=s95trevWIaOhCP hPdrrDZLPKD+O2J8mfUkHcjTf1uBLf2zqiXRjC3+v19Uoli8ZiupG+aSo/CtWk3LbIbe0Jp1fp3Ko lM5DV55Hx31Nyf5z3AYs/gWM5bNO5331DWGEOa/CvTOL7dUJ3FbG0G5fVzC+gvAH9KPqHSoBorwjA aJlKx2AgpJBLxr/f/RLthRbenV/VFC+fjMohP0bn6axp4pCzwZbbU+hC31fYmLeS5VIrsgSNSNsVk qmREHL0QcTOIj5Jp8GwNH+cVuXroCJ262JTOFdq63h+PxauvX3WonolJN/siTrVgHymA7tNA0qoVN LTBeqAGfiZ3LVM6YPxoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnkMK-00000008TQ4-0EKN; Fri, 22 Mar 2024 19:15:20 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnkMH-00000008TPF-2d28 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 19:15:19 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-41428b378b9so14155e9.1 for ; Fri, 22 Mar 2024 12:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711134916; x=1711739716; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iBmwPWfj+P0UyE+jUv3x1rbO+OO3VlNB3fzoExTZCpI=; b=kkuF+SKikdQgObPLKB4KQkCmlJ+LXzdpdT2TNeKYlBmvkmzcIVohE4DW7mlU3cTJSM Otx12CCb0mOs6N3w2/2f4x6+z/XEAdeUwWuV9M6d7JqXcSQME19Kwp44Chby9hypKHjc GFFqj9PfRejnq3h3WwOvLynScLcY6juHLeX512JEUT4keRdCf9pLV4zEHYxH2XdLVZ6V aZw9GXzi7sYD+MMdWiA7qB7/DdVtwO/ynj9tLdPZ+u0PpTDcLcas/kJ75Spr//r7EZwC Ba5e3cAUJtjxRVDPYrBheM+RGb40GGmRL3uizbTsanQwjFOWvFQ1iQdjJDAj5txGI5bE RE+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134916; x=1711739716; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iBmwPWfj+P0UyE+jUv3x1rbO+OO3VlNB3fzoExTZCpI=; b=MtyWMzoiGcHp9dYkLVNG3MKm7Cgj6Qt4o44p/wZw40Tp7P2jkoMUqJsBGQtR38RQkm N3ccvz0op1IYEXhDDZurcj2Cf549uLuj1BMgYEdf+H3MKjRCHbPyNCJLiMcNzcDI3DAN 4UTFi+zIYM3dC5ZZOxd5L5JCcJiY+WePZviCu2iR6+SSke8COXfoSjMgvtb4Nc+q5ocT Sn1XQG4VVQmXunO/W7hbw4WsoUYDwq2X+iTcOB01GyXS9Ia7xLOLT+YM6FGn9UVhohbp 6GEJ1bZqgSky0Ir2ES0g4O7/iWz5HK/1HxvMoxf2N32iqLk6m+8gWTeS1M3NCilu6MTl nr9g== X-Forwarded-Encrypted: i=1; AJvYcCXSWJ4YsMjF1bUhMJ1IT3e9fHjTZWPKXQ2roc1+rEvgEsZuU6uy5rbRoLnZGWo2XgPunQz68zDhoc4yYvgdH+fvksnKh4MUHQAfQOaUuyimRm8acXU= X-Gm-Message-State: AOJu0Yz++dqRddk6o6uYZpIVHxnxuGuCi5hQzORutJ6g54V3k+f8kCAg 0h78GqAOeOs4q/RbwWuvHp7ytQwESUWZLexAEbQE9TNYjKmKRuFZeBQWMh81qw== X-Google-Smtp-Source: AGHT+IFCfF66X3KOP2ZhTbkhD7eO1ULUJHDki2BPmbB/rZoGnUCW/kWVXFNirPzcY13hMF06gu5a/Q== X-Received: by 2002:a05:600c:3b94:b0:413:f266:c654 with SMTP id n20-20020a05600c3b9400b00413f266c654mr520651wms.1.1711134915484; Fri, 22 Mar 2024 12:15:15 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id v9-20020a5d43c9000000b0033ec9007bacsm2679247wrr.20.2024.03.22.12.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:15:14 -0700 (PDT) Date: Fri, 22 Mar 2024 19:15:11 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 09/27] iommu/arm-smmu-v3: Allocate the CD table entry in advance Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <9-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_121517_770294_6500A17F X-CRM114-Status: GOOD ( 28.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBNb24sIE1hciAwNCwgMjAyNCBhdCAwNzo0Mzo1N1BNIC0wNDAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gQXZvaWQgYXJtX3NtbXVfYXR0YWNoX2RldigpIGhhdmluZyB0 byB1bmRvIHRoZSBjaGFuZ2VzIHRvIHRoZQo+IHNtbXVfZG9tYWluLT5kZXZpY2VzIGxpc3QsIGFj cXVpcmUgdGhlIGNkcHRyIGVhcmxpZXIgc28gd2UgZG9uJ3QgbmVlZCB0bwo+IGhhbmRsZSB0aGF0 IGVycm9yLgo+IAo+IE5vdyB0aGVyZSBpcyBhIGNsZWFyIGJyZWFrIGluIGFybV9zbW11X2F0dGFj aF9kZXYoKSB3aGVyZSBhbGwgdGhlCj4gcHJlcC13b3JrIGhhcyBiZWVuIGRvbmUgbm9uLWRpc3J1 cHRpdmVseSBhbmQgd2UgY29tbWl0IHRvIG1ha2luZyB0aGUgSFcKPiBjaGFuZ2UsIHdoaWNoIGNh bm5vdCBmYWlsLgo+IAo+IFRoaXMgY29tcGxldGVzIHRyYW5zZm9ybWluZyBhcm1fc21tdV9hdHRh Y2hfZGV2KCkgc28gdGhhdCBpdCBkb2VzIG5vdAo+IGRpc3R1cmIgdGhlIEhXIGlmIGl0IGZhaWxz Lgo+IAo+IFRlc3RlZC1ieTogTmljb2xpbiBDaGVuIDxuaWNvbGluY0BudmlkaWEuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8amdnQG52aWRpYS5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMgfCAyNCArKysrKysrLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2Fy bS1zbW11LXYzLmMgYi9kcml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5j Cj4gaW5kZXggMmRkNmNiMTcxMTJlOTguLjM5MDgxZDgyOGEyMTMyIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPiArKysgYi9kcml2ZXJz L2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4gQEAgLTI2NzYsNiArMjY3Niw3 IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfYXR0YWNoX2RldihzdHJ1Y3QgaW9tbXVfZG9tYWluICpk b21haW4sIHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCXN0cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNt bXU7Cj4gIAlzdHJ1Y3QgYXJtX3NtbXVfZG9tYWluICpzbW11X2RvbWFpbiA9IHRvX3NtbXVfZG9t YWluKGRvbWFpbik7Cj4gIAlzdHJ1Y3QgYXJtX3NtbXVfbWFzdGVyICptYXN0ZXI7Cj4gKwlzdHJ1 Y3QgYXJtX3NtbXVfY2QgKmNkcHRyOwo+ICAKPiAgCWlmICghZndzcGVjKQo+ICAJCXJldHVybiAt RU5PRU5UOwo+IEBAIC0yNzA0LDYgKzI3MDUsMTIgQEAgc3RhdGljIGludCBhcm1fc21tdV9hdHRh Y2hfZGV2KHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwgc3RydWN0IGRldmljZSAqZGV2KQo+ ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiArCWlmIChzbW11X2RvbWFpbi0+c3Rh Z2UgPT0gQVJNX1NNTVVfRE9NQUlOX1MxKSB7Cj4gKwkJY2RwdHIgPSBhcm1fc21tdV9nZXRfY2Rf cHRyKG1hc3RlciwgSU9NTVVfTk9fUEFTSUQpOwo+ICsJCWlmICghY2RwdHIpCj4gKwkJCXJldHVy biAtRU5PTUVNOwo+ICsJfQo+ICsKPiAgCS8qCj4gIAkgKiBQcmV2ZW50IGFybV9zbW11X3NoYXJl X2FzaWQoKSBmcm9tIHRyeWluZyB0byBjaGFuZ2UgdGhlIEFTSUQKPiAgCSAqIG9mIGVpdGhlciB0 aGUgb2xkIG9yIG5ldyBkb21haW4gd2hpbGUgd2UgYXJlIHdvcmtpbmcgb24gaXQuCj4gQEAgLTI3 MjMsMTMgKzI3MzAsNiBAQCBzdGF0aWMgaW50IGFybV9zbW11X2F0dGFjaF9kZXYoc3RydWN0IGlv bW11X2RvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlzd2l0Y2ggKHNtbXVf ZG9tYWluLT5zdGFnZSkgewo+ICAJY2FzZSBBUk1fU01NVV9ET01BSU5fUzE6IHsKPiAgCQlzdHJ1 Y3QgYXJtX3NtbXVfY2QgdGFyZ2V0X2NkOwo+IC0JCXN0cnVjdCBhcm1fc21tdV9jZCAqY2RwdHI7 Cj4gLQo+IC0JCWNkcHRyID0gYXJtX3NtbXVfZ2V0X2NkX3B0cihtYXN0ZXIsIElPTU1VX05PX1BB U0lEKTsKPiAtCQlpZiAoIWNkcHRyKSB7Cj4gLQkJCXJldCA9IC1FTk9NRU07Cj4gLQkJCWdvdG8g b3V0X2xpc3RfZGVsOwo+IC0JCX0KPiAgCj4gIAkJYXJtX3NtbXVfbWFrZV9zMV9jZCgmdGFyZ2V0 X2NkLCBtYXN0ZXIsIHNtbXVfZG9tYWluKTsKPiAgCQlhcm1fc21tdV93cml0ZV9jZF9lbnRyeSht YXN0ZXIsIElPTU1VX05PX1BBU0lELCBjZHB0ciwKPiBAQCAtMjc0NiwxNiArMjc0Niw4IEBAIHN0 YXRpYyBpbnQgYXJtX3NtbXVfYXR0YWNoX2RldihzdHJ1Y3QgaW9tbXVfZG9tYWluICpkb21haW4s IHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCX0KPiAgCj4gIAlhcm1fc21tdV9lbmFibGVfYXRzKG1h c3Rlciwgc21tdV9kb21haW4pOwo+IC0JZ290byBvdXRfdW5sb2NrOwo+IC0KPiAtb3V0X2xpc3Rf ZGVsOgo+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJnNtbXVfZG9tYWluLT5kZXZpY2VzX2xvY2ssIGZs YWdzKTsKPiAtCWxpc3RfZGVsX2luaXQoJm1hc3Rlci0+ZG9tYWluX2hlYWQpOwo+IC0Jc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmc21tdV9kb21haW4tPmRldmljZXNfbG9jaywgZmxhZ3MpOwo+IC0K PiAtb3V0X3VubG9jazoKPiAgCW11dGV4X3VubG9jaygmYXJtX3NtbXVfYXNpZF9sb2NrKTsKPiAt CXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBhcm1fc21t dV9hdHRhY2hfZGV2X3N0ZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gLS0gCj4gMi40My4yCj4KSSBi ZWxpZXZlIHRoaXMgaXMgZmluZSwgSSBjb3VsZG7igJl0IGJyZWFrIGl0LiBXaXRoIHRoZSBjb21t ZW50IG9uIHRoZSBwcmV2aW91cwpwYXRjaCwgd2hlcmUgd2UgZXhwbGljaXRseSBhbGxvY2F0ZSB0 aGUgQ0QgaGVyZSBhbmQgbm90IGluc2lkZQphcm1fc21tdV9nZXRfY2RfcHRyKCkuCgpSZXZpZXdl ZC1ieTogTW9zdGFmYSBTYWxlaCA8c21vc3RhZmFAZ29vZ2xlLmNvbT4KCgpUaGFua3MsCk1vc3Rh ZmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK