From: Alison Schofield <alison.schofield@intel.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: marvin24@gmx.de, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: nvec: Fix documentation typo in static irqreturn_t nvec_interrupt()
Date: Fri, 22 Mar 2024 21:10:10 -0700 [thread overview]
Message-ID: <Zf5WIiSAXKAIlBC1@aschofie-mobl2> (raw)
In-Reply-To: <20240317120947.2923-1-dorine.a.tipo@gmail.com>
On Sun, Mar 17, 2024 at 12:09:47PM +0000, Dorine Tipo wrote:
> Correct the spelling of initialisation with was misspelled in the
> documentation
Thanks for the patch Dorine,
Please tidy up both commit msg (so it doesn't line wrap) and the
commit log. (s/with/which and add a 'hard stop' ie. a period at
the end of your sentence.) If the issue was found using a tool,
say that. "Issue found using checkpatch."
There's a section in the First Patch Tutorial about following the
style of the subsystem or file. Please check it out.
--Alison
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 282a664c9176..b4485b10beb8 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -712,7 +712,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> * TODO: replace the udelay with a read back after each writel above
> * in order to work around a hardware issue, see i2c-tegra.c
> *
> - * Unfortunately, this change causes an intialisation issue with the
> + * Unfortunately, this change causes an initialisation issue with the
> * touchpad, which needs to be fixed first.
> */
> udelay(100);
> --
> 2.25.1
>
>
prev parent reply other threads:[~2024-03-23 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 12:09 [PATCH] staging: nvec: Fix documentation typo in static irqreturn_t nvec_interrupt() Dorine Tipo
2024-03-23 4:10 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf5WIiSAXKAIlBC1@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=marvin24@gmx.de \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.