From: "Valentin Vidić" <vvidic@valentin-vidic.from.hr>
To: Alexander Aring <aahringo@redhat.com>
Cc: teigland@redhat.com, gfs2@lists.linux.dev,
stable@vger.kernel.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, heming.zhao@suse.com
Subject: Re: [PATCH 2/2] dlm: fix off-by-one waiters refcount handling
Date: Tue, 12 Mar 2024 21:25:27 +0100 [thread overview]
Message-ID: <ZfC6NxRpmAFSNg79@valentin-vidic.from.hr> (raw)
In-Reply-To: <20240312170508.3590306-2-aahringo@redhat.com>
On Tue, Mar 12, 2024 at 01:05:08PM -0400, Alexander Aring wrote:
> There was a wrong conversion to atomic counters in commit 75a7d60134ce
> ("fs: dlm: handle lkb wait count as atomic_t"), when
> atomic_dec_and_test() returns true it will decrement at first and
> then return true if it hits zero. This means we will mis a unhold_lkb()
> for the last iteration. This patch fixes this issue and if the last
> reference is taken we will remove the lkb from the waiters list as this
> is how it's supposed to work.
>
> Cc: stable@vger.kernel.org
> Fixes: 75a7d60134ce ("fs: dlm: handle lkb wait count as atomic_t")
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
Tested-by: Valentin Vidić <vvidic@valentin-vidic.from.hr>
--
Valentin
prev parent reply other threads:[~2024-03-12 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 17:05 [PATCH 1/2] dlm: fix user space lkb refcounting Alexander Aring
2024-03-12 17:05 ` [PATCH 2/2] dlm: fix off-by-one waiters refcount handling Alexander Aring
2024-03-12 20:25 ` Valentin Vidić [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfC6NxRpmAFSNg79@valentin-vidic.from.hr \
--to=vvidic@valentin-vidic.from.hr \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=heming.zhao@suse.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.