From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
mazziesaccount@gmail.com, ak@it-klinger.de,
petre.rodan@subdimension.ro, linus.walleij@linaro.org,
phil@raspberrypi.com, 579lpy@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] iio: pressure: Simplify and make more clear temperature readings
Date: Wed, 13 Mar 2024 21:04:46 +0200 [thread overview]
Message-ID: <ZfH4znQ2FK6j5LWK@smile.fi.intel.com> (raw)
In-Reply-To: <20240313174007.1934983-5-vassilisamir@gmail.com>
On Wed, Mar 13, 2024 at 06:40:05PM +0100, Vasileios Amoiridis wrote:
> The read_press/read_humid functions need the updated t_fine value
read_press()/read_humid()
> in order to calculate the current pressure/humidity. Temperature
> reads should be removed from the read_press/read_humid functions
read_press()/read_humid()
> and should be placed in the oneshot captures before the pressure
> and humidity reads. This makes the code more intuitive.
...
> + if (strcmp(indio_dev->name, "bmp580"))
> + data->chip_info->read_temp(data);
> +
> + if (strcmp(indio_dev->name, "bmp580"))
> + data->chip_info->read_temp(data);
Yeah, not a fan of the strcmp().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-13 19:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 17:40 [PATCH v2 0/6] Series to add triggered buffer support to BMP280 driver Vasileios Amoiridis
2024-03-13 17:40 ` [PATCH v2 1/6] iio: pressure: BMP280 core driver headers sorting Vasileios Amoiridis
2024-03-13 17:40 ` [PATCH v2 2/6] iio: pressure: Simplify read_* functions Vasileios Amoiridis
2024-03-13 19:01 ` Andy Shevchenko
2024-03-13 19:22 ` Vasileios Amoiridis
2024-03-13 19:28 ` Andy Shevchenko
2024-03-14 14:32 ` Jonathan Cameron
2024-03-14 19:52 ` Vasileios Amoiridis
2024-03-14 14:38 ` Jonathan Cameron
2024-03-13 17:40 ` [PATCH v3 3/6] iio: pressure: add SCALE and RAW values for channels Vasileios Amoiridis
2024-03-13 19:03 ` Andy Shevchenko
2024-03-13 19:51 ` Vasileios Amoiridis
2024-03-13 20:04 ` Andy Shevchenko
2024-03-13 21:28 ` Vasileios Amoiridis
2024-03-14 10:57 ` vamoirid
2024-03-14 14:46 ` Jonathan Cameron
2024-03-14 20:06 ` Vasileios Amoiridis
2024-03-15 13:11 ` Vasileios Amoiridis
2024-03-16 13:51 ` Jonathan Cameron
2024-03-14 14:48 ` Jonathan Cameron
2024-03-13 17:40 ` [PATCH v2 4/6] iio: pressure: Simplify and make more clear temperature readings Vasileios Amoiridis
2024-03-13 19:04 ` Andy Shevchenko [this message]
2024-03-14 14:51 ` Jonathan Cameron
2024-03-14 15:09 ` Jonathan Cameron
2024-03-14 20:17 ` Vasileios Amoiridis
2024-03-14 23:22 ` Angel Iglesias
2024-03-15 9:05 ` Vasileios Amoiridis
2024-03-15 13:28 ` Angel Iglesias
2024-03-16 14:00 ` Jonathan Cameron
2024-03-13 17:40 ` [PATCH v2 5/6] iio: pressure: Add timestamp and scan_masks for BMP280 driver Vasileios Amoiridis
2024-03-13 18:54 ` Andy Shevchenko
2024-03-13 19:55 ` Vasileios Amoiridis
2024-03-13 17:40 ` [PATCH v2 6/6] iio: pressure: Add triggered buffer support " Vasileios Amoiridis
2024-03-13 18:58 ` Andy Shevchenko
2024-03-13 20:00 ` Vasileios Amoiridis
2024-03-14 15:25 ` Jonathan Cameron
2024-03-14 20:14 ` Vasileios Amoiridis
2024-03-16 14:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfH4znQ2FK6j5LWK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=579lpy@gmail.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
--cc=phil@raspberrypi.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.