Re: [PATCH nft] tests/py: remove flow table json test cases

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Mar 13, 2024 at 03:13:22PM +0100, Florian Westphal wrote:
> ip(6)/flowtable.t tests fail both for normal and json mode.
> 
> WARNING: line 3: 'add rule ip test-ip input meter xyz size 8192 { ip saddr timeout 30s counter}': 'ip test-ip input' mismatches '[ payload load 4b @ network header + 12 => reg 1 ]'
> ip/lowtable.t.payload.got: WARNING: line 2: Wrote payload for rule meter xyz size 8192 { ip saddr timeout 30s counter}
> ip/flowtable.t: WARNING: line 5: 'add rule ip test-ip input meter xyz size 8192 { ip saddr timeout 30s counter}': 'meter xyz size 8192 { ip saddr timeout 30s counter}' mismatches 'update @xyz { ip saddr timeout 30s counter}'
> WARNING: line 3: 'add rule ip6 test-ip6 input meter acct_out size 4096 { meta iif . ip6 saddr timeout 600s counter }': 'ip6 test-ip6 input' mismatches '[ meta load iif => reg 1 ]'
> ip6/flowtable.t.payload.got: WARNING: line 2: Wrote payload for rule meter acct_out size 4096 { meta iif . ip6 saddr timeout 600s counter }
> ip6/flowtable.t: WARNING: line 5: 'add rule ip6 test-ip6 input meter acct_out size 4096 { meta iif . ip6 saddr timeout 600s counter }': 'meter acct_out size 4096 { iif . ip6 saddr timeout 10m counter }' mismatches 'update @acct_out { iif . ip6 saddr timeout 10m counter}'
> ip6/flowtable.t: ERROR: line 6: add rule ip6 test-ip6 input meter acct_out size 12345 { ip6 saddr . meta iif timeout 600s counter }: This rule should not have failed.
> ip6/flowtable.t: 2 unit tests, 2 error, 1 warning
> 
> Fix at least the non-json mode, I do not know how to fix up -j
> or wheter the failure is actually correct.

For the record:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240313162317.192314-1-pablo@netfilter.org/

I can change patch subject if you like instead to:

  tests: py: move meter tests to tests/shell

this transformation is hard to deal with from tests/py.