From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2394C6BB56; Thu, 14 Mar 2024 08:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710405758; cv=none; b=n0zpEDXaNj5pFFlwTUdI3j4G07ZdkqxaBpSoSPxTaPyP+X0XCtWzyFTT3JUVEoMay3I3gifHVGxIcdXIX1YYPNwUABWkc6dr21S4FdWaOA+wOQ5cf99qoula1jpb3wbw9b5oEiHdV3Oa5uDkzQKL5bKCyI5e6Fr8o4KIEkNcYTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710405758; c=relaxed/simple; bh=V09Ma465F/F2Vxs9nvGPBppS3VEn8cxbnQDIcVk3LPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S6gLVdBGy8+zhnMHffWkmWGrbXGyqtPifp4fhzuqtz9AePcRwssYJfHwStEyJMkcbFv8qSGsA0Z5oothNA3Zt2uDnSX/1SvsXJO6kK7TS1XUEPWL2NNRZ53+iLNVH2d3XauKB8EbA2SZVuP3RPM2IPNza0q7vJgk3dAdzMf9TlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=XLg29xJo; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="XLg29xJo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cgbDTfEgEvEt8XT1jVPZh5fA/uBgksTawcns0Z7+nws=; b=XLg29xJoElFHyNco9ZF1wU+aYh pMsseZBR7m6lcEw86f/wn96fjQKOzQEySBdC2bs1Z5WnqY6lQeG4IlAF0qlyr/wULCuN8jRlOxPTz gTIpEq4B8daoJHVxBdMSNazW7JZmjZgpHywSeNfIwRJ6V6dHFsACg7Y3oQIqpuU21BdxxTmFca7i2 oFW1lL4P8yMo0Aou7f2F9q8bAgWI5dZ8TFIugRtZJobG3NWCu04ATBpmmm9L8fUc6mnuaYLVxlztK 3eWKFTCYA0K9ms40Vp1BoAXMpM+SiTed3ycSZ4p4x2dX1CD2XZ5F4QwwnYbTLTX/LclHGE6kQBpHh bpIRp1qQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53884) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rkgfV-0000FG-1i; Thu, 14 Mar 2024 08:42:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rkgfT-0005Jx-As; Thu, 14 Mar 2024 08:42:27 +0000 Date: Thu, 14 Mar 2024 08:42:27 +0000 From: "Russell King (Oracle)" To: Duanqiang Wen Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH clk v2] clk: clkdev: add error messages for name exceeding maximum length Message-ID: References: <20240314023909.871105-1-duanqiangwen@net-swift.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240314023909.871105-1-duanqiangwen@net-swift.com> Sender: Russell King (Oracle) On Thu, Mar 14, 2024 at 10:39:09AM +0800, Duanqiang Wen wrote: > if one device register clkdev with dev_id or con_id > greater than maximum length, clkdev_create functions > will not return err, but clk_find functions will not > match the device, it's difficult to identify issues > for developers.So add error messages for dev_id greater > than 20 characters and con_id greater than 16 characters. > > eg. clkdev_create(clk, NULL, "i2c_designware.16796") > it will create clk_lookup with dev_id "i2c_designware.1679", > because clk_name exceeds dev_id maximum, but clkdev_create not > return err. when driver call clk_find functions, use "i2c_desig > nware.16796" to find clk, it will return failed,but I don't know > where the problem is. It took a long time to find the problem. > > Signed-off-by: Duanqiang Wen This looks like v1 just reposted with a v2 tag. I don't see any obvious changes in the patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBA6BC5475B for ; Thu, 14 Mar 2024 08:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g0VvOTINkSdOKh+9V8TlJnu6uOofcOaRZoGKlKeZcsA=; b=XZI0hHk13L80vg 6TatfRxJp4L9TtbJI9Kl1aS0L+x/LMdfI/lInVoK51H8xr9n+K+AppqRRU3ug9pypPhFbRN46Uj0k NC/fqUx14jQkuC5vaHX3EQbXmF9fm0Hfh3H44MW6j/1IqXG4yZuBPjgLfe8NYOBYoxa70dHePbIzS OP/kqV+1Rg7IvP4OZmlyxWOzW0NQR85gtzCZrwW1hHNdosu0KPkLB6YvvgomfYJ0S6nX9z0tJ6/qm 368GuC8fJlDYymXwfTSGF4PV06C1DUA9guou558xTsl7XgCpZ/A6Yy4py6Ecyb+2DWl0S78j6J78e XgEZdf6JAH25m6HQT7lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkgfi-0000000DZqI-2AwP; Thu, 14 Mar 2024 08:42:42 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkgff-0000000DZpT-3ryc for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2024 08:42:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cgbDTfEgEvEt8XT1jVPZh5fA/uBgksTawcns0Z7+nws=; b=XLg29xJoElFHyNco9ZF1wU+aYh pMsseZBR7m6lcEw86f/wn96fjQKOzQEySBdC2bs1Z5WnqY6lQeG4IlAF0qlyr/wULCuN8jRlOxPTz gTIpEq4B8daoJHVxBdMSNazW7JZmjZgpHywSeNfIwRJ6V6dHFsACg7Y3oQIqpuU21BdxxTmFca7i2 oFW1lL4P8yMo0Aou7f2F9q8bAgWI5dZ8TFIugRtZJobG3NWCu04ATBpmmm9L8fUc6mnuaYLVxlztK 3eWKFTCYA0K9ms40Vp1BoAXMpM+SiTed3ycSZ4p4x2dX1CD2XZ5F4QwwnYbTLTX/LclHGE6kQBpHh bpIRp1qQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53884) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rkgfV-0000FG-1i; Thu, 14 Mar 2024 08:42:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rkgfT-0005Jx-As; Thu, 14 Mar 2024 08:42:27 +0000 Date: Thu, 14 Mar 2024 08:42:27 +0000 From: "Russell King (Oracle)" To: Duanqiang Wen Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH clk v2] clk: clkdev: add error messages for name exceeding maximum length Message-ID: References: <20240314023909.871105-1-duanqiangwen@net-swift.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240314023909.871105-1-duanqiangwen@net-swift.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240314_014239_980549_A836C50A X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 14, 2024 at 10:39:09AM +0800, Duanqiang Wen wrote: > if one device register clkdev with dev_id or con_id > greater than maximum length, clkdev_create functions > will not return err, but clk_find functions will not > match the device, it's difficult to identify issues > for developers.So add error messages for dev_id greater > than 20 characters and con_id greater than 16 characters. > > eg. clkdev_create(clk, NULL, "i2c_designware.16796") > it will create clk_lookup with dev_id "i2c_designware.1679", > because clk_name exceeds dev_id maximum, but clkdev_create not > return err. when driver call clk_find functions, use "i2c_desig > nware.16796" to find clk, it will return failed,but I don't know > where the problem is. It took a long time to find the problem. > > Signed-off-by: Duanqiang Wen This looks like v1 just reposted with a v2 tag. I don't see any obvious changes in the patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel