From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD068C54E60 for ; Thu, 14 Mar 2024 13:00:21 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YipXpQqB; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YipXpQqB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TwSCm3GPtz3dVr for ; Fri, 15 Mar 2024 00:00:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YipXpQqB; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YipXpQqB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TwSBv2XZjz303d for ; Thu, 14 Mar 2024 23:59:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710421170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=YipXpQqBSD1mqnNCmBGE6r4keAW+xNh3XH4UqpTxJkG7jULnmyiizl5FSp45QQLzogBI55 1oVM1WvXvARPW4ONc1mxPiKpqfz8Ux9krqKP0ji8CD6zZANsnOtJlvX2k4iFQa+WHgel5t 4bmVLSmCpw2XqyJIfl9TVWPwmsen27A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710421170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=YipXpQqBSD1mqnNCmBGE6r4keAW+xNh3XH4UqpTxJkG7jULnmyiizl5FSp45QQLzogBI55 1oVM1WvXvARPW4ONc1mxPiKpqfz8Ux9krqKP0ji8CD6zZANsnOtJlvX2k4iFQa+WHgel5t 4bmVLSmCpw2XqyJIfl9TVWPwmsen27A= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-UbHzCFYCPXaIa5ImyrdY8Q-1; Thu, 14 Mar 2024 08:59:27 -0400 X-MC-Unique: UbHzCFYCPXaIa5ImyrdY8Q-1 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-4d424421d4aso121576e0c.0 for ; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710421167; x=1711025967; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=YirFoQcPrSIW48w+RDecs4Ay153hOA60KAo6WGeB1eBUFztvQ6oOrSUbFFIZzYr8iu rgJh2/Lf3YV8ET+n2PdDco9xUg/TUIXHOWfyQUWSzmS4xh3QRvNT/CDQ04fHKaKvNBPm c2/l88UNc97FBEyDbRiSityRazX4MMXCcsA+P9WZvPpumYSwcqVzLpAmiA2+5KLYtLix FIZf7a+opP9FOCVBuWlN3YUIJqdY/DAJnBW3DpmwL+FcVN3HsseOasSM6+ojQ9+6eleT gLZVp36fxQRTWFo41RQSykFEuw+AAmp8mPguDfA2AEIP9X1np3kx2lIYQVYLqzkKpbUS G8xw== X-Forwarded-Encrypted: i=1; AJvYcCWUkjxXj3PuDwh3sFrTLgtAHhc2BIdpFv0ONz7YRG2AN486cEA0dX33RxKCIJhR1ZFbCbMGAgI971YxdhDu8nT982fPbqTGZ1AMUBmAYg== X-Gm-Message-State: AOJu0Yw/NUuMlmWEUdkEmp8HVjylLQ7ZWv73sUcojK2449n5KVagX46o DAxPjp/cm8RpVn80UBh1PsJr2bGHe1wmEOzZR6/0ar28LZ4nhBCYdOKCpcD++XsmYimBM8Re0SK PnhJU7UxQV1HuKJz2dYedcWOH3y3pV4G0w6sSPcW1PG9mAgJ0Y7kqKaHYc1zQ/+Y= X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410181vsn.3.1710421167249; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpB2lM/GBtztEZpRh5zxenkJs3cKW/cbCqzpceWYQibEUdWkJxv7eCQPooUilH8iyb4M7ppQ== X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410155vsn.3.1710421166816; Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id q14-20020a05621419ee00b00690edd77658sm413155qvc.75.2024.03.14.05.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Date: Thu, 14 Mar 2024 08:59:22 -0400 From: Peter Xu To: Christophe Leroy Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() Message-ID: References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-12-peterx@redhat.com> <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> MIME-Version: 1.0 In-Reply-To: <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Muchun Song , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Matthew Wilcox , "linux-mm@kvack.org" , Mike Rapoport , Jason Gunthorpe , "sparclinux@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 14, 2024 at 08:50:20AM +0000, Christophe Leroy wrote: > > > Le 13/03/2024 à 22:47, peterx@redhat.com a écrit : > > From: Peter Xu > > > > Now after we're sure all pXd_huge() definitions are the same as pXd_leaf(), > > reuse it. Luckily, pXd_huge() isn't widely used. > > > > Signed-off-by: Peter Xu > > --- > > arch/arm/include/asm/pgtable-3level.h | 2 +- > > arch/arm64/include/asm/pgtable.h | 2 +- > > arch/arm64/mm/hugetlbpage.c | 4 ++-- > > arch/loongarch/mm/hugetlbpage.c | 2 +- > > arch/mips/mm/tlb-r4k.c | 2 +- > > arch/powerpc/mm/pgtable_64.c | 6 +++--- > > arch/x86/mm/pgtable.c | 4 ++-- > > mm/gup.c | 4 ++-- > > mm/hmm.c | 2 +- > > mm/memory.c | 2 +- > > 10 files changed, 15 insertions(+), 15 deletions(-) > > > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > > index e7aecbef75c9..9e3c44f0aea2 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -190,7 +190,7 @@ static inline pte_t pte_mkspecial(pte_t pte) > > #define pmd_dirty(pmd) (pmd_isset((pmd), L_PMD_SECT_DIRTY)) > > > > #define pmd_hugewillfault(pmd) (!pmd_young(pmd) || !pmd_write(pmd)) > > -#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) > > +#define pmd_thp_or_huge(pmd) (pmd_leaf(pmd) || pmd_trans_huge(pmd)) > > Previous patch said pmd_trans_huge() implies pmd_leaf(). Ah here I remember I kept this arm definition there because I think we should add a patch to drop pmd_thp_or_huge() completely. If you won't mind I can add one more patch instead of doing it here. Then I keep this patch purely as a replacement patch without further changes on arch-cleanups. > > Or is that only for GUP ? I think it should apply to all. > > > > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > #define pmd_trans_huge(pmd) (pmd_val(pmd) && !pmd_table(pmd)) > > > > diff --git a/mm/hmm.c b/mm/hmm.c > > index c95b9ec5d95f..93aebd9cc130 100644 > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, > > return hmm_vma_walk_hole(start, end, -1, walk); > > } > > > > - if (pud_huge(pud) && pud_devmap(pud)) { > > + if (pud_leaf(pud) && pud_devmap(pud)) { > > Didn't previous patch say devmap implies leaf ? Or is it only for GUP ? This is an extra safety check that I didn't remove. Devmap used separate bits even though I'm not clear on why. It should still imply a leaf though. Thanks, > > > unsigned long i, npages, pfn; > > unsigned int required_fault; > > unsigned long *hmm_pfns; > > -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8A05A4CB for ; Thu, 14 Mar 2024 12:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710421171; cv=none; b=QLLB4dBrdN9ZXt5EIFaum4/aAS32JYPKJ6NdIztKMjn9HE99H+ImV2pkDjMe+OdATb/c1Un93PH03O6gCe7b1ppSJyBsP/62hWeG0/75sCTwkUFpOg1beU+hczVqhVo+uWcdzvIFwNfH18iQgnB/JOHD4lEBRuuBaHlW1SipY8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710421171; c=relaxed/simple; bh=yVKWvtTcilhjLoZ+TCPRFpuKTw3Iw+UQUwWQlErhy+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PNLfNHGLZBidBzAUhtf6XYF60Z2BVBN6087Pe2Gfs1nr+AhKpcE1aR1zAywtv7PiJLT9ppKpoVJSryvvHw4Rpm5TVHMJKBkIhWNbxtelbB0lYhZXtDn/DU8GXVsndD/C09aqnjknqnZ4o/asrB/3VBZ5B7G+6Co3Kr3rfp+pSK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dSaR2vE1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dSaR2vE1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710421169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=dSaR2vE1rU3Gnl/T8xSffNMNi88szzSueQV13TvvBalN/AdPVq9Ov+nn0E+ZfCm+fTYunp bxNc5qaajufWsHRWiO+rh22T9fOeqLcvGfBpEW8R5/b94nQ7+5aO/74SxU0top+MzSVwNT 7tF0nuLDRatjXqBQaWAjIuNkwVeHNO0= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-cMySHFWYNK61XZOhfYr0ig-1; Thu, 14 Mar 2024 08:59:27 -0400 X-MC-Unique: cMySHFWYNK61XZOhfYr0ig-1 Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-4d424421d4aso121577e0c.0 for ; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710421167; x=1711025967; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=ib2iC+5DidKLSXvoX+9gG/QgVk+n5OBR2TsxTalCHF3ZIKKBQipx939s0y4jN6nwyF PP1GP3YqmPK8/oiqFIUGvgVsuXfSTA/7dfkm1DY7WRtDW5qH8o1fpqCGKsnRfAe831Fy 53B50UlDp8cf+8sfTcrhcD0Ibej+mDLDsYZxsX9wUxVf1BMcwz9z+A784GAPoAx6KSBU XlWhHE/uNTse/jCoG0sZdA9VhjfyS42Gxr+FLDSFX+Af617zM9NnQbyjy3KKMrF9dda5 QLEzhK5lt2zwgSIK8L2QTWZW1t8XmDKzyy+9gJw8h8C3p1A6iVWkfVw0tpZ6QnqyTlRB M9xw== X-Forwarded-Encrypted: i=1; AJvYcCWIzwfTg1uh9k8vZ2tB9OBHDKQBpE2Ns6LcG/Qd2DCvldjUvV1Q0srVpqqVOytnIXoCP+SgYXOrysBW2QBjbEA5aq46nRopI7LoOg== X-Gm-Message-State: AOJu0YzVpHOD4uM1a61MULkMH+qKqmL1Wmx5M5SQRvhtZkFD2+ROiAN0 qLjFc0U47ucZVdP5DyBoa43S0wgvaX44kg7ft7KQWrRzOLHyyrOCr++Gt1w9TvovEpIoudyb/+f G+KEjaabPY2yaEtLPKi21HaVcB7cCQHCWkcKYMhlTOb4C6UAXwGezOdbk748= X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410171vsn.3.1710421167228; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpB2lM/GBtztEZpRh5zxenkJs3cKW/cbCqzpceWYQibEUdWkJxv7eCQPooUilH8iyb4M7ppQ== X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410155vsn.3.1710421166816; Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id q14-20020a05621419ee00b00690edd77658sm413155qvc.75.2024.03.14.05.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Date: Thu, 14 Mar 2024 08:59:22 -0400 From: Peter Xu To: Christophe Leroy Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , Matthew Wilcox , "linuxppc-dev@lists.ozlabs.org" , Andrew Morton , "x86@kernel.org" , Mike Rapoport , Muchun Song , "sparclinux@vger.kernel.org" , Jason Gunthorpe Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() Message-ID: References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-12-peterx@redhat.com> <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> On Thu, Mar 14, 2024 at 08:50:20AM +0000, Christophe Leroy wrote: > > > Le 13/03/2024 à 22:47, peterx@redhat.com a écrit : > > From: Peter Xu > > > > Now after we're sure all pXd_huge() definitions are the same as pXd_leaf(), > > reuse it. Luckily, pXd_huge() isn't widely used. > > > > Signed-off-by: Peter Xu > > --- > > arch/arm/include/asm/pgtable-3level.h | 2 +- > > arch/arm64/include/asm/pgtable.h | 2 +- > > arch/arm64/mm/hugetlbpage.c | 4 ++-- > > arch/loongarch/mm/hugetlbpage.c | 2 +- > > arch/mips/mm/tlb-r4k.c | 2 +- > > arch/powerpc/mm/pgtable_64.c | 6 +++--- > > arch/x86/mm/pgtable.c | 4 ++-- > > mm/gup.c | 4 ++-- > > mm/hmm.c | 2 +- > > mm/memory.c | 2 +- > > 10 files changed, 15 insertions(+), 15 deletions(-) > > > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > > index e7aecbef75c9..9e3c44f0aea2 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -190,7 +190,7 @@ static inline pte_t pte_mkspecial(pte_t pte) > > #define pmd_dirty(pmd) (pmd_isset((pmd), L_PMD_SECT_DIRTY)) > > > > #define pmd_hugewillfault(pmd) (!pmd_young(pmd) || !pmd_write(pmd)) > > -#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) > > +#define pmd_thp_or_huge(pmd) (pmd_leaf(pmd) || pmd_trans_huge(pmd)) > > Previous patch said pmd_trans_huge() implies pmd_leaf(). Ah here I remember I kept this arm definition there because I think we should add a patch to drop pmd_thp_or_huge() completely. If you won't mind I can add one more patch instead of doing it here. Then I keep this patch purely as a replacement patch without further changes on arch-cleanups. > > Or is that only for GUP ? I think it should apply to all. > > > > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > #define pmd_trans_huge(pmd) (pmd_val(pmd) && !pmd_table(pmd)) > > > > diff --git a/mm/hmm.c b/mm/hmm.c > > index c95b9ec5d95f..93aebd9cc130 100644 > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, > > return hmm_vma_walk_hole(start, end, -1, walk); > > } > > > > - if (pud_huge(pud) && pud_devmap(pud)) { > > + if (pud_leaf(pud) && pud_devmap(pud)) { > > Didn't previous patch say devmap implies leaf ? Or is it only for GUP ? This is an extra safety check that I didn't remove. Devmap used separate bits even though I'm not clear on why. It should still imply a leaf though. Thanks, > > > unsigned long i, npages, pfn; > > unsigned int required_fault; > > unsigned long *hmm_pfns; > > -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A9AFC54E60 for ; Thu, 14 Mar 2024 12:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fSZHJgHJIwaNltM1ea0ap8LLOzqq17rjmIc9wuRQc5k=; b=zoUrFy+jScESm0 Vq/72x6wZeG1L05MyB7MPlvipZwoErwBB+c2fMHdweQhO8PgckZthqrx+vkNgq85/vS6B3R2mPVMR 9gfAzOL7Vq5PU2I2ZiJP9PNkeTxR3wQERKkNQiBbOufV4luN+GBklbkAXB5Pk5cALOPNBR+qrCCAX xtMoDlx2ZLSagIxL0/bxyzFo8tsJanoHtiAL9wmNt1N+59gi7s/VVMpxi7PwbuVpzsKFe7lEqUAXr r3fmMaujU8IB7SvLxjxQbM+8eNV6aEXk8iyP+Dy7RZI0/py8v4WJoX+rWT6gQGaK0wnyvWklQoLr9 tHG8FFCQZpJD6C2pn3OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkkgJ-0000000EKJT-2Ac5; Thu, 14 Mar 2024 12:59:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkkgE-0000000EKHR-41vf for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2024 12:59:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710421169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=dSaR2vE1rU3Gnl/T8xSffNMNi88szzSueQV13TvvBalN/AdPVq9Ov+nn0E+ZfCm+fTYunp bxNc5qaajufWsHRWiO+rh22T9fOeqLcvGfBpEW8R5/b94nQ7+5aO/74SxU0top+MzSVwNT 7tF0nuLDRatjXqBQaWAjIuNkwVeHNO0= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-aJZQklPLPjqB98dT1g8oUA-1; Thu, 14 Mar 2024 08:59:27 -0400 X-MC-Unique: aJZQklPLPjqB98dT1g8oUA-1 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-4d40baecf23so77717e0c.1 for ; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710421167; x=1711025967; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jKCzOVXDDLeWui+9xMnOflGFcsiyeRgIZTuCOA+l7OQ=; b=Hgnk4GMPf7TJNFsSMWPH4chDrdcqA03W7OaBoswBEwTVMmZz1K26jWMFQs0g8ABYol oc4aQ2mPIQ9J8UlFvcgnWHWHytkZV6g8EwRgNfspNCQ73mgICK067zqHs9kHATqgLasR bfLaXa3e1maVSOZfVm1DqWiblNM2MUunQILAeFpNqCY5thBXgSrcggsa6gbW9zBX8VLH 0nGqtNvgHeBYbOTruPZps2sN/lmnuWE3wh+dCfvM3Gn0P0H6dntkPoJ82eBROG4wLmz7 itlSQLFo9A7UghqarX6phK2I90RQGRF0RNmQOiYTPwT0fslhYdgOBEp39bnl8sM95LvV sXCg== X-Forwarded-Encrypted: i=1; AJvYcCXcS3WBTWP3PeONKocIyMBVFDOLerK+JvOpywE2fCUWmRgZd52ygNJKKjMhprAbCqwg+WR22dIquz9InhWMak5mJMcc7JVG6MVAFKPDKufLyj6Uqi4= X-Gm-Message-State: AOJu0Yz+VNaZa5uhCZweB2HlE23P2By9ocR5RifsceY3PGTltwkeES3c ol3urCY4keEi6mQqLD56zihqHGiyFrnbwIutHbq/DcTHmaEcCbkqZ9RhzG+k/dmfrWbjkMR7Y8N ZYpAhY/OQN4dhiSlNudp0jf6wuyMPlLkDQXQCARjCdftrWH7h/HEKiVecOh5m8PIO/BWlctH3 X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410170vsn.3.1710421167228; Thu, 14 Mar 2024 05:59:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpB2lM/GBtztEZpRh5zxenkJs3cKW/cbCqzpceWYQibEUdWkJxv7eCQPooUilH8iyb4M7ppQ== X-Received: by 2002:a67:f405:0:b0:476:7cf:5495 with SMTP id p5-20020a67f405000000b0047607cf5495mr1410155vsn.3.1710421166816; Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id q14-20020a05621419ee00b00690edd77658sm413155qvc.75.2024.03.14.05.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 05:59:26 -0700 (PDT) Date: Thu, 14 Mar 2024 08:59:22 -0400 From: Peter Xu To: Christophe Leroy Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , Matthew Wilcox , "linuxppc-dev@lists.ozlabs.org" , Andrew Morton , "x86@kernel.org" , Mike Rapoport , Muchun Song , "sparclinux@vger.kernel.org" , Jason Gunthorpe Subject: Re: [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() Message-ID: References: <20240313214719.253873-1-peterx@redhat.com> <20240313214719.253873-12-peterx@redhat.com> <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> MIME-Version: 1.0 In-Reply-To: <0f929f80-92fd-4824-a7d6-839f1aef4c8a@csgroup.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240314_055931_105893_BD838325 X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMTQsIDIwMjQgYXQgMDg6NTA6MjBBTSArMDAwMCwgQ2hyaXN0b3BoZSBMZXJv eSB3cm90ZToKPiAKPiAKPiBMZSAxMy8wMy8yMDI0IMOgIDIyOjQ3LCBwZXRlcnhAcmVkaGF0LmNv bSBhIMOpY3JpdMKgOgo+ID4gRnJvbTogUGV0ZXIgWHUgPHBldGVyeEByZWRoYXQuY29tPgo+ID4g Cj4gPiBOb3cgYWZ0ZXIgd2UncmUgc3VyZSBhbGwgcFhkX2h1Z2UoKSBkZWZpbml0aW9ucyBhcmUg dGhlIHNhbWUgYXMgcFhkX2xlYWYoKSwKPiA+IHJldXNlIGl0LiAgTHVja2lseSwgcFhkX2h1Z2Uo KSBpc24ndCB3aWRlbHkgdXNlZC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgWHUgPHBl dGVyeEByZWRoYXQuY29tPgo+ID4gLS0tCj4gPiAgIGFyY2gvYXJtL2luY2x1ZGUvYXNtL3BndGFi bGUtM2xldmVsLmggfCAyICstCj4gPiAgIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vcGd0YWJsZS5o ICAgICAgfCAyICstCj4gPiAgIGFyY2gvYXJtNjQvbW0vaHVnZXRsYnBhZ2UuYyAgICAgICAgICAg fCA0ICsrLS0KPiA+ICAgYXJjaC9sb29uZ2FyY2gvbW0vaHVnZXRsYnBhZ2UuYyAgICAgICB8IDIg Ky0KPiA+ICAgYXJjaC9taXBzL21tL3RsYi1yNGsuYyAgICAgICAgICAgICAgICB8IDIgKy0KPiA+ ICAgYXJjaC9wb3dlcnBjL21tL3BndGFibGVfNjQuYyAgICAgICAgICB8IDYgKysrLS0tCj4gPiAg IGFyY2gveDg2L21tL3BndGFibGUuYyAgICAgICAgICAgICAgICAgfCA0ICsrLS0KPiA+ICAgbW0v Z3VwLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDQgKystLQo+ID4gICBtbS9obW0u YyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMiArLQo+ID4gICBtbS9tZW1vcnkuYyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgMiArLQo+ID4gICAxMCBmaWxlcyBjaGFuZ2VkLCAx NSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2luY2x1ZGUvYXNtL3BndGFibGUtM2xldmVsLmggYi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9wZ3RhYmxlLTNsZXZlbC5oCj4gPiBpbmRleCBlN2FlY2JlZjc1YzkuLjllM2M0NGYwYWVhMiAx MDA2NDQKPiA+IC0tLSBhL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BndGFibGUtM2xldmVsLmgKPiA+ ICsrKyBiL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BndGFibGUtM2xldmVsLmgKPiA+IEBAIC0xOTAs NyArMTkwLDcgQEAgc3RhdGljIGlubGluZSBwdGVfdCBwdGVfbWtzcGVjaWFsKHB0ZV90IHB0ZSkK PiA+ICAgI2RlZmluZSBwbWRfZGlydHkocG1kKQkJKHBtZF9pc3NldCgocG1kKSwgTF9QTURfU0VD VF9ESVJUWSkpCj4gPiAgIAo+ID4gICAjZGVmaW5lIHBtZF9odWdld2lsbGZhdWx0KHBtZCkJKCFw bWRfeW91bmcocG1kKSB8fCAhcG1kX3dyaXRlKHBtZCkpCj4gPiAtI2RlZmluZSBwbWRfdGhwX29y X2h1Z2UocG1kKQkocG1kX2h1Z2UocG1kKSB8fCBwbWRfdHJhbnNfaHVnZShwbWQpKQo+ID4gKyNk ZWZpbmUgcG1kX3RocF9vcl9odWdlKHBtZCkJKHBtZF9sZWFmKHBtZCkgfHwgcG1kX3RyYW5zX2h1 Z2UocG1kKSkKPiAKPiBQcmV2aW91cyBwYXRjaCBzYWlkIHBtZF90cmFuc19odWdlKCkgaW1wbGll cyBwbWRfbGVhZigpLgoKQWggaGVyZSBJIHJlbWVtYmVyIEkga2VwdCB0aGlzIGFybSBkZWZpbml0 aW9uIHRoZXJlIGJlY2F1c2UgSSB0aGluayB3ZQpzaG91bGQgYWRkIGEgcGF0Y2ggdG8gZHJvcCBw bWRfdGhwX29yX2h1Z2UoKSBjb21wbGV0ZWx5LiAgSWYgeW91IHdvbid0IG1pbmQKSSBjYW4gYWRk IG9uZSBtb3JlIHBhdGNoIGluc3RlYWQgb2YgZG9pbmcgaXQgaGVyZS4gIFRoZW4gSSBrZWVwIHRo aXMgcGF0Y2gKcHVyZWx5IGFzIGEgcmVwbGFjZW1lbnQgcGF0Y2ggd2l0aG91dCBmdXJ0aGVyIGNo YW5nZXMgb24gYXJjaC1jbGVhbnVwcy4KCj4gCj4gT3IgaXMgdGhhdCBvbmx5IGZvciBHVVAgPwoK SSB0aGluayBpdCBzaG91bGQgYXBwbHkgdG8gYWxsLgoKPiAKPiA+ICAgCj4gPiAgICNpZmRlZiBD T05GSUdfVFJBTlNQQVJFTlRfSFVHRVBBR0UKPiA+ICAgI2RlZmluZSBwbWRfdHJhbnNfaHVnZShw bWQpCShwbWRfdmFsKHBtZCkgJiYgIXBtZF90YWJsZShwbWQpKQo+IAo+IAo+ID4gZGlmZiAtLWdp dCBhL21tL2htbS5jIGIvbW0vaG1tLmMKPiA+IGluZGV4IGM5NWI5ZWM1ZDk1Zi4uOTNhZWJkOWNj MTMwIDEwMDY0NAo+ID4gLS0tIGEvbW0vaG1tLmMKPiA+ICsrKyBiL21tL2htbS5jCj4gPiBAQCAt NDI5LDcgKzQyOSw3IEBAIHN0YXRpYyBpbnQgaG1tX3ZtYV93YWxrX3B1ZChwdWRfdCAqcHVkcCwg dW5zaWduZWQgbG9uZyBzdGFydCwgdW5zaWduZWQgbG9uZyBlbmQsCj4gPiAgIAkJcmV0dXJuIGht bV92bWFfd2Fsa19ob2xlKHN0YXJ0LCBlbmQsIC0xLCB3YWxrKTsKPiA+ICAgCX0KPiA+ICAgCj4g PiAtCWlmIChwdWRfaHVnZShwdWQpICYmIHB1ZF9kZXZtYXAocHVkKSkgewo+ID4gKwlpZiAocHVk X2xlYWYocHVkKSAmJiBwdWRfZGV2bWFwKHB1ZCkpIHsKPiAKPiBEaWRuJ3QgcHJldmlvdXMgcGF0 Y2ggc2F5IGRldm1hcCBpbXBsaWVzIGxlYWYgPyBPciBpcyBpdCBvbmx5IGZvciBHVVAgPwoKVGhp cyBpcyBhbiBleHRyYSBzYWZldHkgY2hlY2sgdGhhdCBJIGRpZG4ndCByZW1vdmUuICBEZXZtYXAg dXNlZCBzZXBhcmF0ZQpiaXRzIGV2ZW4gdGhvdWdoIEknbSBub3QgY2xlYXIgb24gd2h5LiAgSXQg c2hvdWxkIHN0aWxsIGltcGx5IGEgbGVhZiB0aG91Z2guCgpUaGFua3MsCgo+IAo+ID4gICAJCXVu c2lnbmVkIGxvbmcgaSwgbnBhZ2VzLCBwZm47Cj4gPiAgIAkJdW5zaWduZWQgaW50IHJlcXVpcmVk X2ZhdWx0Owo+ID4gICAJCXVuc2lnbmVkIGxvbmcgKmhtbV9wZm5zOwo+IAo+IAoKLS0gClBldGVy IFh1CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=