From: Michal Kubiak <michal.kubiak@intel.com>
To: Yewon Choi <woni9911@gmail.com>
Cc: Allison Henderson <allison.henderson@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<rds-devel@oss.oracle.com>, <linux-kernel@vger.kernel.org>,
"Dae R. Jeong" <threeearcat@gmail.com>
Subject: Re: [PATCH net] rds: introduce acquire/release ordering in acquire/release_in_xmit()
Date: Thu, 14 Mar 2024 12:51:38 +0100 [thread overview]
Message-ID: <ZfLkyiTssYD8wmVl@localhost.localdomain> (raw)
In-Reply-To: <ZfLdv5DZvBg0wajJ@libra05>
On Thu, Mar 14, 2024 at 08:21:35PM +0900, Yewon Choi wrote:
> acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so they
> are expected to ensure acquire/release memory ordering semantics.
> However, test_and_set_bit/clear_bit() don't imply such semantics, on
> top of this, following smp_mb__after_atomic() does not guarantee release
> ordering (memory barrier actually should be placed before clear_bit()).
>
> Instead, we use clear_bit_unlock/test_and_set_bit_lock() here.
>
> Signed-off-by: Yewon Choi <woni9911@gmail.com>
Missing "Fixes" tag for the patch addressed to the "net" tree.
Thanks,
Michal
next prev parent reply other threads:[~2024-03-14 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 11:21 [PATCH net] rds: introduce acquire/release ordering in acquire/release_in_xmit() Yewon Choi
2024-03-14 11:51 ` Michal Kubiak [this message]
2024-03-14 22:37 ` Allison Henderson
2024-03-15 9:24 ` Yewon Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfLkyiTssYD8wmVl@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=threeearcat@gmail.com \
--cc=woni9911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.