From: Sean Christopherson <seanjc@google.com>
To: Manali Shukla <manali.shukla@amd.com>
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
pbonzini@redhat.com, shuah@kernel.org, nikunj@amd.com,
thomas.lendacky@amd.com, vkuznets@redhat.com, bp@alien8.de
Subject: Re: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test
Date: Thu, 14 Mar 2024 08:06:21 -0700 [thread overview]
Message-ID: <ZfMSbS1oalRPZ-MF@google.com> (raw)
In-Reply-To: <075ff472-67c7-4cb1-a344-9c1066821eb4@amd.com>
On Thu, Mar 14, 2024, Manali Shukla wrote:
> >> +#define VINTR_VECTOR 0x30
> >> +#define NUM_ITERATIONS 100000
> >
> > What's the runtime? If it's less than a second, then whatever, but if it's at
> > all longer than that, then I'd prefer to use a lower default and make this user-
> > configurable.
>
> It takes ~34s to run this test.
LOL, yeah, no. That's 33+ seconds of wasted time. From a *KVM* perspective, this
is quite binary: either KVM intercepts HLT or it doesn't. Any timing bugs would
be purely CPU bugs.
Please adjust this to have the default runtime <1 second. If you feel strongly
about the need for a long-running test, feel free to add a command line option
to control the number of iterations.
next prev parent reply other threads:[~2024-03-14 15:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 5:46 [PATCH v1 0/5] Add support for the Idle HLT intercept feature Manali Shukla
2024-03-07 5:46 ` [PATCH v1 1/5] x86/cpufeatures: Add CPUID feature bit for Idle HLT intercept Manali Shukla
2024-03-07 5:46 ` [PATCH v1 2/5] KVM: SVM: Add Idle HLT intercept support Manali Shukla
2024-03-07 5:46 ` [PATCH v1 3/5] tools: Add KVM exit reason for the Idle HLT Manali Shukla
2024-03-07 14:30 ` Sean Christopherson
2024-03-12 6:10 ` Manali Shukla
2024-03-07 5:46 ` [PATCH v1 4/5] selftests: Add an interface to read the data of named vcpu stat Manali Shukla
2024-03-07 5:46 ` [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test Manali Shukla
2024-03-07 18:22 ` Sean Christopherson
2024-03-07 18:24 ` Sean Christopherson
2024-03-14 5:35 ` Manali Shukla
2024-03-14 15:06 ` Sean Christopherson [this message]
2024-03-22 16:03 ` Manali Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfMSbS1oalRPZ-MF@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.