All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org,
	"Michał Winiarski" <michal.winiarski@intel.com>
Subject: Re: [PATCH v2 3/3] drm/xe/pf: Always select Multi-Level LMTT for platforms 12.60+
Date: Thu, 14 Mar 2024 19:36:53 -0400	[thread overview]
Message-ID: <ZfOKFbCKlIO1RVth@intel.com> (raw)
In-Reply-To: <20240313104132.1045-4-michal.wajdeczko@intel.com>

On Wed, Mar 13, 2024 at 11:41:32AM +0100, Michal Wajdeczko wrote:
> The Multi-Level LMTT variant is not specific only to the PVC.
> Change logic to select it for all new platforms beyond 12.60.
> 
> Bspec: 52404, 67468
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> ---
> v2: prefer GRAPHICS_VERx100 over PLATFORM (Rodrigo)
> ---
>  drivers/gpu/drm/xe/xe_lmtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
> index dfb0e1887615..7f504392a8bf 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.c
> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> @@ -35,7 +35,7 @@
>  
>  static bool xe_has_multi_level_lmtt(struct xe_device *xe)
>  {
> -	return xe->info.platform == XE_PVC;
> +	return GRAPHICS_VERx100(xe) >= 1260;
>  }
>  
>  static struct xe_tile *lmtt_to_tile(struct xe_lmtt *lmtt)
> -- 
> 2.43.0
> 

  reply	other threads:[~2024-03-14 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 10:41 [PATCH v2 0/3] LMTT improvements Michal Wajdeczko
2024-03-13 10:41 ` [PATCH v2 1/3] drm/xe: Allow VRAM BO allocations aligned to 64K Michal Wajdeczko
2024-03-13 10:41 ` [PATCH v2 2/3] drm/xe/pf: Request 64K aligned allocations for LMTT PD Michal Wajdeczko
2024-03-13 10:41 ` [PATCH v2 3/3] drm/xe/pf: Always select Multi-Level LMTT for platforms 12.60+ Michal Wajdeczko
2024-03-14 23:36   ` Rodrigo Vivi [this message]
2024-03-13 11:23 ` ✓ CI.Patch_applied: success for LMTT improvements (rev2) Patchwork
2024-03-13 11:24 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-13 11:24 ` ✓ CI.KUnit: success " Patchwork
2024-03-13 11:35 ` ✓ CI.Build: " Patchwork
2024-03-13 11:38 ` ✓ CI.Hooks: " Patchwork
2024-03-13 11:39 ` ✓ CI.checksparse: " Patchwork
2024-03-13 12:17 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfOKFbCKlIO1RVth@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=michal.winiarski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.