From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
John Kacur <jkacur@redhat.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
linux-perf-users@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector
Date: Fri, 15 Mar 2024 11:53:36 -0300 [thread overview]
Message-ID: <ZfRg8CB5xXL2Y-zC@x1> (raw)
In-Reply-To: <32958f50-b713-40ba-9e12-2a1b5667a91f@kernel.org>
On Fri, Mar 15, 2024 at 03:48:58PM +0100, Daniel Bristot de Oliveira wrote:
> On 3/15/24 15:24, Daniel Bristot de Oliveira wrote:
> > Use tools/build/ makefiles to build latency-collector, inheriting
> > the benefits of it. For example: Before this patch, a missing
> > tracefs/traceevents headers will result in fail like this:
> >
> > -------------------------------- %< -------------------------------
>
> Oops, b4 is interpreting these ------ as the '---' separator, and is truncating
> the message. I will fix this in a v3.
>
> sorry.
Yeah, that confuses scripts, that separator.
But overall I tested various versions of your patches and they look ok.
That tools/build/ was done for other tools to use and so far some tools/
living projects use it: tools/objtool, tools/lib/subcmd, etc.
I just did a:
git grep tools\/build
And there is quite a few more I didn't realize have been using bits and
pieces, good.
- Arnaldo
next prev parent reply other threads:[~2024-03-15 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 14:24 [PATCH V2 0/3] tools/tracing: Use tools/build makefiles like perf Daniel Bristot de Oliveira
2024-03-15 14:24 ` [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector Daniel Bristot de Oliveira
2024-03-15 14:48 ` Daniel Bristot de Oliveira
2024-03-15 14:53 ` Arnaldo Carvalho de Melo [this message]
2024-03-15 15:17 ` Daniel Bristot de Oliveira
2024-03-15 14:25 ` [PATCH V2 2/3] tools/rtla: Use tools/build makefiles to build rtla Daniel Bristot de Oliveira
2024-03-15 14:25 ` [PATCH V2 3/3] tools/verification: Use tools/build makefiles on rv Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfRg8CB5xXL2Y-zC@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=bristot@kernel.org \
--cc=jkacur@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.