From: Stanislav Fomichev <sdf@google.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@meta.com, Kui-Feng Lee <thinker.li@gmail.com>
Subject: Re: [PATCH bpf-next] bpf: Remove unnecessary err < 0 check in bpf_struct_ops_map_update_elem
Date: Fri, 15 Mar 2024 13:32:54 -0700 [thread overview]
Message-ID: <ZfSwdgGcQypDLVXh@google.com> (raw)
In-Reply-To: <20240315192112.2825039-1-martin.lau@linux.dev>
On 03/15, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> There is a "if (err)" check earlier, so the "if (err < 0)"
> check that this patch removing is unnecessary. It was my overlook
> when making adjustments to the bpf_struct_ops_prepare_trampoline()
> such that the caller does not have to worry about the new page when
> the function returns error.
>
> Cc: Kui-Feng Lee <thinker.li@gmail.com>
> Fixes: 187e2af05abe ("bpf: struct_ops supports more than one page for trampolines.")
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
next prev parent reply other threads:[~2024-03-15 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 19:21 [PATCH bpf-next] bpf: Remove unnecessary err < 0 check in bpf_struct_ops_map_update_elem Martin KaFai Lau
2024-03-15 20:32 ` Stanislav Fomichev [this message]
2024-03-18 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfSwdgGcQypDLVXh@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@linux.dev \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.