Re: [PATCH net 0/6] wireguard fixes for 6.9-rc1

[Jiri Pirko <jiri@resnulli.us>]

Thu, Mar 14, 2024 at 11:49:05PM CET, Jason@zx2c4.com wrote:
>Hey netdev,
>
>This series has four WireGuard fixes:
>
>1) Annotate a data race that KCSAN found by using READ_ONCE/WRITE_ONCE,
>   which has been causing syzkaller noise.
>
>2) Use the generic netdev tstats allocation and stats getters instead of
>   doing this within the driver.
>
>3) Explicitly check a flag variable instead of an empty list in the
>   netlink code, to prevent a UaF situation when paging through GET
>   results during a remove-all SET operation.
>
>4) Set a flag in the RISC-V CI config so the selftests continue to boot.
>
>Please apply these!
>
>Thanks,
>Jason
>
>
>Breno Leitao (2):
>  wireguard: device: leverage core stats allocator
>  wireguard: device: remove generic .ndo_get_stats64
>
>Jason A. Donenfeld (3):
>  wireguard: netlink: check for dangling peer via is_dead instead of
>    empty list
>  wireguard: netlink: access device through ctx instead of peer
>  wireguard: selftests: set RISCV_ISA_FALLBACK on riscv{32,64}
>
>Nikita Zhandarovich (1):
>  wireguard: receive: annotate data-race around
>    receiving_counter.counter

Looks fine to me.

set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>



>
> drivers/net/wireguard/device.c                        | 11 ++---------
> drivers/net/wireguard/netlink.c                       | 10 +++++-----
> drivers/net/wireguard/receive.c                       |  6 +++---
> .../selftests/wireguard/qemu/arch/riscv32.config      |  1 +
> .../selftests/wireguard/qemu/arch/riscv64.config      |  1 +
> 5 files changed, 12 insertions(+), 17 deletions(-)
>
>-- 
>2.44.0
>
>