From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79C80C54E5D for ; Tue, 19 Mar 2024 14:05:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNAeT70P; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNAeT70P; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TzYQZ0h4Kz3vYB for ; Wed, 20 Mar 2024 01:05:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNAeT70P; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNAeT70P; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TzYPj1q00z3bWH for ; Wed, 20 Mar 2024 01:04:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=UNAeT70P6dWCHTAtRa1DRYA3iIbyZjtwpT/Jq7RnlaAoqDAzpK9HtBUkjVMuucrG+RrlEc JZklrnpLniS8X8mnnArWzFZYIuCFLjilxfIxpXvwPOv6+d1I1n4m5nuVqTRepvH93M/YsL 7i/We1qwLx0rF/ss+KEG2Lc2vPaGB6g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=UNAeT70P6dWCHTAtRa1DRYA3iIbyZjtwpT/Jq7RnlaAoqDAzpK9HtBUkjVMuucrG+RrlEc JZklrnpLniS8X8mnnArWzFZYIuCFLjilxfIxpXvwPOv6+d1I1n4m5nuVqTRepvH93M/YsL 7i/We1qwLx0rF/ss+KEG2Lc2vPaGB6g= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-26Ly8pCfPEydSPBL4azZ0g-1; Tue, 19 Mar 2024 10:04:33 -0400 X-MC-Unique: 26Ly8pCfPEydSPBL4azZ0g-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-78a0e8a60f8so17972085a.0 for ; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710857073; x=1711461873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=EVdjWpDO2O/mydwRPmcM1/kchknxxGr4tw8rx4fv9Yf0t4EgXipndr0xnvRsGJC0XA 222ZP45pHOyuiWb2IdbBoC2LQXSZHDqoFlAqFfZyAucBHHxBkrbid5nyTMr2M5uDC+iW tRfIYjBNk0BSonFvNhgJjYO5r/iG5jr6AQqwxKitdu27nWZG3VnpC/C+FurCBzBgyrox 1Uz+eFh3ET/l5cpO2BWCGkzNTMDhC8voSssynO3wii9ODFBFD0ZO3G3jWS6xIZN64qf6 E7SebEVCQaG/3Z+RkBx4Q/VFGSrxmRiINMysJ5kBXycKvIZT4F6zuCTerf54SsZaBvUL pj/Q== X-Forwarded-Encrypted: i=1; AJvYcCVictGc1q0RGQWvV2JI5s9kzUnQlXe+WfOsMHFFGZJCjLsKa5T011VpaPoAsp3/I3uGNSr0t1j4Pdi3yFs3N7SbhyTM+9DO0PPZhQ82jw== X-Gm-Message-State: AOJu0YwP76ZheFivd7NfvMhTlkww93pHM5ZN1ONXJUPinJ9uDZ0hQpdy BlACK/zpMx6VPDblDs3p8zjqSZ0I8/u9F3EJezQKJAQ+Hh/wHsNtapZVc4iDenQ/xYyfGO805Ny qgKJEvFcqUb5spkn+dJtLIxVncA2XWp3DvfmKKOJ6do4nvqeowLXTgY+OLOM8O1Y= X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518355qkb.4.1710857073245; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2woW7UEchY2IkBVWYzgRK0KWJ4spUtcTxNI2cDq95Ac2i5H9cK+iTpsS+AG/gM2n1vRK6zQ== X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518292qkb.4.1710857072670; Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id ye1-20020a05620a3b8100b00789e1874eccsm4708269qkn.41.2024.03.19.07.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Date: Tue, 19 Mar 2024 10:04:31 -0400 From: Peter Xu To: Muchun Song Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries Message-ID: References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> MIME-Version: 1.0 In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Andreas Larsson , x86@kernel.org, LKML , Matthew Wilcox , Linux-MM , Jason Gunthorpe , sparclinux@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote: > > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > > > > int pmd_huge(pmd_t pmd) > > { > > - return !pmd_none(pmd) && > > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; > > + return pmd_leaf(pmd);; > > There is a redundant semicolon in the end. Will touch it up, thanks. PS: This will be dropped as a whole in patch 12. -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533EE7D3EA for ; Tue, 19 Mar 2024 14:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710857079; cv=none; b=KqWi3B5Ohngo0j1PqjAWukqOuLuJPcKwytCCu+kOoaNWOxqgdgVhlys5eDU/1GuMtwP8zuE960XDRvz1TurEU+4Kea96OzGZFRKXCOWDNc9kfaGDLikwu43F9nNKS4Fr3Tb2vSRf8zU5+BdBtAyDqEcVXokgfilqxZVmWCaCKbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710857079; c=relaxed/simple; bh=yNVTuH8Tx4LSKyNlUvmV1JciL2tHoqgg0gSm10mQhSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FKIgJwsJbfGpbMRwumIJ/HXPbZ5RUDIxTWTIJ/bbLeM/XsQsXP63c1IW7NrVIH9iTbuoZZh885dRLDsLeqSug2yy76auqZNylxKERzlJjipc+CAKAs4msEnhIvedG3AGPmlql1WNK2CChmIfY48lUbaMqnDl5FI0SkA+5BcXp7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dhdd4sVL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dhdd4sVL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=Dhdd4sVLgkgdh3Z5QXzj0spXGyeB/YJRyfoyFFc4U0688tvIzbZJPGqznrAi9SMkPsOI2g eHFnZz08bLMeyz5X1zLSKwqkqFSudYV/NjjADz9TV7WbsDGqcXnBaz9eq2hsHPTMq3yC9m ufnYuknGtzBTCK0QIwi08uACmtJHqzI= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-2Yr466-NM0aaUugiDEEIxQ-1; Tue, 19 Mar 2024 10:04:33 -0400 X-MC-Unique: 2Yr466-NM0aaUugiDEEIxQ-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7830635331bso155304685a.1 for ; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710857073; x=1711461873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=LN5RlZgIGj/trnGNppEe6vz0l9mKs2AHjdhS1XCMkSJg98Wv0MJOB31WpvSTEINVTb RCK4yovPxL7nx2n/2sqBiGN5UndqRHqkoKo/pKCUvAZraY9+HCQIMjhSAMuDX7xFsXE/ vFS1mKar7emge7DNzIL01zNBxBCRNfyUk1NA/EC0vWefdQNHUirmS/AH16Zi/E/AYVM7 se7XLHePg+RSQbaD6Cz5sfjsP1VuxundMqb/EKd0SP12O6QxsZiBS9yDV/kMlvecmZin dVCFZO7jskAVPO34xR5u1d8MTTzvuMbIFs6F/Jd/b2neaylwj9xEzlmDdZ8jpMX/LDS/ Na9w== X-Forwarded-Encrypted: i=1; AJvYcCXGJi/CsdilqEdR4/UnrccWdUzsauulWS6euczPH6PyIA0wqMyw8EI3UrZVvIiV9AJ71QB13ZtaXyj0/xy9Kbn/3QN3S40UsdJCQQ== X-Gm-Message-State: AOJu0Yynp3WQjZjG6CaGjr0/PgGCLXf0jj6UTih2Lgj/E1/dpIJ3MfcG bblyUHvWBG0hBR1na4whzns8mCtH8gj5LOM3NuzeXmiQW9Wqq4hLRY5zi4DTVU1fZqPtEG2q2V2 MnO5MLEqNrgzz0gh1dgjDsTShxoux7wVFoPcVCsE/crHQ120VujXcFBZ1m3c= X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518348qkb.4.1710857073237; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2woW7UEchY2IkBVWYzgRK0KWJ4spUtcTxNI2cDq95Ac2i5H9cK+iTpsS+AG/gM2n1vRK6zQ== X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518292qkb.4.1710857072670; Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id ye1-20020a05620a3b8100b00789e1874eccsm4708269qkn.41.2024.03.19.07.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Date: Tue, 19 Mar 2024 10:04:31 -0400 From: Peter Xu To: Muchun Song Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries Message-ID: References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote: > > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > > > > int pmd_huge(pmd_t pmd) > > { > > - return !pmd_none(pmd) && > > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; > > + return pmd_leaf(pmd);; > > There is a redundant semicolon in the end. Will touch it up, thanks. PS: This will be dropped as a whole in patch 12. -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AB8EC54E60 for ; Tue, 19 Mar 2024 14:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wWYce8SKyjWj7WWU6c3HOl+dBvzna5fSgEutm2fs0hQ=; b=3jAan784MJ1l+S Muw1YAEa/2649rBBhQJF8enRlOIkZEAEQhR7NHg0YGh/dfUN0Bz6LXyPzk/62q1soNfBU6Ok8DGRT JErrK+Luci9cj7VXYdABJ/No+OtIv32Yss120GWgw5jCKcs3GqnbOnszZAsGN8TpWC9tfot7osDF1 1D6T1FQKZboSJWQjTMvkIESedWizsEkZF4cjxpUfA0VI/0aQGu5rxPwOf+xm3wKr5cop/0QfLuBJQ JTIY+oxue2eODvk3lTULtGAiprj2dIygLVtxnL6doEcP/JxgMHG+nEGRRjuae4nzHkkh3ksbVZE8n KdIoBHDTFVrEDJ8V9Z7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rma51-0000000Cu9b-3FRg; Tue, 19 Mar 2024 14:04:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rma4y-0000000Cu8J-1zVS for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 14:04:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=UNAeT70P6dWCHTAtRa1DRYA3iIbyZjtwpT/Jq7RnlaAoqDAzpK9HtBUkjVMuucrG+RrlEc JZklrnpLniS8X8mnnArWzFZYIuCFLjilxfIxpXvwPOv6+d1I1n4m5nuVqTRepvH93M/YsL 7i/We1qwLx0rF/ss+KEG2Lc2vPaGB6g= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-JzLnSDEuN0mKeYwiVWVjxg-1; Tue, 19 Mar 2024 10:04:33 -0400 X-MC-Unique: JzLnSDEuN0mKeYwiVWVjxg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7830635331bso155304985a.1 for ; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710857073; x=1711461873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8w0eeleNwYf+7p/hWMlw61q+s/j0K+e36TEHXQ6sQvU=; b=rRyCF9Q41szMZi9YPDPMOzwI7Hs7xOSixcZVmoFtq928sCgd5yJhIcVtJeAPBWJro2 mcHz5ha5Jg2ZroJ4fuSAW86xc3XOwDuOx0Krl165xbBXEVfwNJTdWtIIHEdgN0obrz0A gqvJY520fnfnZET7QDxdIc/mgFr/6miCNu58NBse1ZKinvpaQEHDwQn0aq+4XzCVdX51 9iYEzDdWXM+5zm2yycuCWP5h3qAje6F8FcrjdKM7O/RQevmY3XVSLhqcaMA0e9V+zMte 9kGOi5Kc8/U4DoeDmIuIKnfyU/uSsR76QML73VBSK8Gvlk4kyrY00rzN3fsF368M4/Oz wbCQ== X-Forwarded-Encrypted: i=1; AJvYcCVZxTx3V2apN0WXQaqEbDMY8zbJLkiKSyTtJeRQgTPvB53zgXsQKCpZZHjkJK9OqKtIFZIiWZ0Je4iTKrX0ew8mesISev67Krtlr5t6XnXjjBcaHFI= X-Gm-Message-State: AOJu0YyOLQHcNdtn9T3MR7UqYLQS+fjsiTUT/unyCIF/OlEVarmlNPxp RL40+AzGfJY4GxEyeWtGGLE8GJfIcfVZgPunJ+gtWuDuoqzsVmhC04kiDL/3oe94KerRPUp9rkg b0ZnIgHuBnK9VTDnpoDU46UNwwKBwnb9qu0CjiV1MQU6HIycIncu7k4mXinCm2yckNskwSWIE X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518347qkb.4.1710857073232; Tue, 19 Mar 2024 07:04:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2woW7UEchY2IkBVWYzgRK0KWJ4spUtcTxNI2cDq95Ac2i5H9cK+iTpsS+AG/gM2n1vRK6zQ== X-Received: by 2002:a05:620a:1911:b0:789:ea58:d3b1 with SMTP id bj17-20020a05620a191100b00789ea58d3b1mr2518292qkb.4.1710857072670; Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id ye1-20020a05620a3b8100b00789e1874eccsm4708269qkn.41.2024.03.19.07.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 07:04:32 -0700 (PDT) Date: Tue, 19 Mar 2024 10:04:31 -0400 From: Peter Xu To: Muchun Song Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries Message-ID: References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> MIME-Version: 1.0 In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_070436_619638_A8674D96 X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote: > > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, > > > > int pmd_huge(pmd_t pmd) > > { > > - return !pmd_none(pmd) && > > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID; > > + return pmd_leaf(pmd);; > > There is a redundant semicolon in the end. Will touch it up, thanks. PS: This will be dropped as a whole in patch 12. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel