From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zhang Yi <yi.zhang@huaweicloud.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
brauner@kernel.org, david@fromorbit.com, tytso@mit.edu,
jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH v3 3/9] xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset
Date: Tue, 19 Mar 2024 15:54:57 -0700 [thread overview]
Message-ID: <ZfoXwW9G6Lr8vKHZ@infradead.org> (raw)
In-Reply-To: <20240319204552.GG1927156@frogsfrogsfrogs>
> > -xfs_bmapi_convert_delalloc(
> > +static int
>
> static inline?
I'd just leave that to the compiler, no need to second guess all the
decisions.
> Double underscore prefixes read to me like "do this without grabbing
> a lock or a resource", not just one step in a loop.
>
> Would you mind changing it to xfs_bmapi_convert_one_delalloc() ?
> Then the callsite looks like:
Fine with me.
next prev parent reply other threads:[~2024-03-19 22:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 1:10 [PATCH v3 0/9] xfs/iomap: fix non-atomic clone operation and don't update size when zeroing range post eof Zhang Yi
2024-03-19 1:10 ` [PATCH v3 1/9] xfs: match lock mode in xfs_buffered_write_iomap_begin() Zhang Yi
2024-03-19 1:10 ` [PATCH v3 2/9] xfs: make the seq argument to xfs_bmapi_convert_delalloc() optional Zhang Yi
2024-03-19 21:01 ` Darrick J. Wong
2024-03-19 1:10 ` [PATCH v3 3/9] xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset Zhang Yi
2024-03-19 20:45 ` Darrick J. Wong
2024-03-19 22:54 ` Christoph Hellwig [this message]
2024-03-20 1:51 ` Zhang Yi
2024-03-20 1:57 ` Christoph Hellwig
2024-03-19 1:10 ` [PATCH v3 4/9] xfs: convert delayed extents to unwritten when zeroing post eof blocks Zhang Yi
2024-03-19 21:00 ` Darrick J. Wong
2024-03-19 1:10 ` [PATCH v3 5/9] iomap: drop the write failure handles when unsharing and zeroing Zhang Yi
2024-03-19 21:03 ` Darrick J. Wong
2024-03-19 1:10 ` [PATCH v3 6/9] iomap: don't increase i_size if it's not a write operation Zhang Yi
2024-03-19 21:04 ` Darrick J. Wong
2024-03-19 1:11 ` [PATCH v3 7/9] iomap: use a new variable to handle the written bytes in iomap_write_iter() Zhang Yi
2024-03-19 21:05 ` Darrick J. Wong
2024-03-19 1:11 ` [PATCH v3 8/9] iomap: make iomap_write_end() return a boolean Zhang Yi
2024-03-19 21:08 ` Darrick J. Wong
2024-03-19 1:11 ` [PATCH v3 9/9] iomap: do some small logical cleanup in buffered write Zhang Yi
2024-03-19 21:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfoXwW9G6Lr8vKHZ@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.