Re: [PATCH v4 2/2] perf, script, capstone: Add support for -F +brstackdisasm

[Andi Kleen <ak@linux.intel.com>]

On Tue, Mar 19, 2024 at 08:52:33AM +0200, Adrian Hunter wrote:
> On 19/03/24 00:06, Andi Kleen wrote:
> >> Better to factor out a function that does not depend on "sample"
> >> e.g. see fprintf_insn_asm() below.
> > 
> > this doesn't work because it completely ignores the need of the
> > cs_dump_insn caller for the path that i actually need for my feature,
> > which requires to return a string.  I didn't apply it.
> 
> I would probably change the call sites because they already have a
> file descriptor, but output to memory is doable:

> 	FILE *fp = fmemopen(x->out, sizeof(x->out), "w+");

I considered using this at some point, but I'm sure there is some non glibc,
that people build perf with, that doesn't have fmemopen, so I didn't.

Can we just use my version for now and if you prefer more refactor
please submit a follow on cleanup patch?

-andi