From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520E611182; Wed, 20 Mar 2024 03:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710905668; cv=none; b=LN6HyfyPjUJ0TrVyocfGiPFFQu+oPUToUqLGLdxmS6KBSxxU1rTSc4VzDD+5as7XOCaUDaxcjY6j10RQcEgiAMdJs20u53r7oM/RNFuXPL+/8lJCl10oCDykPIn7rtP16+yQ6qrgn5lKDHm7AVcR4jVQU5HzwvCd8kzgiGxCxXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710905668; c=relaxed/simple; bh=kYMcDwEZnVkO/THqgvcJxPhR1j9VPcws4SHdZLgIYnM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ovy/bQY3eh1BiHjHB5Wdxi9AyHSW1kjHJylkJCL4MdltVMQ6Rv+dv1ynDNU/Mr+frMxoqfmgmRIcBwy5IooWUwPNp4MIZ9MjeNnmXU4YvLTHwnnqlQC+0d6eqVthLORc0Omsr5V+1NMjhaz/CuJIDwe2aum0m59/wbAp5rv6r5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=D5ZzB6z5; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="D5ZzB6z5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Fmjl44mehHCSaJsJ049BqzU8nsY14MeWPP13ami+abI=; b=D5ZzB6z5MbJoI6zMuis4f/WsCg 88iH+1ueCQbgpQr1TiFTtRm81M1EIO4/+au/WGmzJpcmSqCFo9EfmHgugNfocoGInkiU0gpH9FpfK uPNaelLOrKVwvSXQDEvisa4gVDqHo5rE1vW4SNU8sy9BLELCk3CFf9OPLzrOeG6nsOu1fvoYl98BV c0iUFXzA9e7fo23DqdYvGWQI8exh8hbKV0n+OvhVIQGMTs9U5pzYwqnyIgr7xy9Fd1wfRSF+ddyJL 6lQNhq97mBnpvm4Dmu0IRPcwSz2ZDu7ofFfE+dsi3MCQgjTpEEBhV+VYDoaRJwg0gZUhvTpB70Op6 K9BDf3rg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmiK-00000003PYS-3S7o; Wed, 20 Mar 2024 03:34:04 +0000 Date: Wed, 20 Mar 2024 03:34:04 +0000 From: Matthew Wilcox To: Jiangfeng Xiao Cc: Kees Cook , linux@armlinux.org.uk, arnd@arndb.de, rmk+kernel@armlinux.org.uk, haibo.li@mediatek.com, angelogioacchino.delregno@collabora.com, amergnat@baylibre.com, akpm@linux-foundation.org, dave.hansen@linux.intel.com, douzhaolei@huawei.com, gustavoars@kernel.org, jpoimboe@kernel.org, kepler.chenxin@huawei.com, kirill.shutemov@linux.intel.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, nixiaoming@huawei.com, peterz@infradead.org, wangbing6@huawei.com, wangfangpeng1@huawei.com, jannh@google.com, David.Laight@aculab.com Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case Message-ID: References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: > The checkpatch.pl script reports the "WARNING: printk() should > include KERN_ facility level" warning. > > That's why I changed printk to pr_warn. > I should change printk to printk(KERN_DEFAULT). No, you should ignore checkpatch. For bonus points, figure out why you should ignore it specifically in this case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2DA7C54E58 for ; Wed, 20 Mar 2024 03:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dOyyvSuZGxHNNkV5R9KEfaEDsxRHeeLlyEHHat5ycSU=; b=sLmbOx0U38zMMX lBsm7ZBDjZFuOXYcWtyzLr6j0z3GX1lEyH87JNuA+sk7N8pJIVcVgMC60gb7inJnjVKwI+9jGrWnx k2BT2YjMPEWfHCs9NYVGFj3b6VO3ZV9P23OvCCcrcxNsGPOFMkRkMmIG5f45XboKUHbYdK5f/xt8Q Gt7MZGf/vIMgOgF3qFnFyOhJG6sJI9CnDzytsxXgm1blrcHAdYt87qDEa9y7jnkCX/5tjhyjE/38b E+GOb3Z9kGSAIEBc+bvrVcE+GMsH8FrunXcolDFfsHZugCGq94gk/7cKfFJffg6N6J0aUqVWuLE4h wed93P1jDtnWs8Jv/IpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmiU-0000000FFag-2Q2j; Wed, 20 Mar 2024 03:34:14 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmiS-0000000FFaJ-3JI7 for linux-arm-kernel@bombadil.infradead.org; Wed, 20 Mar 2024 03:34:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Fmjl44mehHCSaJsJ049BqzU8nsY14MeWPP13ami+abI=; b=D5ZzB6z5MbJoI6zMuis4f/WsCg 88iH+1ueCQbgpQr1TiFTtRm81M1EIO4/+au/WGmzJpcmSqCFo9EfmHgugNfocoGInkiU0gpH9FpfK uPNaelLOrKVwvSXQDEvisa4gVDqHo5rE1vW4SNU8sy9BLELCk3CFf9OPLzrOeG6nsOu1fvoYl98BV c0iUFXzA9e7fo23DqdYvGWQI8exh8hbKV0n+OvhVIQGMTs9U5pzYwqnyIgr7xy9Fd1wfRSF+ddyJL 6lQNhq97mBnpvm4Dmu0IRPcwSz2ZDu7ofFfE+dsi3MCQgjTpEEBhV+VYDoaRJwg0gZUhvTpB70Op6 K9BDf3rg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmiK-00000003PYS-3S7o; Wed, 20 Mar 2024 03:34:04 +0000 Date: Wed, 20 Mar 2024 03:34:04 +0000 From: Matthew Wilcox To: Jiangfeng Xiao Cc: Kees Cook , linux@armlinux.org.uk, arnd@arndb.de, rmk+kernel@armlinux.org.uk, haibo.li@mediatek.com, angelogioacchino.delregno@collabora.com, amergnat@baylibre.com, akpm@linux-foundation.org, dave.hansen@linux.intel.com, douzhaolei@huawei.com, gustavoars@kernel.org, jpoimboe@kernel.org, kepler.chenxin@huawei.com, kirill.shutemov@linux.intel.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, nixiaoming@huawei.com, peterz@infradead.org, wangbing6@huawei.com, wangfangpeng1@huawei.com, jannh@google.com, David.Laight@aculab.com Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case Message-ID: References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: > The checkpatch.pl script reports the "WARNING: printk() should > include KERN_ facility level" warning. > > That's why I changed printk to pr_warn. > I should change printk to printk(KERN_DEFAULT). No, you should ignore checkpatch. For bonus points, figure out why you should ignore it specifically in this case. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel