All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com,
	thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
	farosas@suse.de
Subject: Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below
Date: Wed, 20 Mar 2024 09:15:40 -0400	[thread overview]
Message-ID: <ZfrhfOLpjcOySS__@x1n> (raw)
In-Reply-To: <56ed1452-87ed-4cfb-912f-b15bc74609c1@nutanix.com>

On Wed, Mar 20, 2024 at 10:47:18AM +0530, Het Gala wrote:
> It won't crash IMO, the next function SocketAddress_to_str for a non-socket
> type would return an proper error ?

Both SocketAddress_to_str() and SocketAddress_to_qdict() will crash with a
NULL pointer passed in right now.

Thanks,

-- 
Peter Xu



  reply	other threads:[~2024-03-20 13:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 20:48 [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below Het Gala
2024-03-19 20:48 ` [PATCH 2/2] tests/qtest/migration: Fix typo for vsock in SocketAddress_to_str Het Gala
2024-03-19 21:57   ` Peter Xu
2024-03-19 20:52 ` [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below Het Gala
2024-03-19 21:57 ` Peter Xu
2024-03-20  5:17   ` Het Gala
2024-03-20 13:15     ` Peter Xu [this message]
2024-03-20 13:19     ` Fabiano Rosas
2024-03-20 14:01       ` Het Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfrhfOLpjcOySS__@x1n \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=het.gala@nutanix.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.