From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH 1/1] drm/xe: Use enum instead of hard coding
Date: Thu, 21 Mar 2024 15:41:14 -0400 [thread overview]
Message-ID: <ZfyNWr9TNDxQxs55@intel.com> (raw)
In-Reply-To: <20240321103928.3310349-1-himal.prasad.ghimiray@intel.com>
On Thu, Mar 21, 2024 at 04:09:28PM +0530, Himal Prasad Ghimiray wrote:
> Use DRM_SCHED_PRIORITY_KERNEL instead of hardcoded value 0.
>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
as I told you offline, with the xe_execlist also taken care of:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> Coverity Reports "Parse warning (PW.MIXED_ENUM_TYPE)
> 1. mixed_enum_type enumerated type mixed with another type"
>
> drivers/gpu/drm/xe/xe_gpu_scheduler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gpu_scheduler.h b/drivers/gpu/drm/xe/xe_gpu_scheduler.h
> index 10c6bb9c9386..1f712f4fc76a 100644
> --- a/drivers/gpu/drm/xe/xe_gpu_scheduler.h
> +++ b/drivers/gpu/drm/xe/xe_gpu_scheduler.h
> @@ -63,7 +63,7 @@ static inline int
> xe_sched_entity_init(struct xe_sched_entity *entity,
> struct xe_gpu_scheduler *sched)
> {
> - return drm_sched_entity_init(entity, 0,
> + return drm_sched_entity_init(entity, DRM_SCHED_PRIORITY_KERNEL,
> (struct drm_gpu_scheduler **)&sched,
> 1, NULL);
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2024-03-21 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 10:39 [PATCH 1/1] drm/xe: Use enum instead of hard coding Himal Prasad Ghimiray
2024-03-21 10:30 ` ✓ CI.Patch_applied: success for series starting with [1/1] " Patchwork
2024-03-21 10:30 ` ✓ CI.checkpatch: " Patchwork
2024-03-21 10:31 ` ✓ CI.KUnit: " Patchwork
2024-03-21 10:42 ` ✓ CI.Build: " Patchwork
2024-03-21 10:47 ` ✓ CI.Hooks: " Patchwork
2024-03-21 10:48 ` ✓ CI.checksparse: " Patchwork
2024-03-21 11:14 ` ✓ CI.BAT: " Patchwork
2024-03-21 19:41 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfyNWr9TNDxQxs55@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.