From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 580ECC6FD1F for ; Fri, 22 Mar 2024 00:30:28 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rnSnj-000067-68; Fri, 22 Mar 2024 00:30:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rnSnh-00005q-S9 for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Mar 2024 00:30:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P6cEpJDtO0wxLDIKQ4vPJKsAoswjkpDV/hIdCUeIaVU=; b=lYgmwDmrN2M2tzv6yY2ScOQavB 1EPDVLtIITgW5mwWhe6nAsFPjMJUULzzjUc0HCxWAc6zCTqQLhb7XFIz+Vt06yQLdSHiWKRB+/L0i vLn98Ng3Bal6Ov7NdQcYZNy6gxvfD9VRvae2Uw2Nfjp1EGkzVftpU/DWUQzoYJnHBXoc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P6cEpJDtO0wxLDIKQ4vPJKsAoswjkpDV/hIdCUeIaVU=; b=a8PfBTpCEaHDyyfWtZEdrKk1bY QqPLwjhEC2GFsaoH2BotN563MmkYpvzW5GOF0/7rTs5YyqREEcnolAxzCiGk2Qh3F+eFX06Bcsd0r R3ziCvyGvSXnOmfFlmoj7FGiXCEQmiAlKOYItxVo1C3hYJRlJOhAizRl5R5fgVTY66H8=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rnSnh-0004BH-V6 for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Mar 2024 00:30:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 91AAE61326; Fri, 22 Mar 2024 00:30:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10E89C433C7; Fri, 22 Mar 2024 00:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711067415; bh=2oS5/+OU7q2OVdHinwRnMsJrZA2/4MZ9QA2WdIlydEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ux/nyWo9nNAkSf12AXlufQGQjR6V7ttQc9xl9gx/p5iTArqdmZXMBGtPgW8LmpqcJ QIWqdxP1xrH5fRJExj42Go19TsNTxsKnB9AIRR5PCqlNICsGBz6jCu3cd2Bf7hRV9k ERf8kU4Nx3BFNcHF8u94UrUcAyD4ZNebUcWKdJxCd0lwA6fQMObMjvneicaGrv25an oY44zmBPfcHaeAFUGHdH1NsNQqbQboZKYdm6HaRvR6wVuQ+kid18nZzsf4QbJvJsMS Z+ObLWcyu25o5ufHXi32nlxr9HqVemAB26AE+MdcJvdQVvMUfBxLGwiHhZDIFHc2qr UsDG6VlfVFZeQ== Date: Thu, 21 Mar 2024 17:30:13 -0700 From: Jaegeuk Kim To: Light Hsieh =?utf-8?B?KOisneaYjueHiCk=?= Message-ID: References: <0000000000000b4e27060ef8694c@google.com> <20240115120535.850-1-hdanton@sina.com> <4bbab168407600a07e1a0921a1569c96e4a1df31.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1rnSnh-0004BH-V6 Subject: Re: [f2fs-dev] =?utf-8?b?5Zue6KaGOiDlm57opoY6IGYyZnMgRjJGU19JT0Nf?= =?utf-8?q?SHUTDOWN_hang_issue?= X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-fsdevel@vger.kernel.org" , Chun-Hung Wu =?utf-8?B?KOW3q+mnv+Wujyk=?= , "linux-f2fs-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Ed Tsai =?utf-8?B?KOiUoeWul+i7kik=?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDMvMjEsIExpZ2h0IEhzaWVoICjorJ3mmI7nh4gpIHdyb3RlOgo+IERvIHlvdSBtZWFuOgo+ IAo+ICvigILigILigILigILigILigILigILigILigILigILigIIvKiBBdm9pZCB0aGUgZGVhZGxv Y2sgZnJvbSBGMkZTX0dPSU5HX0RPV05fTk9TWU5DLiAqLwo+ICvigILigILigILigILigILigILi gILigILigILigILigIJpZiAoIXNiX3N0YXJ0X2ludHdyaXRlX3RyeWxvY2soc2JpLT5zYikpCj4g K+KAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAguKAgmNvbnRp bnVlOwo+IAo+IEFmdGVyIGZhaWx1cmUgb2YgdHJ5bG9jaywgIHRoZSAnY29udGludWUnICBtYWtl IGNvZGUgZmxvdyBnb3RvIHRoZSBsaW5lOgo+IOKAguKAguKAguKAguKAguKAgn0gd2hpbGUgKCFr dGhyZWFkX3Nob3VsZF9zdG9wKCkpOwo+IFNpbmNlICBrdGhyYWRfc2hvdWxkX3N0b3AoKSBpcyB0 cnVlIG5vdywgc28gdGhlIGlzc3VlX2Rpc2NhcmRfdGhyZWFkIHdpbGwgZW5kPwoKWWVzLCBidXQg bm93IEknbSBjb25mdXNlZCB3aG8gaXMgdGFraW5nIHdyaXRlX3NlbS4gOigKCj4gCj4gTGlnaHQK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IOWvhOS7tuiAhTogSmFlZ2V1ayBL aW0gPGphZWdldWtAa2VybmVsLm9yZz4KPiDlr4Tku7bml6XmnJ86IDIwMjTlubQz5pyIMjHml6Ug 5LiK5Y2IIDA4OjM5Cj4g5pS25Lu26ICFOiBMaWdodCBIc2llaCAo6Kyd5piO54eIKSA8TGlnaHQu SHNpZWhAbWVkaWF0ZWsuY29tPgo+IOWJr+acrDogRWQgVHNhaSAo6JSh5a6X6LuSKSA8RWQuVHNh aUBtZWRpYXRlay5jb20+OyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIDxsaW51eC1rZXJu ZWxAdmdlci5rZXJuZWwub3JnPjsgbGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5u ZXQgPGxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0PjsgbGludXgtZnNkZXZl bEB2Z2VyLmtlcm5lbC5vcmcgPGxpbnV4LWZzZGV2ZWxAdmdlci5rZXJuZWwub3JnPjsgQ2h1bi1I dW5nIFd1ICjlt6vpp7/lro8pIDxDaHVuLWh1bmcuV3VAbWVkaWF0ZWsuY29tPgo+IOS4u+aXqDog UmU6IOWbnuimhjogZjJmcyBGMkZTX0lPQ19TSFVURE9XTiBoYW5nIGlzc3VlCj4gCj4gCj4gRXh0 ZXJuYWwgZW1haWwgOiBQbGVhc2UgZG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVu dHMgdW50aWwgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBvciB0aGUgY29udGVudC4KPiAK PiAKPiBPbiAwMy8yMCwgTGlnaHQgSHNpZWggKOisneaYjueHiCkgd3JvdGU6Cj4gPiBPbiAyMDI0 LzMvMjAgODoxNCwgSmFlZ2V1ayBLaW0gd3JvdGU6Cj4gPiA+IGYyZnNfaW9jX3NodXRkb3duKEYy RlNfR09JTkdfRE9XTl9OT1NZTkMpICBpc3N1ZV9kaXNjYXJkX3RocmVhZAo+ID4gPiAgIC0gbW50 X3dhbnRfd3JpdGVfZmlsZSgpCj4gPiA+ICAgICAtIHNiX3N0YXJ0X3dyaXRlKFNCX0ZSRUVaRV9X UklURSkKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC0gc2Jfc3RhcnRfaW50d3JpdGUoU0JfRlJFRVpFX0ZTKTsKPiA+ID4gICAtIGYyZnNfc3RvcF9j aGVja3BvaW50KHNiaSwgZmFsc2UsICAgICAgICAgICAgOiB3YWl0aW5nCj4gPiA+ICAgICAgU1RP UF9DUF9SRUFTT05fU0hVVERPV04pOwo+ID4gPiAgIC0gZjJmc19zdG9wX2Rpc2NhcmRfdGhyZWFk KHNiaSk7Cj4gPiA+ICAgICAtIGt0aHJlYWRfc3RvcCgpCj4gPiA+ICAgICAgIDogd2FpdGluZwo+ ID4gPgo+ID4gPiAgIC0gbW50X2Ryb3Bfd3JpdGVfZmlsZShmaWxwKTsKPiA+ID4KPiA+ID4gU2ln bmVkLW9mZi1ieTogSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9yZz4KPiA+Cj4gPiBUaGUg Y2FzZSBJIGVuY291bnRlciBpcyBmMmZzX2ljX3NodXRkb3duIHdpdGggYXJnICBGMkZTX0dPSU5H X0RPV05fRlVMTFNZTkMsIG5vdCAgRjJGU19HT0lOR19ET1dOX05PU1lOQy4KPiA+Cj4gPiBPciB5 b3UgYXJlIG1lYW5pbmcgdGhhdDogYmVzaWRlcyB0aGUga2VybmVsIHBhdGNoLCBJIG5lZWQgdG8g Y2hhbmdlIHRoZSBpbnZva2VkIEYyRlNfSU9DX1NIVVRET1dOIHRvIHVzZSBhcmcgRjJGU19HT0lO R19ET1dOX05PU1lOQz8KPiAKPiBJIHRoaW5rIHRoaXMgcGF0Y2ggYWxzbyBhZGRyZXNzZXMgeW91 ciBjYXNlIGJ5IHVzaW5nIHRyeWxvY2suCj4gCj4gPgo+ID4KPiA+Cj4gCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWls aW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9s aXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0621854; Fri, 22 Mar 2024 00:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711067415; cv=none; b=AerLcebugvLt3ReTGCrGDhoHn2OrigLhlYT1owvoxzPd/SgXt1iGJoPnmV4oxAOblMvwnRo+uboZ1al3stVNrLV04nlGF6UbPMiteP1rnyKB4h23Lg2f2B1ieWo8ImhHjXUAGBKC8R6nK2xVCf365ulD+hUIfXKLa7UvCUmdIhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711067415; c=relaxed/simple; bh=2oS5/+OU7q2OVdHinwRnMsJrZA2/4MZ9QA2WdIlydEA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ct2HSBNxpMBJOqj5ZubH71ffjM8UHl1JZgaIA4mPi1kLnp/5E1IDxVWfWc/zODrxJF87NJH060zgrFnefVXLDkCXK3qdZEUvBpGzzY6VDt/JLyGCnbbrswr+HIrzJ6O1tNE5UpSf0Q5qZGwRhgPOaQ8fm2J5CvcQQBsFzX7i7As= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ux/nyWo9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ux/nyWo9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10E89C433C7; Fri, 22 Mar 2024 00:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711067415; bh=2oS5/+OU7q2OVdHinwRnMsJrZA2/4MZ9QA2WdIlydEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ux/nyWo9nNAkSf12AXlufQGQjR6V7ttQc9xl9gx/p5iTArqdmZXMBGtPgW8LmpqcJ QIWqdxP1xrH5fRJExj42Go19TsNTxsKnB9AIRR5PCqlNICsGBz6jCu3cd2Bf7hRV9k ERf8kU4Nx3BFNcHF8u94UrUcAyD4ZNebUcWKdJxCd0lwA6fQMObMjvneicaGrv25an oY44zmBPfcHaeAFUGHdH1NsNQqbQboZKYdm6HaRvR6wVuQ+kid18nZzsf4QbJvJsMS Z+ObLWcyu25o5ufHXi32nlxr9HqVemAB26AE+MdcJvdQVvMUfBxLGwiHhZDIFHc2qr UsDG6VlfVFZeQ== Date: Thu, 21 Mar 2024 17:30:13 -0700 From: Jaegeuk Kim To: Light Hsieh =?utf-8?B?KOisneaYjueHiCk=?= Cc: Ed Tsai =?utf-8?B?KOiUoeWul+i7kik=?= , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-fsdevel@vger.kernel.org" , Chun-Hung Wu =?utf-8?B?KOW3q+mnv+Wujyk=?= Subject: Re: =?utf-8?B?5Zue6KaGOiDlm57opoY=?= =?utf-8?Q?=3A?= f2fs F2FS_IOC_SHUTDOWN hang issue Message-ID: References: <0000000000000b4e27060ef8694c@google.com> <20240115120535.850-1-hdanton@sina.com> <4bbab168407600a07e1a0921a1569c96e4a1df31.camel@mediatek.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 03/21, Light Hsieh (謝明燈) wrote: > Do you mean: > > +           /* Avoid the deadlock from F2FS_GOING_DOWN_NOSYNC. */ > +           if (!sb_start_intwrite_trylock(sbi->sb)) > +                 continue; > > After failure of trylock, the 'continue' make code flow goto the line: >       } while (!kthread_should_stop()); > Since kthrad_should_stop() is true now, so the issue_discard_thread will end? Yes, but now I'm confused who is taking write_sem. :( > > Light > ________________________________ > 寄件者: Jaegeuk Kim > 寄件日期: 2024年3月21日 上午 08:39 > 收件者: Light Hsieh (謝明燈) > 副本: Ed Tsai (蔡宗軒) ; linux-kernel@vger.kernel.org ; linux-f2fs-devel@lists.sourceforge.net ; linux-fsdevel@vger.kernel.org ; Chun-Hung Wu (巫駿宏) > 主旨: Re: 回覆: f2fs F2FS_IOC_SHUTDOWN hang issue > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > On 03/20, Light Hsieh (謝明燈) wrote: > > On 2024/3/20 8:14, Jaegeuk Kim wrote: > > > f2fs_ioc_shutdown(F2FS_GOING_DOWN_NOSYNC) issue_discard_thread > > > - mnt_want_write_file() > > > - sb_start_write(SB_FREEZE_WRITE) > > > - sb_start_intwrite(SB_FREEZE_FS); > > > - f2fs_stop_checkpoint(sbi, false, : waiting > > > STOP_CP_REASON_SHUTDOWN); > > > - f2fs_stop_discard_thread(sbi); > > > - kthread_stop() > > > : waiting > > > > > > - mnt_drop_write_file(filp); > > > > > > Signed-off-by: Jaegeuk Kim > > > > The case I encounter is f2fs_ic_shutdown with arg F2FS_GOING_DOWN_FULLSYNC, not F2FS_GOING_DOWN_NOSYNC. > > > > Or you are meaning that: besides the kernel patch, I need to change the invoked F2FS_IOC_SHUTDOWN to use arg F2FS_GOING_DOWN_NOSYNC? > > I think this patch also addresses your case by using trylock. > > > > > > > >