From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH] block: fail unaligned bio from submit_bio_noacct()
Date: Thu, 21 Mar 2024 17:31:45 -0700 [thread overview]
Message-ID: <ZfzRceN0-_ij6wcP@infradead.org> (raw)
In-Reply-To: <1a0ac357-49e4-41fa-b0c3-f038ec995a00@kernel.dk>
On Thu, Mar 21, 2024 at 04:50:44PM -0600, Jens Axboe wrote:
> On 3/21/24 4:09 PM, Christoph Hellwig wrote:
> > On Thu, Mar 21, 2024 at 11:09:25AM -0600, Jens Axboe wrote:
> >> Where is this IO coming from? The normal block level dio has checks. And
> >> in fact they are expensive...
> >
> > How is this expensive when we need the bio cache lines all the time
> > during I/O submission which follows instantly?
>
> This part isn't expensive, it's the general dio checks that are which
> check memory alignment as well.
Well, the memory alignment has to walk over the whole iterator, so it
definitively is way more expensive.
next prev parent reply other threads:[~2024-03-22 0:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 13:16 [PATCH] block: fail unaligned bio from submit_bio_noacct() Ming Lei
2024-03-21 15:14 ` Bart Van Assche
2024-03-21 15:18 ` Ming Lei
2024-03-21 15:43 ` Mike Snitzer
2024-03-21 17:01 ` Mikulas Patocka
2024-03-21 22:07 ` Christoph Hellwig
2024-03-22 2:08 ` Ming Lei
2024-03-22 2:39 ` Keith Busch
2024-03-24 8:02 ` Ming Lei
2024-03-22 10:16 ` Mikulas Patocka
2024-03-21 17:09 ` [PATCH] " Jens Axboe
2024-03-21 22:09 ` Christoph Hellwig
2024-03-21 22:50 ` Jens Axboe
2024-03-22 0:31 ` Christoph Hellwig [this message]
2024-03-22 1:21 ` Ming Lei
2024-03-21 22:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfzRceN0-_ij6wcP@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.