Re: [Buildroot] [PATCH 3/3] package/lua-lgdbm: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fraçois, All

On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
[--SNIP--]
> diff --git a/package/lua-lgdbm/Config.in b/package/lua-lgdbm/Config.in
> new file mode 100644
> index 0000000000..ac5c64cc79
> --- /dev/null
> +++ b/package/lua-lgdbm/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_LUA_LGDBM
> +	bool "lua-lgdbm"
> +	depends on BR2_PACKAGE_LUA_5_3 || BR2_PACKAGE_LUA_5_4
> +	select BR2_PACKAGE_GDBM

You need to propagate the dependencies of gdbm here: MMU and WCHAR.

> new file mode 100644
> index 0000000000..b21565fb6e
> --- /dev/null
> +++ b/support/testing/tests/package/test_lua_lgdbm.py
> @@ -0,0 +1,14 @@
> +from tests.package.test_lua import TestLuaBase
> +
> +
> +class TestLuaLgdbm(TestLuaBase):
> +    config = TestLuaBase.config + \
> +        """
> +        BR2_PACKAGE_LUA=y
> +        BR2_PACKAGE_LUA_LGDBM=y
> +        """
> +
> +    def test_run(self):
> +        self.login()
> +        self.module_test("gdbm")
> +

Runtime test, wee! :-)

But:

    $ ./utils/docker-run make check-package
    support/testing/tests/package/test_lua_lgdbm.py:0: run 'flake8' and fix the warnings

    $ ./utils/docker-run python3 -m flake8 support/testing/tests/package/test_lua_lgdbm.py
    support/testing/tests/package/test_lua_lgdbm.py:14:1: W391 blank line at end of file

Applied to master, with the gdbm dependencies propagated and the
check-package/flake8 issue fixed, thanks!

Regards,
Yann E. MORIN.

> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot