All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Javier Pello <devel@otheo.eu>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/1] x86/mm/pae: Align up pteval_t, pmdval_t and pudval_t to avoid split locks
Date: Thu, 4 Apr 2024 09:56:54 +0200	[thread overview]
Message-ID: <Zg5dRkSncIeHsP0H@gmail.com> (raw)
In-Reply-To: <CAMzpN2iK0+okEKnX_EgfmdLSg9Gze_BVO4fEG3TBuzwD-yj8bA@mail.gmail.com>


* Brian Gerst <brgerst@gmail.com> wrote:

> > > It's not a technical reason.  It's a practical one: I don't want 
> > > to spend time reviewing the fixes and dealing with the fallout 
> > > and regressions that the fixes might cause.
> >
> > Yeah, so it's an indirect technical argument: fixes *with 
> > tradeoffs* like this one have a future maintenance & robustness 
> > cost. Fixes without tradeoffs are fine of course.
> 
> What tradeoffs are there with this patch?  This would not affect the 
> page tables, since those are already properly aligned.  Forcing 
> alignment of stack variables is only a problem if it tickles a 
> compiler bug.

It creates extra constraints on stack layout that wasn't there before, 
so it can only be an invariant if the compiler can reorder variables, 
or make the stack layout worse (introducing more holes).

Thanks,

	Ingo

  reply	other threads:[~2024-04-04  7:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 16:54 [PATCH 0/1] Split lock detected in kernel mode on x86-32 with PAE Javier Pello
2024-04-01 16:57 ` [PATCH 1/1] x86/mm/pae: Align up pteval_t, pmdval_t and pudval_t to avoid split locks Javier Pello
2024-04-01 17:56   ` Dave Hansen
2024-04-02 17:23     ` Javier Pello
2024-04-02 17:43       ` Dave Hansen
2024-04-03  7:57         ` Ingo Molnar
2024-04-03 11:08           ` Brian Gerst
2024-04-04  7:56             ` Ingo Molnar [this message]
2024-04-04 15:36               ` Brian Gerst
2024-04-04 16:29                 ` Dave Hansen
2024-04-03 15:54         ` Javier Pello
2024-04-03 15:58           ` Dave Hansen
2024-04-04 15:26             ` Sean Christopherson
2024-04-04 18:31               ` Dave Hansen
2024-04-04 21:55                 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zg5dRkSncIeHsP0H@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=devel@otheo.eu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.