From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02FE9CD1296 for ; Thu, 4 Apr 2024 12:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=//A0ELfShQ9ivR0EdZ+Et9zjAEeN8oYb/8JUlJYLMRI=; b=T5UfO5oUuSMcCE LHOJZsFpBvfiLDyaM8fXgILHfBQcxaAAmY+8SzW4iGKuLjYaOhVJ/UNKWkTqQqT7idOhqM3ENwS/9 21xv3xEduk35F8xMYAGNAuvRcKaRveNhWQ6a1gbYwjuzSWHkM1yhyv17ISt30sLKSsHaCollveV+/ 9XSiBviBz8TtsOZ8RAsyKAeOYrIhvDpz0zwx6n+G7bOiK9mVb02ZBbZ5ng5o3koqhqnGZSfZLGaDF 4b3aUdmJlXMCq/3XLhNgBjf/vXLrVOGc05+IvMq0A/Afxr61Js/KCEfwGWKCGqkRhmgOXvO4Qm3Rf bCHDLZIm7mILxDIMuzAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLm6-00000002UiD-1us9; Thu, 04 Apr 2024 12:00:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLm2-00000002Uen-2SSb for linux-riscv@lists.infradead.org; Thu, 04 Apr 2024 12:00:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712232053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=ZJQO1LKQ4/YdGI4ahHtm0KHDzGiPpcFyi0D+eNTsS8jSj7xNYjiSNbeXK+IrEphm3v9lbN fwLRrKlox7Xa/HcduDl+D0NX1FxoGzfU4qYy2Hf5sd12bU+m543M7zAnw9W9k8zMs18K0d xgXaxFZjgJc/Gj5uUT2nryrwDpbzG/k= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-KGjhnxCEMtW9rlEmuRp-8g-1; Thu, 04 Apr 2024 08:00:51 -0400 X-MC-Unique: KGjhnxCEMtW9rlEmuRp-8g-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6992d40ea4aso1903716d6.1 for ; Thu, 04 Apr 2024 05:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712232051; x=1712836851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=HNQ3B8yxZ4XyX5o+vXpnJGKYyanTN9ccY8pjC3cZpDOf0kq355gTIMnlCRT2C8Drzw YtHmPVOy9Tjq96DUMqlp4fDJhtfJ3eWNvmtBqXsaol+pggjs+WDdlkO7cqRG08hUocE3 sqRtrFhoHEijrlqClzNfIMh/VTHgyEnN208aXGhtyiHyIIdOkTPTON+PYiWQ9+LGk50s Ax9kIb2lUi30TcqeuEpqhsLVbHyrXwNeZfzOAN/HhJewY+4FeMRqoSNVMu1cQBjEB5zF AhBkzQIVDHzo2GSjRKoVkoLOo5/yslNe50TQM6g0nuG8HsMhvrfrr4CMfqsPn6XWnQD0 3g2Q== X-Forwarded-Encrypted: i=1; AJvYcCVFBebCYDBpZdk0jSNOeOBRdZ8/zcnUZpSaGuqkLayivkuATggdin1OL5F1iC+R1lOJWMFzF8svz8ETVfLlAcx7AsD5dbJM/ar/tPGfvQoF X-Gm-Message-State: AOJu0YxnicHsApW8cFt9yO9d2LrhPd/WqlEC9VuI3ukz3WXqDB7pbLDu 6sFaLMSu7D6og8fcORbhC6pHo2JEoa9xvR49XC6Uucn49oOxs4JLaFSpBzDhPZhDJccNVsop8+F nSdKTM6tFOyaLJsNwCbclvJyOlkNmDrMrxKua8I0DWOHB8RpxvtUkB1xt7wshtVr/mw== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122674qvb.0.1712232050895; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMCWtQWiLpesBQTQo5kp7GWlhuKWfgLgdLeENDjrnl6Gj4+sgwXTUEXT7yElLHvch56DwpwQ== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122629qvb.0.1712232050343; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id jf14-20020a0562142a4e00b006987021a724sm7171209qvb.118.2024.04.04.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Date: Thu, 4 Apr 2024 08:00:47 -0400 From: Peter Xu To: Jason Gunthorpe Cc: Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Mike Rapoport , Axel Rasmussen , Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> <20240403120841.GB1723999@nvidia.com> <20240404112404.GG1723999@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240404112404.GG1723999@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_050054_740643_047B220E X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > > > > Yes, that sounds better too to me, however it means we may also risk other > > archs that can fail another defconfig build.. and I worry I bring trouble > > to multiple such cases. Fundamentally it's indeed my patch that broke > > those builds, so I still sent the change and leave that for arch developers > > to decide the best for the archs. > > But your change causes silent data corruption if the code path is > run.. I think we are overall better to wade through the compile time > bugs from linux-next. Honestly if there were alot then I'd think there > would be more complaints already. > > Maybe it should just be a seperate step from this series. Right, that'll be imho better to be done separate, as I think we'd better consolidate the code. One thing I don't worry is the warning would cause anything real to fail; I don't yet expect any arch that will not define pud_pfn when it needs it.. so it can mean all of the build errors may not cause real benefits as of now. But I agree with you we'd better have it. I'll take a todo and I'll try to add it back after all these fallouts. With my cross build chains now it shouldn't be hard, just take some time to revisit each arch. Thanks, -- Peter Xu _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A9DA84FD8 for ; Thu, 4 Apr 2024 12:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712232055; cv=none; b=q9FGdCP0EhscyrWPcvAwTWdSFl9vsUSq2/Hd6d59umwjy7anD5J2EZM1BpoOGezNg64yz8gVtd7+rU5i46+A9+c0F3vVvjf97URb11DNxRXRaEuNOsx5X0kyILgpuuACQvG2zESnQ+NbkKx7/N03VegmJFWlTsGkTkRMJ+DWzrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712232055; c=relaxed/simple; bh=GZ85xvnSn7AShFQ6AU6qZKZ/QUsMQjF1VcpNN5Uuyx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=fp7Uw05dbjrXETny18OTumzjWfmj4UPL/hj++WFMwT7uyAFGJSp6NRTNEzobjzIGWbzWujkghhpFkfw214Iq7WivzMmnXo5iKAQlxdFIsm7kEZCHWV1CuBPodUaGUNvZ/Na3VYdSRE66dMPkF9N5PYeWyXvqEZpu2v8PbkIYFwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZJQO1LKQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZJQO1LKQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712232053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=ZJQO1LKQ4/YdGI4ahHtm0KHDzGiPpcFyi0D+eNTsS8jSj7xNYjiSNbeXK+IrEphm3v9lbN fwLRrKlox7Xa/HcduDl+D0NX1FxoGzfU4qYy2Hf5sd12bU+m543M7zAnw9W9k8zMs18K0d xgXaxFZjgJc/Gj5uUT2nryrwDpbzG/k= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-0hpoAETWPNWhqW30fR8aig-1; Thu, 04 Apr 2024 08:00:51 -0400 X-MC-Unique: 0hpoAETWPNWhqW30fR8aig-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6992d40ea4aso1903706d6.1 for ; Thu, 04 Apr 2024 05:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712232051; x=1712836851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=QCQjXu3PNteRqkiC1prM6c+Ls7qQimLJv4VjXKhcHk0HcARh/UV4Ee7n50PZtLYQUA /2pmaht5kH7XRA4xrZ0kUgv1q+oYe5LnZeL10SK7l9bo8URQw7Vh7GrQjcqFMBY36a/l yzpb0Jbn+mlT7dlRwKNzqHCdQE/jNqkWC6COxDbUShIPcp40o7nlfnV5UU7cGWF5TzxX HP+OZT9rcYk0ZMCkmgO6jtE2RxXckAn0YpyFs9ADig+1fQ3nbFjakGMqzIZAyqilxN7T ELHI1+6YAKLjPNUiZTjlb2eKpXT12RSEEJtnUIq1b0n/8sIPcsZ+S+pfcup0x4Kk7Toz cDPw== X-Forwarded-Encrypted: i=1; AJvYcCVV7L3BFCT9ry+ykE6mCSIpBcmq3xQ6yyJqrmddOifCNWeCgP7MryGqOcSKs9ZpByO4SBNTHBoUyfIa9iX4+ffH4/L4LphWox6J X-Gm-Message-State: AOJu0YyuY6uy/9/kvx6D6bECowCf3vvvkBdRYP/FfMkcNm1rjsE0kwOB bj1bxlF8//zFfvCm1NNfjKHO0mcpE806c4I6tIbQfq6aD/eKmuayCtCkbntY21JU+XBBKyPqgck OmaLNLH7fh6G3UzjnRn8DOl3MknbnVDDavc7IofBUYp3aMVjMxBUFelbjfw== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122695qvb.0.1712232050940; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMCWtQWiLpesBQTQo5kp7GWlhuKWfgLgdLeENDjrnl6Gj4+sgwXTUEXT7yElLHvch56DwpwQ== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122629qvb.0.1712232050343; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id jf14-20020a0562142a4e00b006987021a724sm7171209qvb.118.2024.04.04.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Date: Thu, 4 Apr 2024 08:00:47 -0400 From: Peter Xu To: Jason Gunthorpe Cc: Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Mike Rapoport , Axel Rasmussen , Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> <20240403120841.GB1723999@nvidia.com> <20240404112404.GG1723999@nvidia.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240404112404.GG1723999@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > > > > Yes, that sounds better too to me, however it means we may also risk other > > archs that can fail another defconfig build.. and I worry I bring trouble > > to multiple such cases. Fundamentally it's indeed my patch that broke > > those builds, so I still sent the change and leave that for arch developers > > to decide the best for the archs. > > But your change causes silent data corruption if the code path is > run.. I think we are overall better to wade through the compile time > bugs from linux-next. Honestly if there were alot then I'd think there > would be more complaints already. > > Maybe it should just be a seperate step from this series. Right, that'll be imho better to be done separate, as I think we'd better consolidate the code. One thing I don't worry is the warning would cause anything real to fail; I don't yet expect any arch that will not define pud_pfn when it needs it.. so it can mean all of the build errors may not cause real benefits as of now. But I agree with you we'd better have it. I'll take a todo and I'll try to add it back after all these fallouts. With my cross build chains now it shouldn't be hard, just take some time to revisit each arch. Thanks, -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBCB8CD1292 for ; Thu, 4 Apr 2024 12:01:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTcIfipk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTcIfipk; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V9KwT1hy3z3vgs for ; Thu, 4 Apr 2024 23:01:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTcIfipk; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTcIfipk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V9Kvc0Qhvz3vdr for ; Thu, 4 Apr 2024 23:00:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712232054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=PTcIfipkFMzHFYd7yVMhlS2XO+r6De9ENvqodeUNcp4851UX0N+SJVG7GkqCCD6WcblYs7 zfc8Pg+K83BxtJMnn/ABGm10ahlZq7AzPZbE6DUa2ANpVxHFjSDe7NrkQfy9mteGwcOqBK vuaHe+Fbcf8SIV3OygN/S1PTM41MFgY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712232054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=PTcIfipkFMzHFYd7yVMhlS2XO+r6De9ENvqodeUNcp4851UX0N+SJVG7GkqCCD6WcblYs7 zfc8Pg+K83BxtJMnn/ABGm10ahlZq7AzPZbE6DUa2ANpVxHFjSDe7NrkQfy9mteGwcOqBK vuaHe+Fbcf8SIV3OygN/S1PTM41MFgY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-CbgIIuSeOKqUeJwYZOFB2Q-1; Thu, 04 Apr 2024 08:00:51 -0400 X-MC-Unique: CbgIIuSeOKqUeJwYZOFB2Q-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-69939cb15faso101476d6.0 for ; Thu, 04 Apr 2024 05:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712232051; x=1712836851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=Ermf+Qfbt6PIWvgZcvXtxbaKpxpvCjD+7B4a4kQdRBPeTZYxETPlezIBixS3oqS46e qhd6UUQWrtpPfbObsd0ThIBlYUHefKjKA8n3Ez7i6z9aQ4KJJN++YW/5nO6PeS8JAMUN +YEqliH2O9kTEG/d+istHsG05tq0W7pg84niFekEshvp3j4cyl32DPtuPFHq307ofP33 tPWZ+c4ArlMDimvGxunX0AojVtR5onxDGSVrTKlQFZtp8R/r+ARBvulAusw2fItp1lA1 eWgR8/1zwW8e50dwwWUF0rl/Y++2beGZfIC72qitzl3kX8fKixVtVLzCwiHpZTwbObAv QaGg== X-Forwarded-Encrypted: i=1; AJvYcCWpOPvlehyCriZvAHK0pavcAUNzkY7g/4YC0Zr/rb18QHoBHkh3gEcIdbQNw4yaIT+7/7X8qczLH6/wCTFz1SZjeA0PqSlp9OefWqrvOg== X-Gm-Message-State: AOJu0Ywa2i8lXjwmY512e+PNjDT0kV5z/ZmZEWjMc5dBjXhp6IDSEXzR XHH1PKo6Zt/yneJEy8ybG3CoLMgmSdoa6L+i4//a+Y7Oxj2GB6bquukcvZc0+Q3KD886m8QFtti q1cMvTCxH5PNo8C5kytD+JcVIbQ3b+tcRaZH7ktEZGfNE4GfVOYyP6Ka5UkKovuU= X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122680qvb.0.1712232050901; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMCWtQWiLpesBQTQo5kp7GWlhuKWfgLgdLeENDjrnl6Gj4+sgwXTUEXT7yElLHvch56DwpwQ== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122629qvb.0.1712232050343; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id jf14-20020a0562142a4e00b006987021a724sm7171209qvb.118.2024.04.04.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Date: Thu, 4 Apr 2024 08:00:47 -0400 From: Peter Xu To: Jason Gunthorpe Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> <20240403120841.GB1723999@nvidia.com> <20240404112404.GG1723999@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240404112404.GG1723999@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, WANG Xuerui , Andrea Arcangeli , "Aneesh Kumar K . V" , Huacai Chen , Christoph Hellwig , Vlastimil Babka , Axel Rasmussen , Rik van Riel , John Hubbard , Nathan Chancellor , loongarch@lists.linux.dev, "Kirill A . Shutemov" , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , Muchun Song , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > > > > Yes, that sounds better too to me, however it means we may also risk other > > archs that can fail another defconfig build.. and I worry I bring trouble > > to multiple such cases. Fundamentally it's indeed my patch that broke > > those builds, so I still sent the change and leave that for arch developers > > to decide the best for the archs. > > But your change causes silent data corruption if the code path is > run.. I think we are overall better to wade through the compile time > bugs from linux-next. Honestly if there were alot then I'd think there > would be more complaints already. > > Maybe it should just be a seperate step from this series. Right, that'll be imho better to be done separate, as I think we'd better consolidate the code. One thing I don't worry is the warning would cause anything real to fail; I don't yet expect any arch that will not define pud_pfn when it needs it.. so it can mean all of the build errors may not cause real benefits as of now. But I agree with you we'd better have it. I'll take a todo and I'll try to add it back after all these fallouts. With my cross build chains now it shouldn't be hard, just take some time to revisit each arch. Thanks, -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB4EDCD1296 for ; Thu, 4 Apr 2024 12:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MieR97Fr72TystZSEmedOT1eAOOVlMGdSG8h4BqAN3o=; b=oMlINgZ8l7MUA4 Uhimg0/CZGFRWUsbRyCUVnt80muFWkrwYN0FX3O1fWn2j+Owta0F51iJCdQPxnqicrssJ4nACEzmu BjZY7aifNUM+IO/t/9wTncKjLDT/By3nxbloU1Ygj8qT4uLo1/2KT33knE4ZncEljn2nnx/Xn8gtH cF2Fa3yXEb5Pq7XjqDHk50BiEqTTTdUESS/6fMHVGJcTKcAIREKw9F2OY/GMc4AjYB7jko8sOSGHZ duKyEEyca1++xBhOl5mlbu6OOwCyKy8sJF3q83feZ4N0zB98yBZpyqD45UjOLScS3tkEfaFmzY+8R lqAV7/2xHyaTAeb9HuZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLm5-00000002UhJ-1ejG; Thu, 04 Apr 2024 12:00:57 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLm2-00000002Uek-1U5f for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 12:00:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712232053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=ZJQO1LKQ4/YdGI4ahHtm0KHDzGiPpcFyi0D+eNTsS8jSj7xNYjiSNbeXK+IrEphm3v9lbN fwLRrKlox7Xa/HcduDl+D0NX1FxoGzfU4qYy2Hf5sd12bU+m543M7zAnw9W9k8zMs18K0d xgXaxFZjgJc/Gj5uUT2nryrwDpbzG/k= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-njz1-rJnMwyAYgeqPP63eQ-1; Thu, 04 Apr 2024 08:00:51 -0400 X-MC-Unique: njz1-rJnMwyAYgeqPP63eQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6992d40ea4aso1903646d6.1 for ; Thu, 04 Apr 2024 05:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712232051; x=1712836851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=oGaVZ7hEYF3xMG6fL6mUYGb2vJtm2rEKIl/fPkGZRlGeWep5qlajinxpkaoAaguTml HvglUu6WzrElIqYpgJGp+kqT+EEXgrVdvokADpd1YPf8fGBngb4/1RyUVM685K2hNG9g M3IxwjLv+aBdFoF2o0J7GVGmPSoWWDzrmu70DJIeEITYJmCm5UzB5x918MRFhVzgE+3J llZFFll5RZQ9eyJTpVihi09vjCtkLiEJioNaUP1pjdJ4CFSNOykZXZG1m1MQNdrXpUNZ i8Lpm2yMZdUj2VqY7h0kz2/QylZZJWEd4l7wxRQcVqJWxbJ5RHyKh/TWqriKj2iMNjEr QjwA== X-Forwarded-Encrypted: i=1; AJvYcCVjWWlwtQYzsURIOH0//KcE0OmORU0ktCZqQaK80PNF73vEXRjCUiBAdJlE/DC5Pf3AZI1mj51V7P73jZMAEPgwJRyYmld5Iw5Q9u8l3WqGKFfwqx0= X-Gm-Message-State: AOJu0Yx3zZNDMX61Oni7J4kpBXRVoXlH3+ipb12RjRdejdlPag/qvdXx Lg5sQXiuQhMNkltXRSFpLTaJNsjeFFSley7xxD1XFoRZRKo1UYf3oiIqC359bilUKgQ/Upt/mAP FKWxg9i/m3JntZD8RnR4APSFeQYXmXlSWIxJDivyLPH9k7p5AWUSVRuNdpW4g0IIMIzwiJ8zl X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122683qvb.0.1712232050905; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMCWtQWiLpesBQTQo5kp7GWlhuKWfgLgdLeENDjrnl6Gj4+sgwXTUEXT7yElLHvch56DwpwQ== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122629qvb.0.1712232050343; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id jf14-20020a0562142a4e00b006987021a724sm7171209qvb.118.2024.04.04.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Date: Thu, 4 Apr 2024 08:00:47 -0400 From: Peter Xu To: Jason Gunthorpe Cc: Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Mike Rapoport , Axel Rasmussen , Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> <20240403120841.GB1723999@nvidia.com> <20240404112404.GG1723999@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240404112404.GG1723999@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_050054_501891_81599B8B X-CRM114-Status: GOOD ( 22.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > > > > Yes, that sounds better too to me, however it means we may also risk other > > archs that can fail another defconfig build.. and I worry I bring trouble > > to multiple such cases. Fundamentally it's indeed my patch that broke > > those builds, so I still sent the change and leave that for arch developers > > to decide the best for the archs. > > But your change causes silent data corruption if the code path is > run.. I think we are overall better to wade through the compile time > bugs from linux-next. Honestly if there were alot then I'd think there > would be more complaints already. > > Maybe it should just be a seperate step from this series. Right, that'll be imho better to be done separate, as I think we'd better consolidate the code. One thing I don't worry is the warning would cause anything real to fail; I don't yet expect any arch that will not define pud_pfn when it needs it.. so it can mean all of the build errors may not cause real benefits as of now. But I agree with you we'd better have it. I'll take a todo and I'll try to add it back after all these fallouts. With my cross build chains now it shouldn't be hard, just take some time to revisit each arch. Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel