From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89421CD1288 for ; Thu, 4 Apr 2024 19:56:01 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rsTBo-0004S5-GC; Thu, 04 Apr 2024 19:56:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rsTBm-0004Rz-KL for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Apr 2024 19:55:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cEXMXmfHQZnzFlOGBBuh61Bcm1qVtzQ+kjaGR7HPgTc=; b=IjqbhgCSeThUsd2X8yhOUCbIyY fo0F5lmfOm7xqnaEL4Sp2vqYMHblxdGtbeEolmC92ufdniRwEJnaJZuE11SF1rTdhuWaUwGYqpQ4u wHI9dK2l4q7b9q310HAZUR5pRBeeQeFWliKYvuA/yPb/GJ8taPbftlFmOCSXSVvY1wMg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cEXMXmfHQZnzFlOGBBuh61Bcm1qVtzQ+kjaGR7HPgTc=; b=NjFnnpQneCEkwwwzEbtSQYLS9x CynJJyqGQlsa/Xugu64f3vQu3dvT07oyPTiCY89qItv07VzG6ASh+TLHhDsK2xTyhsmsFCXwqDwUV VVLawUBenjlhPpMZ6FxdzIL3xQi0xNxAf5/cF3/EBqmkiOLlqiGJ8z7of1HZXem167n0=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rsTBk-0003zD-E3 for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Apr 2024 19:55:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F0569CE2086; Thu, 4 Apr 2024 19:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0600BC433F1; Thu, 4 Apr 2024 19:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712260544; bh=EpILh+wb4KCEI3yEhXzuXtGDiLSGEDMU1ojOng1rrks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pr/AKpWwpMNMG2eBSfzUc5T11uNTSkOUuUP7xwsV78y4+DgBKF+Or8iPbyYWJAGSt 9y75mzD3jPQTGeWgX88sHDcfifz66ixCQC0JgpBc7CZ2fB4VD4Z4HcMR3fYQVofABl 28wNvA1B0vMrbNQJyGxQCJ6RStbZCjskxxOPrUwza+V62wnqsj1hel8tI/GjdKQ1rQ 5+i93e1HCqXFFf+9MHONUqkYlVWotmypVZonEO+B5+I9KRtfxYilne/Z3ilAD7k7hD xtsfXowoxPfdM739dGjnUfpzkL7z2bLkmgGDSZqga05yFdped1aCeQTLNENrGkpJh6 hbBxtgiyBrBvw== Date: Thu, 4 Apr 2024 19:55:42 +0000 From: Jaegeuk Kim To: Light Hsieh =?utf-8?B?KOisneaYjueHiCk=?= Message-ID: References: <20240320001442.497813-1-jaegeuk@kernel.org> <20240321224233.2541-1-hdanton@sina.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1rsTBk-0003zD-E3 Subject: Re: [f2fs-dev] =?utf-8?b?5Zue6KaGOiDlm57opoY6IFtQQVRDSF0gZjJmczog?= =?utf-8?q?avoid_the_deadlock_case_when_stopping_discard_thread?= X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hillf Danton , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDQvMDMsIExpZ2h0IEhzaWVoICjorJ3mmI7nh4gpIHdyb3RlOgo+IE91ciBsb2cgc2hvd3Mg dGhhdCB0aGF3X3N1cGVyX2xvY2tlZCgpIGZpbmQgdGhhdCBzYiBpcyByZWFkb25seSzCoHNvIHNi X2ZyZWV6ZV91bmxvY2soKSBpcyBub3QgaW52b2tlZC4KPiAKPiBzdGF0aWMgaW50IHRoYXdfc3Vw ZXJfbG9ja2VkKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsIGVudW0gZnJlZXplX2hvbGRlciB3aG8p Cj4gewo+IOKAguKAguKAguKAguKAguKAgi4uLgo+IOKAguKAguKAguKAguKAguKAgmlmIChzYl9y ZG9ubHkoc2IpKSB7Cj4g4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCCc2ItPnNf d3JpdGVycy5mcmVlemVfaG9sZGVycyAmPSB+d2hvOwo+IOKAguKAguKAguKAguKAguKAguKAguKA guKAguKAguKAguKAgnNiLT5zX3dyaXRlcnMuZnJvemVuID0gU0JfVU5GUk9aRU47Cj4g4oCC4oCC 4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCC4oCCd2FrZV91cF92YXIoJnNiLT5zX3dyaXRlcnMu ZnJvemVuKTsKPiDigILigILigILigILigILigILigILigILigILigILigILigIJnb3RvIG91dDsK PiDigILigILigILigILigILigIJ9Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAuLi4KPiDigILi gILigILigILigILigIJzYl9mcmVlemVfdW5sb2NrKHNiLCBTQl9GUkVFWkVfRlMpOwo+IG91dDoK PiDigILigILigILigILigILigIJkZWFjdGl2YXRlX2xvY2tlZF9zdXBlcihzYik7Cj4g4oCC4oCC 4oCC4oCC4oCC4oCCcmV0dXJuIDA7Cj4gfQoKVGhhbmsgeW91LiBDb3VsZCB5b3UgcGxlYXNlIHRh a2UgYSBsb29rIGF0IHRoaXMgcGF0Y2g/CgpodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1m MmZzLWRldmVsLzIwMjQwNDA0MTk1MjU0LjU1Njg5Ni0xLWphZWdldWtAa2VybmVsLm9yZy9ULyN1 Cgo+IAo+IOWvhOS7tuiAhTrCoEphZWdldWsgS2ltIDxqYWVnZXVrQGtlcm5lbC5vcmc+Cj4g5a+E 5Lu25pel5pyfOsKgMjAyNOW5tDPmnIgyN+aXpSDkuIrljYggMTI6NTIKPiDmlLbku7bogIU6wqBM aWdodCBIc2llaCAo6Kyd5piO54eIKSA8TGlnaHQuSHNpZWhAbWVkaWF0ZWsuY29tPgo+IOWJr+ac rDrCoEhpbGxmIERhbnRvbiA8aGRhbnRvbkBzaW5hLmNvbT47IGxpbnV4LWtlcm5lbEB2Z2VyLmtl cm5lbC5vcmcgPGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+OyBsaW51eC1mMmZzLWRldmVs QGxpc3RzLnNvdXJjZWZvcmdlLm5ldCA8bGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3Jn ZS5uZXQ+Cj4g5Li75peoOsKgUmU6IOWbnuimhjogW1BBVENIXSBmMmZzOiBhdm9pZCB0aGUgZGVh ZGxvY2sgY2FzZSB3aGVuIHN0b3BwaW5nIGRpc2NhcmQgdGhyZWFkCj4gwqAKPiAKPiBFeHRlcm5h bCBlbWFpbCA6IFBsZWFzZSBkbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1 bnRpbCB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIG9yIHRoZSBjb250ZW50Lgo+IE9uIDAz LzIyLCBKYWVnZXVrIEtpbSB3cm90ZToKPiA+IE9uIDAzLzIyLCBMaWdodCBIc2llaCAo6Kyd5piO 54eIKSB3cm90ZToKPiA+ID4gSSBkb24ndCBzZWUgbXkgYWRkZWQgbG9nIGluIHNiX2ZyZWVfdW5s b2NrKCkgd2hpY2ggd2lsbCBpbnZva2UgcGVyY3B1X3VwX3dyaXRlIHRvIHJlbGVhc2UgdGhlIHdy aXRlIHNlbWFwaG9yZS4KPiA+IAo+ID4gTWF5IEkgYXNrIG1vcmUgZGV0YWlscyB3aGV0aGVyIHRo YXdfc3VwZXIoKSB3YXMgY2FsbGVkIG9yIG5vdD8KPiAKPiBQaW5nPwo+IAo+ID4gCj4gPiA+IAo+ ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4g5a+E5Lu2 6ICFOiBKYWVnZXVrIEtpbSA8amFlZ2V1a0BrZXJuZWwub3JnPgo+ID4gPiDlr4Tku7bml6XmnJ86 IDIwMjTlubQz5pyIMjLml6Ug5LiK5Y2IIDA4OjI5Cj4gPiA+IOaUtuS7tuiAhTogSGlsbGYgRGFu dG9uIDxoZGFudG9uQHNpbmEuY29tPgo+ID4gPiDlia/mnKw6IGxpbnV4LWtlcm5lbEB2Z2VyLmtl cm5lbC5vcmcgPGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+OyBMaWdodCBIc2llaCAo6Kyd 5piO54eIKSA8TGlnaHQuSHNpZWhAbWVkaWF0ZWsuY29tPjsgbGludXgtZjJmcy1kZXZlbEBsaXN0 cy5zb3VyY2Vmb3JnZS5uZXQgPGxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0 Pgo+ID4gPiDkuLvml6g6IFJlOiBbUEFUQ0hdIGYyZnM6IGF2b2lkIHRoZSBkZWFkbG9jayBjYXNl IHdoZW4gc3RvcHBpbmcgZGlzY2FyZCB0aHJlYWQKPiA+ID4gCj4gPiA+IAo+ID4gPiBFeHRlcm5h bCBlbWFpbCA6IFBsZWFzZSBkbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1 bnRpbCB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIG9yIHRoZSBjb250ZW50Lgo+ID4gPiAK PiA+ID4gT24gMDMvMjIsIEhpbGxmIERhbnRvbiB3cm90ZToKPiA+ID4gPiBPbiBUdWUsIDE5IE1h ciAyMDI0IDE3OjE0OjQyIC0wNzAwIEphZWdldWsgS2ltIDxqYWVnZXVrQGtlcm5lbC5vcmc+Cj4g PiA+ID4gPiBmMmZzX2lvY19zaHV0ZG93bihGMkZTX0dPSU5HX0RPV05fTk9TWU5DKSAgaXNzdWVf ZGlzY2FyZF90aHJlYWQKPiA+ID4gPiA+ICAtIG1udF93YW50X3dyaXRlX2ZpbGUoKQo+ID4gPiA+ ID4gICAgLSBzYl9zdGFydF93cml0ZShTQl9GUkVFWkVfV1JJVEUpCj4gPiA+ID4gIF9fc2Jfc3Rh cnRfd3JpdGUoKQo+ID4gPiA+ICAgIHBlcmNwdV9kb3duX3JlYWQoKQo+ID4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLSBzYl9zdGFydF9pbnR3cml0 ZShTQl9GUkVFWkVfRlMpOwo+ID4gPiA+ICAgIF9fc2Jfc3RhcnRfd3JpdGUoKQo+ID4gPiA+ICAg ICAgcGVyY3B1X2Rvd25fcmVhZCgpCj4gPiA+ID4KPiA+ID4gPiBHaXZlbiBsb2NrIGFjcXVpcmVy cyBmb3IgcmVhZCBvbiBib3RoIHNpZGVzLCB3dGYgZGVhZGxvY2sgYXJlIHlvdSBmaXhpbmc/Cj4g PiA+IAo+ID4gPiBEYW1uLiBJIGNvdWxkbid0IHRoaW5rIF93cml0ZSB1c2VzIF9yZWFkIHNlbS4K PiA+ID4gCj4gPiA+ID4KPiA+ID4gPiA+ICAtIGYyZnNfc3RvcF9jaGVja3BvaW50KHNiaSwgZmFs c2UsICAgICAgICAgICAgOiB3YWl0aW5nCj4gPiA+ID4gPiAgICAgU1RPUF9DUF9SRUFTT05fU0hV VERPV04pOwo+ID4gPiA+ID4gIC0gZjJmc19zdG9wX2Rpc2NhcmRfdGhyZWFkKHNiaSk7Cj4gPiA+ ID4gPiAgICAtIGt0aHJlYWRfc3RvcCgpCj4gPiA+ID4gPiAgICAgIDogd2FpdGluZwo+ID4gPiA+ ID4KPiA+ID4gPiA+ICAtIG1udF9kcm9wX3dyaXRlX2ZpbGUoZmlscCk7Cj4gPiA+ID4KPiA+ID4g PiBNb3JlIGltcG9ydGFudCwgZmVlbCBmcmVlIHRvIGFkZCBpbiBzcGluLgo+ID4gPiAKPiA+ID4g SSBwb3N0ZWQgdGhpcyBwYXRjaCBiZWZvcmUgTGlnaHQgcmVwb3J0ZWQuCj4gPiA+IAo+ID4gPiBB bmQsIGluIHRoZSByZXBvcnQsIEkgZGlkbid0IGdldCB0aGlzOgo+ID4gPiAKPiA+ID4gZjJmc19p b2Nfc2h1dGRvd24oKSAtLT4gZnJlZXplX2JkZXYoKSAtLT4gZnJlZXplX3N1cGVyKCkgLS0+IHNi X3dhaXRfd3JpdGUoc2IsIFNCX0ZSRUVaRV9GUykgLS0+IC4uLiAtPnBlcmNwdV9kb3duX3dyaXRl KCkuCj4gPiA+IAo+ID4gPiBiZWNhdXNlIGYyZnNfaW9jX3NodXRkb3duKCkgY2FsbHMgZjJmc19z dG9wX2Rpc2NhcmRfdGhyZWFkKCkgYWZ0ZXIgdGhhd19iZGV2KCkKPiA+ID4gbGlrZSB0aGlzIG9y ZGVyLgo+ID4gPiAKPiA+ID4gIC0+IGZyZWV6ZV9iZGV2KCkKPiA+ID4gIC0+IHRoYXdfYmRldigp Cj4gPiA+ICAtPiBmMmZzX3N0b3BfZGlzY2FyZF90aHJlYWQoKQo+ID4gPiAKPiA+ID4gQW0gSSBt aXNzaW5nIHNvbWV0aGluZz8KPiA+ID4gCj4gPiA+ID4KPiA+ID4gPiBSZXBvcnRlZC1ieTogIkxp Z2h0IEhzaWVoICjorJ3mmI7nh4gpIiA8TGlnaHQuSHNpZWhAbWVkaWF0ZWsuY29tPgo+ID4gPiAK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1m MmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdl Lm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1m MmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5E41130A77 for ; Thu, 4 Apr 2024 19:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712260544; cv=none; b=mDcEukZjRDL6CifKSryf+cWt5EAkt2J8DWOWwOF1n0v8zLxnWpNqC99yAO4iRdlcNdr+nXHj73qe2YFOX20tNG2MRziQdwPv8pSRmhx20Rc9ExMy2/rFsWpRi+ZrY/snP3q9lzr5D7DmKgbWZUgi5H7ds3qXHd9T27uSvo5wPbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712260544; c=relaxed/simple; bh=EpILh+wb4KCEI3yEhXzuXtGDiLSGEDMU1ojOng1rrks=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fhguYJmcmy49ZTabovBg3i+kp5GTARQ+gWrNOxqiwimYqhTDT5VwJqcYDNv19ovZ+zebjCL9IcUaTEZh6m38P3gaYd5uRZTfVh3w5hvSySUZ/HtgJLu/FMwB/r9fqpoN2DQBzOYskQr1/pbQtI6wwmAPyq9UBrZKuFGJnglGZAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pr/AKpWw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pr/AKpWw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0600BC433F1; Thu, 4 Apr 2024 19:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712260544; bh=EpILh+wb4KCEI3yEhXzuXtGDiLSGEDMU1ojOng1rrks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pr/AKpWwpMNMG2eBSfzUc5T11uNTSkOUuUP7xwsV78y4+DgBKF+Or8iPbyYWJAGSt 9y75mzD3jPQTGeWgX88sHDcfifz66ixCQC0JgpBc7CZ2fB4VD4Z4HcMR3fYQVofABl 28wNvA1B0vMrbNQJyGxQCJ6RStbZCjskxxOPrUwza+V62wnqsj1hel8tI/GjdKQ1rQ 5+i93e1HCqXFFf+9MHONUqkYlVWotmypVZonEO+B5+I9KRtfxYilne/Z3ilAD7k7hD xtsfXowoxPfdM739dGjnUfpzkL7z2bLkmgGDSZqga05yFdped1aCeQTLNENrGkpJh6 hbBxtgiyBrBvw== Date: Thu, 4 Apr 2024 19:55:42 +0000 From: Jaegeuk Kim To: Light Hsieh =?utf-8?B?KOisneaYjueHiCk=?= Cc: Hillf Danton , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Subject: Re: =?utf-8?B?5Zue6KaGOiDlm57opoY6IFtQQVRD?= =?utf-8?Q?H=5D?= f2fs: avoid the deadlock case when stopping discard thread Message-ID: References: <20240320001442.497813-1-jaegeuk@kernel.org> <20240321224233.2541-1-hdanton@sina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 04/03, Light Hsieh (謝明燈) wrote: > Our log shows that thaw_super_locked() find that sb is readonly, so sb_freeze_unlock() is not invoked. > > static int thaw_super_locked(struct super_block *sb, enum freeze_holder who) > { >       ... >       if (sb_rdonly(sb)) { >             sb->s_writers.freeze_holders &= ~who; >             sb->s_writers.frozen = SB_UNFROZEN; >             wake_up_var(&sb->s_writers.frozen); >             goto out; >       } >                ... >       sb_freeze_unlock(sb, SB_FREEZE_FS); > out: >       deactivate_locked_super(sb); >       return 0; > } Thank you. Could you please take a look at this patch? https://lore.kernel.org/linux-f2fs-devel/20240404195254.556896-1-jaegeuk@kernel.org/T/#u > > 寄件者: Jaegeuk Kim > 寄件日期: 2024年3月27日 上午 12:52 > 收件者: Light Hsieh (謝明燈) > 副本: Hillf Danton ; linux-kernel@vger.kernel.org ; linux-f2fs-devel@lists.sourceforge.net > 主旨: Re: 回覆: [PATCH] f2fs: avoid the deadlock case when stopping discard thread >   > > External email : Please do not click links or open attachments until you have verified the sender or the content. > On 03/22, Jaegeuk Kim wrote: > > On 03/22, Light Hsieh (謝明燈) wrote: > > > I don't see my added log in sb_free_unlock() which will invoke percpu_up_write to release the write semaphore. > > > > May I ask more details whether thaw_super() was called or not? > > Ping? > > > > > > > > > > > > ________________________________ > > > 寄件者: Jaegeuk Kim > > > 寄件日期: 2024年3月22日 上午 08:29 > > > 收件者: Hillf Danton > > > 副本: linux-kernel@vger.kernel.org ; Light Hsieh (謝明燈) ; linux-f2fs-devel@lists.sourceforge.net > > > 主旨: Re: [PATCH] f2fs: avoid the deadlock case when stopping discard thread > > > > > > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > On 03/22, Hillf Danton wrote: > > > > On Tue, 19 Mar 2024 17:14:42 -0700 Jaegeuk Kim > > > > > f2fs_ioc_shutdown(F2FS_GOING_DOWN_NOSYNC) issue_discard_thread > > > > > - mnt_want_write_file() > > > > > - sb_start_write(SB_FREEZE_WRITE) > > > > __sb_start_write() > > > > percpu_down_read() > > > > > - sb_start_intwrite(SB_FREEZE_FS); > > > > __sb_start_write() > > > > percpu_down_read() > > > > > > > > Given lock acquirers for read on both sides, wtf deadlock are you fixing? > > > > > > Damn. I couldn't think _write uses _read sem. > > > > > > > > > > > > - f2fs_stop_checkpoint(sbi, false, : waiting > > > > > STOP_CP_REASON_SHUTDOWN); > > > > > - f2fs_stop_discard_thread(sbi); > > > > > - kthread_stop() > > > > > : waiting > > > > > > > > > > - mnt_drop_write_file(filp); > > > > > > > > More important, feel free to add in spin. > > > > > > I posted this patch before Light reported. > > > > > > And, in the report, I didn't get this: > > > > > > f2fs_ioc_shutdown() --> freeze_bdev() --> freeze_super() --> sb_wait_write(sb, SB_FREEZE_FS) --> ... ->percpu_down_write(). > > > > > > because f2fs_ioc_shutdown() calls f2fs_stop_discard_thread() after thaw_bdev() > > > like this order. > > > > > > -> freeze_bdev() > > > -> thaw_bdev() > > > -> f2fs_stop_discard_thread() > > > > > > Am I missing something? > > > > > > > > > > > Reported-by: "Light Hsieh (謝明燈)" > > >