From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
kernel test robot <lkp@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] net: wan: framer: Add missing static inline qualifiers
Date: Mon, 25 Mar 2024 11:23:07 +0200 [thread overview]
Message-ID: <ZgFCe39GJEARc9g4@smile.fi.intel.com> (raw)
In-Reply-To: <20240325082505.29385-1-herve.codina@bootlin.com>
On Mon, Mar 25, 2024 at 09:25:05AM +0100, Herve Codina wrote:
> Compilation with CONFIG_GENERIC_FRAMER disabled lead to the following
> warnings:
> framer.h:184:16: warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
> 184 | struct framer *framer_get(struct device *dev, const char *con_id)
> framer.h:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> 184 | struct framer *framer_get(struct device *dev, const char *con_id)
> framer.h:189:6: warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
> 189 | void framer_put(struct device *dev, struct framer *framer)
> framer.h:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> 189 | void framer_put(struct device *dev, struct framer *framer)
Always try to minimize the warnings/backtraces/etc to the point. In this case
it's enough to have:
warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
> Add missing 'static inline' qualifiers for these functions.
Code wise looks good,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-25 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:25 [PATCH] net: wan: framer: Add missing static inline qualifiers Herve Codina
2024-03-25 9:23 ` Andy Shevchenko [this message]
2024-03-27 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgFCe39GJEARc9g4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.