From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support
Date: Mon, 25 Mar 2024 19:32:31 +0200 [thread overview]
Message-ID: <ZgG1LwVAd1xxqJTg@smile.fi.intel.com> (raw)
In-Reply-To: <92f1cf44-3228-4eca-b8d3-39057c1150bb@sirena.org.uk>
On Mon, Mar 25, 2024 at 05:22:55PM +0000, Mark Brown wrote:
> On Mon, Mar 25, 2024 at 04:24:19PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 25, 2024 at 02:16:15PM +0000, Mark Brown wrote:
> > > On Mon, Mar 18, 2024 at 10:25:16PM +0200, Andy Shevchenko wrote:
...
> > > > If I am not mistaken, after
> > > > https://lore.kernel.org/r/20240318200804.181516-1-andriy.shevchenko@linux.intel.com
> > > > there is no more users. Hence the above is the only dependency.
>
> > > You are mistaken, please try compile tests:
...
> > > (this is among other things in x86 allmodconfig).
>
> > I usually enable the particular drivers and I have compile tested this,
> > but indeed, I haven't enabled _all_ modules.
>
> > Thank you for the pointing out.
>
> Especially if you're doing this sort of "I think I got everything" type
> change it's sensible to do at least one allmodconfig build, it won't get
> everything but it'll catch a lot.
True, as even `git grep` output can be misinterpreted and some occurrences
may disappear from the sight.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-25 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 20:25 [PATCH v1 1/1] ASoC: soc-jack: Get rid of legacy GPIO support Andy Shevchenko
2024-03-25 14:16 ` Mark Brown
2024-03-25 14:24 ` Andy Shevchenko
2024-03-25 17:22 ` Mark Brown
2024-03-25 17:32 ` Andy Shevchenko [this message]
2024-03-26 19:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgG1LwVAd1xxqJTg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.