From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Kate Hsuan" <hpa@redhat.com>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"André Apitzsch" <git@apitzsch.eu>,
linux-kernel@vger.kernel.org,
"Sebastian Reichel" <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED
Date: Mon, 25 Mar 2024 18:31:41 +0200 [thread overview]
Message-ID: <ZgGm7eDBQtwH37ya@smile.fi.intel.com> (raw)
In-Reply-To: <bb7536be-9bed-4557-b111-6409ebfe48f4@redhat.com>
On Mon, Mar 25, 2024 at 04:02:54PM +0100, Hans de Goede wrote:
> On 3/22/24 4:37 AM, Kate Hsuan wrote:
> > There is a KTD2026 LED controller to manage the indicator LED for Xiaomi
> > pad2. The ACPI for it is not properly made so the kernel can't get
> > a correct description of it.
> >
> > This work add a description for this RGB LED controller and also set a
> > trigger to indicate the chaging event (bq27520-0-charging). When it is
> > charging, the indicator LED will be turn on.
> >
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> I will also merge [PATCH v5 6/6] platform: x86-android-tablets:
> others: Set the LED trigger to charging_red_full_green for Xiaomi pad2"
>
> Once the new power_supply trigger patch this relies on has been
> accepted.
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
I believe I have commented on the "RESEND" version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-25 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 3:37 [PATCH v5 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-03-25 15:02 ` Hans de Goede
2024-03-25 16:31 ` Andy Shevchenko [this message]
2024-03-27 6:09 ` Kate Hsuan
2024-03-27 20:08 ` Hans de Goede
2024-03-22 3:37 ` [PATCH v5 2/6] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 3/6] leds: core: Add led_mc_set_brightness() function Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 4/6] leds: trigger: Add led_mc_trigger_event() function Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 5/6] power: supply: power-supply-leds: Add charging_red_full_green trigger for RGB LED Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_red_full_green for Xiaomi pad2 Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgGm7eDBQtwH37ya@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=git@apitzsch.eu \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.