From: Lukas Wunner <lukas@wunner.de>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
bbhushan2@marvell.com, jarkko@kernel.org
Subject: Re: [PATCH v7 00/13] Add support for NIST P521 to ecdsa
Date: Mon, 25 Mar 2024 20:18:37 +0100 [thread overview]
Message-ID: <ZgHODQL-XLxTDO4b@wunner.de> (raw)
In-Reply-To: <5c6c5f51-125b-4cc7-ac27-5a5358d514c7@linux.ibm.com>
On Wed, Mar 20, 2024 at 08:44:52AM -0400, Stefan Berger wrote:
> On 3/20/24 07:47, Stefan Berger wrote:
> > This series adds support for the NIST P521 curve to the ecdsa module
> > to enable signature verification with it.
> >
> > An issue with the current code in ecdsa is that it assumes that input
> > arrays providing key coordinates for example, are arrays of digits
> > (a 'digit' is a 'u64'). This works well for all currently supported
> > curves, such as NIST P192/256/384, but does not work for NIST P521 where
> > coordinates are 8 digits + 2 bytes long. So some of the changes deal with
> > converting byte arrays to digits and adjusting tests on input byte
> > array lengths to tolerate arrays not providing multiples of 8 bytes.
I've tested the whole series successfully on v6.9-rc1 by authenticating
a PCI device with a NIST P521 certificate using my PCI/CMA development
branch: https://github.com/l1k/linux/commits/doe
Tested-by: Lukas Wunner <lukas@wunner.de>
prev parent reply other threads:[~2024-03-25 19:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 11:47 Add support for NIST P521 to ecdsa Stefan Berger
2024-03-20 11:47 ` [PATCH v7 01/13] crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible Stefan Berger
2024-03-20 11:47 ` [PATCH v7 02/13] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-21 17:07 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 03/13] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-21 17:11 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 04/13] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-21 17:15 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 05/13] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-21 17:17 ` Jarkko Sakkinen
2024-03-21 17:42 ` Stefan Berger
2024-03-21 18:24 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 06/13] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-21 17:18 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 07/13] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-20 11:47 ` [PATCH v7 08/13] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-20 11:47 ` [PATCH v7 09/13] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-21 17:19 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 10/13] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-21 17:19 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 11/13] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-20 11:47 ` [PATCH v7 12/13] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-21 17:20 ` Jarkko Sakkinen
2024-03-20 11:47 ` [PATCH v7 13/13] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-03-21 17:20 ` Jarkko Sakkinen
2024-03-21 17:42 ` Stefan Berger
2024-03-21 18:25 ` Jarkko Sakkinen
2024-03-20 12:44 ` [PATCH v7 00/13] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-25 19:18 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgHODQL-XLxTDO4b@wunner.de \
--to=lukas@wunner.de \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saulo.alessandre@tse.jus.br \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.