From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B285B697 for ; Mon, 25 Mar 2024 21:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711400573; cv=none; b=I00XkY/HPuK53WVwBkRltZpuiEP+tDQCE3q4oeJerCE1qRDUap9VtYQGp2srqgq7Yyn/clikiGEajCMQ1U+CAeZ2fDqJT7pZ9Dj1gCdOc4Vivl7CClnOw/B0Z9k9bHsWNsWcrEnI+GvFLgFheqlaxOvrp11qZVIl5wxrCFV1DQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711400573; c=relaxed/simple; bh=OywY4I5adWwnLh/laC1ARj9udrQ7qWNwu/pccoMaJr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ECc0H9MUwW2ShXlPOGGudBBO2K8qh+ZHTYUieU68W+zkHBXgAcf6pJ+mNcDuWtwKmjYrdohhGAbrPM+NlbBeprSmjaB6MnPJLaijHo+kNcrVbs36KMYv/2EDN1ptwdSZkp0TBG7v4l00sFa15emHYvKZ33INc5LhSkPipioodeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=l2zfUYzf; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l2zfUYzf" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4140eed8a4fso7645e9.0 for ; Mon, 25 Mar 2024 14:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711400570; x=1712005370; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oyHdM1HjPu6vtjBVJtvhQHjyUmlH2Ts1yIlCV25UwhM=; b=l2zfUYzfl7iF7j084Vr3YBVyEFRb7174vHbU9isip/GdbLLDZL5XhzBVXT+7KS2mee ik6yXuQKgBvTh6M/qE6/D7/CoUSzCJ6dxPYG3RcjgEgcZBW0sY3ZdioFKgxK9y8NPLXD TQeyb/xxJZE3WVymkDaGCVMazWMdzsdP5h6iJIvF1/U5yWGsMhDP2RA8I5ovSKrLlyzA N5EwrtDwRNLJ4db+L0agW6Oi5U4QpRnsNjJ8PCHUHD2Xhw0C/5fuRQG5buK6SZx3vXXc EVlqMGIixCZQGT0Y45mxTg4GZwm56vlfK8WswRuh4K4PeA/fToYqFfi4xauJX9bw33wv 34FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711400570; x=1712005370; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oyHdM1HjPu6vtjBVJtvhQHjyUmlH2Ts1yIlCV25UwhM=; b=JXp1iH7YLWeLZuZ/2iBquWfS7G4cGST5VDuzG2HvoLAy94oTN2WieJa9gMkN4PSg1z FDHymY3Vwla9WifppEoZnHvK9KEZ8wxGIXvgvGPC9qObFbTVl4r0W/Bdyv3l62myihcA OUQvsA55dLmRKT0ODa/z0EK4RjZpF2bxgokI5WDsoLVdoaQ9bwQbrlJ40PRvrY+dDIcK /wAjEc8i0VHI+4vz5yDKS4Xlq6OwAHO5yf85vPxJ2W/WGdOzp44CGDGqcPRXv+Wv1Kws l4zifs+n1UjOLWM/U90PVUrpEGwCeHYsdUqc6goevepIwHqLqwsj6nD9LRO+zzp58ut4 r4RA== X-Gm-Message-State: AOJu0YwC2Y4JkzEAIop9BzFZjFxqXrzLx8hQfZLc2+sDw4ThRZuKyUpy riZqS+50XLzSIR6Y0kVCG8iPEH39c23NsSr7fWqcbOAtWQit+66Au4bJMmDgRQ== X-Google-Smtp-Source: AGHT+IExHgJARivp8cbPHRh0LgG8TmwrsgCGNCGfSSnbswUEv2qNKtbvjuG8qARXLbCe3yOUY0kalg== X-Received: by 2002:a05:600c:1c27:b0:414:fb8:5105 with SMTP id j39-20020a05600c1c2700b004140fb85105mr16711wms.3.1711400569712; Mon, 25 Mar 2024 14:02:49 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id y17-20020adff151000000b0033e43756d11sm10353238wro.85.2024.03.25.14.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 14:02:49 -0700 (PDT) Date: Mon, 25 Mar 2024 21:02:45 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 06/27] iommu/arm-smmu-v3: Consolidate clearing a CD table entry Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <6-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <20240325141433.GB110546@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240325141433.GB110546@nvidia.com> On Mon, Mar 25, 2024 at 11:14:33AM -0300, Jason Gunthorpe wrote: > On Fri, Mar 22, 2024 at 06:36:17PM +0000, Mostafa Saleh wrote: > > > +void arm_smmu_clear_cd(struct arm_smmu_master *master, ioasid_t ssid) > > > +{ > > > + struct arm_smmu_cd target = {}; > > > + struct arm_smmu_cd *cdptr; > > > + > > > + if (!master->cd_table.cdtab) > > > + return; > > > + cdptr = arm_smmu_get_cd_ptr(master, ssid); > > > + if (WARN_ON(!cdptr)) > > > + return; > > > > I don’t understand the SVA code enough, but AFAICT, arm_smmu_sva_set_dev_pasid > > can allocate the L2 CD table through arm_smmu_write_ctx_desc. > > Yes > > > And if it failed > > before allocating the CD table, then remove_dev_pasid would be > > called, > > If it fails the core code should not call remove_dev_pasid() on a > domain that was never attached. There is an obscure error unwinding > issue in the core code Yi is looking to fix regarding multi-device > PASID groups, but it is not a driver issue.. > I see, thanks for clarifying. > > which warns here, the previous code would tolerate that, but that > > might regress on systems with panic_on_warn, so I am not sure if > > that is necessary. > > Right, if it does hit it signals there is some error unwinding bug in > the core code that should be resolved. > > > Otherwise, Reviewed-by: Mostafa Saleh > > Thanks, > Jason Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3824C54E58 for ; Mon, 25 Mar 2024 21:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b9bQlqAYm+IyxN8bvIRSDI43SnXuU1F6zdH+6ePoQkQ=; b=PJDwXPcw7KEsto VkUN3Jjh64NCcQdlfmhUdPrbnJw8MWVj4XBK2vBe6Ikj/fhoznZ66BxSadKSA7j359oueN3Sbk4WL 2F7R28ArEbeu3z/hqwy+GpfBy+t/Tm+1lIRcEC6SwwKTRf8rLCfunQnK1vmViMuga7zfqYXcZaGYk A2j66IEscswrmpMt+UKWh8oy00/9h3qs9Dli+hVm4CHx976q1uwoka2VHTmxtWFP1LRLLmcpUzULt fr+rNOVNO7uqi1UuVWEhhCwWkwfj9SwDuLLnT67cvv+dCgUORWNmyDmjD6n3L8/08UF1HJX5dqiLW E0zbHodvIujnGw1+9hFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rorT6-00000001woR-0gYB; Mon, 25 Mar 2024 21:02:56 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rorT2-00000001wld-2d6h for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 21:02:54 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4148c09ec6bso6005e9.1 for ; Mon, 25 Mar 2024 14:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711400570; x=1712005370; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oyHdM1HjPu6vtjBVJtvhQHjyUmlH2Ts1yIlCV25UwhM=; b=1HonBxdqsND0RfMLfaoagt2pwLjv6sG1SvSzvsG4j9Gn86lclXfmPBHuaVDG/qSYq/ Twrkhw4RqbY5iDj2Cz2Juau8SqMYhYTE2T/Pr1JkHM1WTFOScX8Wj4EtlLcXwLxjdM6R P2qZIKJzQ63tr6olBi8BDlXeednrA3j09sJaDlkvJTr8CK/cBnDDcDMMWmO577DUfbhR 8psZLqY+jy9scMApDnY+7adWO2fELPFMznBQcg1TIArkXI/kejtBKbLbWwGZSYmHgT6L oAIiH2jIGHoZ/+vaZ8FU7vjxqvsYyD5PIgZHo5Bwgng8dTkUh0UpMHkDtM+ihjvZxll4 bz3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711400570; x=1712005370; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oyHdM1HjPu6vtjBVJtvhQHjyUmlH2Ts1yIlCV25UwhM=; b=lPc6pM9eDqSkxHqFHsobenvTAnB43E+94O4pCVLQG6hDYXEyspviEqp6acN83jZ09u T7uO0S/zqRevBpC/qbqcuxHg2gytHf5VAp9TzZcQ8kR0v/UNlxvdwl55p2/Zk1VtcPPC L77MwGEsb1G6/3nKzJ8+GVoJdJi8QdRusv9SjFjGFay3BhzpZ9ROx7ivs0qD71whSp+O xO0Vk8SBQgWZBNoP/+gQ9ZIvAMYRUJMxO1Ze0JQnvmouXOsG+2r/XCfXh5xSXP7cZ8j+ Go0ql6XQWc4GSRhVfrml1xHS5HJDcNLuDzeunQLxYi2g8vbMaMrj8S9wH7DJke7vcBkX rGtg== X-Forwarded-Encrypted: i=1; AJvYcCW3RhFzBODwSmFJ1/3jUrw4t+rsK5Xvw+6UTMNKzYSFl7GJdCJ4eP0EnEdkquU36CoEdQF6x5L3rsCnDHGCFWs+urRZBi//Hy7Ukd531KymihUr9KQ= X-Gm-Message-State: AOJu0YxgmYxIEH1eNGE0O3hjGDAYqf79zHmY2m3I5etoSRbqGjubOE5Q erhNCj/mQsDNduRPk0U8Xn87U253AfpZ/0llLZFqwtI5Syy9AwYHVXAwIDiFUg== X-Google-Smtp-Source: AGHT+IExHgJARivp8cbPHRh0LgG8TmwrsgCGNCGfSSnbswUEv2qNKtbvjuG8qARXLbCe3yOUY0kalg== X-Received: by 2002:a05:600c:1c27:b0:414:fb8:5105 with SMTP id j39-20020a05600c1c2700b004140fb85105mr16711wms.3.1711400569712; Mon, 25 Mar 2024 14:02:49 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id y17-20020adff151000000b0033e43756d11sm10353238wro.85.2024.03.25.14.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 14:02:49 -0700 (PDT) Date: Mon, 25 Mar 2024 21:02:45 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 06/27] iommu/arm-smmu-v3: Consolidate clearing a CD table entry Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <6-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <20240325141433.GB110546@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240325141433.GB110546@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_140252_759529_9B908BA8 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjUsIDIwMjQgYXQgMTE6MTQ6MzNBTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDIyLCAyMDI0IGF0IDA2OjM2OjE3UE0gKzAwMDAsIE1vc3Rh ZmEgU2FsZWggd3JvdGU6Cj4gPiA+ICt2b2lkIGFybV9zbW11X2NsZWFyX2NkKHN0cnVjdCBhcm1f c21tdV9tYXN0ZXIgKm1hc3RlciwgaW9hc2lkX3Qgc3NpZCkKPiA+ID4gK3sKPiA+ID4gKwlzdHJ1 Y3QgYXJtX3NtbXVfY2QgdGFyZ2V0ID0ge307Cj4gPiA+ICsJc3RydWN0IGFybV9zbW11X2NkICpj ZHB0cjsKPiA+ID4gKwo+ID4gPiArCWlmICghbWFzdGVyLT5jZF90YWJsZS5jZHRhYikKPiA+ID4g KwkJcmV0dXJuOwo+ID4gPiArCWNkcHRyID0gYXJtX3NtbXVfZ2V0X2NkX3B0cihtYXN0ZXIsIHNz aWQpOwo+ID4gPiArCWlmIChXQVJOX09OKCFjZHB0cikpCj4gPiA+ICsJCXJldHVybjsKPiA+IAo+ ID4gSSBkb27igJl0IHVuZGVyc3RhbmQgdGhlIFNWQSBjb2RlIGVub3VnaCwgYnV0IEFGQUlDVCwg YXJtX3NtbXVfc3ZhX3NldF9kZXZfcGFzaWQKPiA+IGNhbiBhbGxvY2F0ZSB0aGUgTDIgQ0QgdGFi bGUgdGhyb3VnaCBhcm1fc21tdV93cml0ZV9jdHhfZGVzYy4gCj4gCj4gWWVzCj4gCj4gPiBBbmQg aWYgaXQgZmFpbGVkCj4gPiBiZWZvcmUgYWxsb2NhdGluZyB0aGUgQ0QgdGFibGUsIHRoZW4gcmVt b3ZlX2Rldl9wYXNpZCB3b3VsZCBiZQo+ID4gY2FsbGVkLCAKPiAKPiBJZiBpdCBmYWlscyB0aGUg Y29yZSBjb2RlIHNob3VsZCBub3QgY2FsbCByZW1vdmVfZGV2X3Bhc2lkKCkgb24gYQo+IGRvbWFp biB0aGF0IHdhcyBuZXZlciBhdHRhY2hlZC4gVGhlcmUgaXMgYW4gb2JzY3VyZSBlcnJvciB1bndp bmRpbmcKPiBpc3N1ZSBpbiB0aGUgY29yZSBjb2RlIFlpIGlzIGxvb2tpbmcgdG8gZml4IHJlZ2Fy ZGluZyBtdWx0aS1kZXZpY2UKPiBQQVNJRCBncm91cHMsIGJ1dCBpdCBpcyBub3QgYSBkcml2ZXIg aXNzdWUuLgo+IAoKSSBzZWUsIHRoYW5rcyBmb3IgY2xhcmlmeWluZy4KCj4gPiB3aGljaCB3YXJu cyBoZXJlLCB0aGUgcHJldmlvdXMgY29kZSB3b3VsZCB0b2xlcmF0ZSB0aGF0LCBidXQgdGhhdAo+ ID4gbWlnaHQgcmVncmVzcyBvbiBzeXN0ZW1zIHdpdGggcGFuaWNfb25fd2Fybiwgc28gSSBhbSBu b3Qgc3VyZSBpZgo+ID4gdGhhdCBpcyBuZWNlc3NhcnkuCj4gCj4gUmlnaHQsIGlmIGl0IGRvZXMg aGl0IGl0IHNpZ25hbHMgdGhlcmUgaXMgc29tZSBlcnJvciB1bndpbmRpbmcgYnVnIGluCj4gdGhl IGNvcmUgY29kZSB0aGF0IHNob3VsZCBiZSByZXNvbHZlZC4KPiAKPiA+IE90aGVyd2lzZSwgUmV2 aWV3ZWQtYnk6IE1vc3RhZmEgU2FsZWggPHNtb3N0YWZhQGdvb2dsZS5jb20+Cj4gCj4gVGhhbmtz LAo+IEphc29uCgpUaGFua3MsCk1vc3RhZmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK