From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F48D86246; Tue, 26 Mar 2024 18:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711477387; cv=none; b=qZUJPItIums4zyC4XD7IHXKxvLcRZ2nhCiZnfafNf/DakkgKmHt187eoncT6XEpX75XFWAnUiWFqBsrUbN/Ohz/eD69iUWNhnCqdWEVodnqWA4+6lE0X5lHsXbEZVnVh8yhQKVmFufFQ96Hf0+x20ow0tsxd9ItJUTRUFLyFRXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711477387; c=relaxed/simple; bh=ovm4D3iXnxQ6zr4Ox8BpY0X8+EBVACIUdLnzTt2U7Mk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QEnRvgBmtXPxZTRpBED9/sqWTXEiO98UW66Z0H79J/Ew687ZCoopVrhvnB+F6Un4z4VthhgshY9Ts1B0baNnd0SKfuiSWT6TADsufCQbdMKB5YZ0BHKUdXKLYBTZFfca0iAMxktwbi9s06a2qnXNldHc0WwCBJ6wMVDUyv8WTlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=j7mVdm6o; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="j7mVdm6o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711477385; x=1743013385; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ovm4D3iXnxQ6zr4Ox8BpY0X8+EBVACIUdLnzTt2U7Mk=; b=j7mVdm6oqZ+wmDFPFhquEisP/K/c7jKx+u7NvLFb1Ihw6v1SKmHpH4EM r1FdA5CvKAOpw/72hrTkN45lFMragJjDHouXUOQztX4Dbz/DB7bZTFu8n L8gMiBaxqH0vaJq/zju/ofPMuH9f9t7wa1YxSMjbA1+4+4emY/Vx+4EXg bS5S3i195fZtWc13fztHvUM9XytloWNFrBzY74+2eYjK894SNP4pdNbhX v6x9sDcqe7CBt76hW2lcxguI98vJMnciCx5FQ3n3cViPSRtRxoe7XC75D cPimg1mmJ4FNfCCO3KMthrl3SxtwCQpnM+AusaPGOOU8vFHYndIZ9+TU5 g==; X-CSE-ConnectionGUID: iAUJG2PjSPOmtsDb2yB6zg== X-CSE-MsgGUID: A0gXSbnlRFeNPKC3zN26Pw== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="6740890" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="6740890" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:23:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914887365" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914887365" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:23:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpBRr-0000000GQ4R-3RDS; Tue, 26 Mar 2024 20:22:59 +0200 Date: Tue, 26 Mar 2024 20:22:59 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 01/10] spi: pxa2xx: Drop ACPI_PTR() and of_match_ptr() Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-2-andriy.shevchenko@linux.intel.com> <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 26, 2024 at 06:16:28PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:07:51PM +0200, Andy Shevchenko wrote: > > Drop rather useless use of ACPI_PTR() and of_match_ptr(). > > It also removes the necessity to be dependent on ACPI and > > of.h inclusion. > > I think the ACPI dependency there is as much about hiding the device on > irrelevant platforms as anything else, might be better replaced with an > x86 dependency though. The whole idea behind ACPI_PTR() (which seems following the of_match_ptr() implementation) looks premature. Now we have a lot of patches from DT people to remove of_match_ptr(), i.o.w. make the ID visible even on non-OF platforms. Having the list of supported IDs is not bad thing anyway as it might help to google for a device elsewhere, for example. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29CC3C54E67 for ; Tue, 26 Mar 2024 18:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tcF/Rl7gV3gRmf2q0/fiMDlsZF8syFbYDkiwOIF+E9k=; b=AGwz3zr0KnZw8/ HnAtSRoSnXusGr7vT02W6MIYgzhcZfqGW6+QU4fuVI3rjhMqK4fpkRHOqNHK2lBxsyMQbuPgI/F/9 yMr8mCqloMtt0lVEUulaK3+Z0dzaNyxtzjUdbHzMDzDwbKTMDU4we6nzSqdghUNxJz9X8PFh/Uo0A AS1zw4E9xuHbv9vJZPuSdq3B/bT0/OetjB5qxwtxzHBXuKxlKOa1nsmowj1E/vrMjZJW+yPnPf8su XvUTrOnYu9Ydpx4n+C6vXwUDBEy3jxscbQpXEP6p5Z2Huts4WuFXWvCXTnovD1/DYO801fUn3/u0W WhA/QbDEt9wd4PMLXC8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBS1-00000005vJ6-3VNB; Tue, 26 Mar 2024 18:23:09 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBRz-00000005vI0-0uGx for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 18:23:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711477387; x=1743013387; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ovm4D3iXnxQ6zr4Ox8BpY0X8+EBVACIUdLnzTt2U7Mk=; b=ncgpzoOBvYP4x1MM+SRKEyyMBeu6XUkHyhMByE6gdcZ3u/anXO3S9F6J USVvXRvtX190EK7sNbNmUwk3jDYkiNdYZs5eHh/3UzT8U5nH/qMLsk7rg 436aaP5z254EQAj+ZbrbmxKV9F0u1Pz2lVWx/ClFuL8xxXSfFFg4584MM T/Ch7WmEbJnOIh4HQAXIjj9dFpSm9r+s9xyMJ5FWEFmivqqypMD7ktrm+ wYMe/K/1iOzY0JW1mZ7Mia4gUgWwAnkzq5WGL/2mWYffuOyXSz64xSth/ zEh9sNeb5wC0E6OKPiCStQBTN3TnXVo0X4g4DjGUABv7TEmdMUfV+2ruZ g==; X-CSE-ConnectionGUID: 5aQZt6N5R/Cd5DYyMI2ajw== X-CSE-MsgGUID: ah5U6uMKSwKtQMVwahQqNw== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="6740894" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="6740894" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:23:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914887365" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914887365" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:23:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpBRr-0000000GQ4R-3RDS; Tue, 26 Mar 2024 20:22:59 +0200 Date: Tue, 26 Mar 2024 20:22:59 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 01/10] spi: pxa2xx: Drop ACPI_PTR() and of_match_ptr() Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-2-andriy.shevchenko@linux.intel.com> <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_112307_334723_CCF5E486 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 06:16:28PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:07:51PM +0200, Andy Shevchenko wrote: > > Drop rather useless use of ACPI_PTR() and of_match_ptr(). > > It also removes the necessity to be dependent on ACPI and > > of.h inclusion. > > I think the ACPI dependency there is as much about hiding the device on > irrelevant platforms as anything else, might be better replaced with an > x86 dependency though. The whole idea behind ACPI_PTR() (which seems following the of_match_ptr() implementation) looks premature. Now we have a lot of patches from DT people to remove of_match_ptr(), i.o.w. make the ID visible even on non-OF platforms. Having the list of supported IDs is not bad thing anyway as it might help to google for a device elsewhere, for example. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel