From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0938127B5D; Tue, 26 Mar 2024 18:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478659; cv=none; b=IXeBxPxDyRteBlZrxAsJVut41ZQWK1zSfolSmHvRDR3qpDmKGhGA5tqrOFR07VPgXfh0IU2qw4u09r5ip8UWM82gK8gH2Nl8IY+K7s6n1RRPe9KPQw79Nj6wl4uBHqCXTeJdimlgdZJSWaqzsv9XOAJN21TXXa2f0eJ5XqJeMlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478659; c=relaxed/simple; bh=HtGjjsjRQdnWthgLMSyv8b/b2MZS5XuZACuOM3RyUWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QN+ml5cmOOfV+tNEI9+SHl6Lfh9ghYYeiKabBVQbrM9/s6SfdW8CLNzf92oG5wI+jXZDgd0NrKF8jW+OLp14Fl7pfGeiwwyZf5d2+Vsr6Rx4M3Bc3v3T6f9+b4CZy2VA8J18nWkZ11Z0JZjs59+mNqRiON4z8qxTDT/W3jjKI7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OBkWd7Ye; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OBkWd7Ye" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711478657; x=1743014657; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HtGjjsjRQdnWthgLMSyv8b/b2MZS5XuZACuOM3RyUWU=; b=OBkWd7YekTgmLm4pUEC6KsLo/IDZ1tMSHirFbXSS0XXX6B+CnjuvOb72 QFKLVp8C+zZBtwWqKD13zh8YzOsFBVO89XghiN7LZXU9adsRV7XOeQx4q 4m5U+fP7tKfddsq/tHyUhdyibbPhKd5PYedUKRBcZXs706xTjKI/lxpGK 164OumkVZ0EF9g46tBCQ0HIoe+vb0KUUPaIKfo5unVsyIH9XkGoNEzrgx bRX2NJrfuNr9v7r3zxTwoY6L9Urs77gJ8DNR/lCcLjJrhto2uVF/pFH6s pXU2rQfrf5VG7V54XUWWCUm/4Fr45RMOZ32RQWm2lZtOtP7EpQ/IANpD6 g==; X-CSE-ConnectionGUID: SfQFc2DaQQyxz5BJCNTQGg== X-CSE-MsgGUID: VoCqioXNTpOssNh/BuVt3w== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="23991804" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="23991804" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:44:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914887769" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914887769" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:44:14 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpBmN-0000000GQNu-3rjt; Tue, 26 Mar 2024 20:44:11 +0200 Date: Tue, 26 Mar 2024 20:44:11 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 01/10] spi: pxa2xx: Drop ACPI_PTR() and of_match_ptr() Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-2-andriy.shevchenko@linux.intel.com> <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> <424de3ed-f0ea-4fc1-80f5-3ab1d23cf1e1@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <424de3ed-f0ea-4fc1-80f5-3ab1d23cf1e1@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 26, 2024 at 06:25:16PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:22:59PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 26, 2024 at 06:16:28PM +0000, Mark Brown wrote: > > > On Tue, Mar 26, 2024 at 08:07:51PM +0200, Andy Shevchenko wrote: > > > > > Drop rather useless use of ACPI_PTR() and of_match_ptr(). > > > > It also removes the necessity to be dependent on ACPI and > > > > of.h inclusion. > > > > I think the ACPI dependency there is as much about hiding the device on > > > irrelevant platforms as anything else, might be better replaced with an > > > x86 dependency though. > > > The whole idea behind ACPI_PTR() (which seems following the of_match_ptr() > > implementation) looks premature. Now we have a lot of patches from DT people to > > remove of_match_ptr(), i.o.w. make the ID visible even on non-OF platforms. > > > Having the list of supported IDs is not bad thing anyway as it might help > > to google for a device elsewhere, for example. > > That's nice but I'm not sure what that has to do with the dependency on > ACPI? ACPI_PTR() makes ID no-op only if ACPI is defined. That also satisfies the ugly ifdeffery that is removed by this patch as well. If there is no dependency we will have compiler warning for defined but not used variable. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFDFCC54E67 for ; Tue, 26 Mar 2024 18:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JJWvrMp/x8QqfsRL67URYE9jwE9HV4MrUaQDJyGaC34=; b=2+Fd96vvZAFYYp K4O67V/+Y6oFa8/Si+6ugSC0LYTSWuXhkDJR85QsedvFH9Ayd9BoUdGKALM2NoATHkgbR7JXLW9A2 RTcbjanwQi37kerfgAmT8R889+Zu9m+hUXmgKx3PjA9LQqTAfnbcK7RBRO7VxgqJMXzo3yk2Jb6pn uhC+7dtUvkR8WQ9mwXKsYftO1k3HNvXpxikp2kTK+2YtMieSVG46rDZNV8YJ3VSxzFgtBzl5tj4uY hnWLg/Bz37XJUhTZBp08dNfQs9L3WLg4D0oOcx05tB+G1TQ9M5s75feBDxmTDjAmK/utmihyrAEfY 517erCZWoeUZTIwueLkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBma-00000005yIF-1cau; Tue, 26 Mar 2024 18:44:24 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBmV-00000005yH0-2HSQ for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 18:44:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711478659; x=1743014659; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HtGjjsjRQdnWthgLMSyv8b/b2MZS5XuZACuOM3RyUWU=; b=LdVm/GfLIXDJEM6GQREHAHcvkmQoBzfklGxl+xrWr1hpZidJDR3UOf/F naknuCK0lj14pCB49I2vevFKy08JNBy8zo01D21A3Uwr8Z5drKqm5W0xi rzBKebSdtDnu1baOpz2ZLPcU3/uZ6slujyNngOH127pG/oBfst6RW1DrX s3WOMYykVtMjkk85XqQA7fjbLc36Uu6A5y4qfRkP079ZZEW2llZ7yfHfB CRAZlLatMacPS2eL0/DyqqYtgJ9Kicw1vVpZhCPSY8p2AUfgyJIX2EcFj smByCCe+JnnQGgpMCr67qk8riqL3hPdORA0dGzwx8FpMwNJz54iTLxHeF A==; X-CSE-ConnectionGUID: AQweZY3kR/2yCEh0yoRj+g== X-CSE-MsgGUID: zEHsEpU5TTaKMJRWeeMncw== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="23991800" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="23991800" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:44:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914887769" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914887769" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:44:14 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpBmN-0000000GQNu-3rjt; Tue, 26 Mar 2024 20:44:11 +0200 Date: Tue, 26 Mar 2024 20:44:11 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 01/10] spi: pxa2xx: Drop ACPI_PTR() and of_match_ptr() Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-2-andriy.shevchenko@linux.intel.com> <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> <424de3ed-f0ea-4fc1-80f5-3ab1d23cf1e1@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <424de3ed-f0ea-4fc1-80f5-3ab1d23cf1e1@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_114419_980982_5338A4AF X-CRM114-Status: GOOD ( 22.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 06:25:16PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:22:59PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 26, 2024 at 06:16:28PM +0000, Mark Brown wrote: > > > On Tue, Mar 26, 2024 at 08:07:51PM +0200, Andy Shevchenko wrote: > > > > > Drop rather useless use of ACPI_PTR() and of_match_ptr(). > > > > It also removes the necessity to be dependent on ACPI and > > > > of.h inclusion. > > > > I think the ACPI dependency there is as much about hiding the device on > > > irrelevant platforms as anything else, might be better replaced with an > > > x86 dependency though. > > > The whole idea behind ACPI_PTR() (which seems following the of_match_ptr() > > implementation) looks premature. Now we have a lot of patches from DT people to > > remove of_match_ptr(), i.o.w. make the ID visible even on non-OF platforms. > > > Having the list of supported IDs is not bad thing anyway as it might help > > to google for a device elsewhere, for example. > > That's nice but I'm not sure what that has to do with the dependency on > ACPI? ACPI_PTR() makes ID no-op only if ACPI is defined. That also satisfies the ugly ifdeffery that is removed by this patch as well. If there is no dependency we will have compiler warning for defined but not used variable. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel