From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A8E13D243 for ; Tue, 26 Mar 2024 19:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479986; cv=none; b=uwMhujhKNlKrmdI+IhSBY8QSkmIZw0l06d00IBEFqPNffkWk+xVzQOlntpFX76KUl8vW5bT07u/7FqUK9TUSCYll/50JDaIt2VUBCeFPDOmtzGQutneDttp/ZJdge+mBp7TD/xT15UJ9ltywTzw5QN4zsoz9+nSxysSGwq5WjNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479986; c=relaxed/simple; bh=XMHtLInhdpFNORtCsxmlEXN6TytSsp4Psd0vpGJlhFY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=agHWsMBC+jzJc/Pgeob/zOpjUiHNurNGftC4Ad1ExCxbOKfcHyJarS0dG8K6rGfYwnZWDQE/6hkvcFs4Fcdurgmef+hlc0rVVa8kpPVK5ggj8TTIf4FxELFCWIyuhHNowuETtmZSR8Oia+4oYounoK1wqhrCu63dzOUvFGJz77I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=f59szWCm; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f59szWCm" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4146f72e2dfso17035e9.1 for ; Tue, 26 Mar 2024 12:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711479983; x=1712084783; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2O++aLuPGdPac9vhoK8OY9HLMIShoUjHnfyucoaDzxo=; b=f59szWCm8L9zJ7maEA/9Ct542Du8TDZNzfeIxKHMJYCug7EB3F8+wZYROlAgtC5L1Q lkH7W0mgM/eASl37N42n8GZdda1aa5NA10Yu+uD9i2BBG5QIFt4yhSYVeSEKGBrNSSGn wA4lICCmt4NlLt0XP6dd50R0ZtEGyTrEEmENk57njhIq1ZyDdHa1b0mr/ozgxy2cLOhy BW+/v0ThwONzYzqXtnPpMa41txNR/KLGggDqg8If9ZGNWbbfsy0lTMbw1NPrZD2mTCiF YUuen55ZQWy6qlo2cQ0GHbajbH5bhWC8nKh1UrEWCzEKLrNsJ7JaJwYCcZwbpfo5DQuy RFmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711479983; x=1712084783; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2O++aLuPGdPac9vhoK8OY9HLMIShoUjHnfyucoaDzxo=; b=Vk1Mhc6kznPXTbMnVXR1HkAP4KEKKhwBa2sa3TGNVNmcZh7G+JE8GHsAsZnhLiQRko mDYWd/EtnKwYjjuDIOsjoKWxen1Lh33sbS9nmI0jqvtKhKLbBH8LatnvvLjKRR4mPukM l4Maxxn5oAvgDMl4seg6yEeCcGurjV5+7iuAtFmvhUIAD3Nth+cGJOQy5SbtPaz7LT15 l60WZufNHq6PKN+MiXI17+BfqpmqTGH3z52PG3/11Q6ML8OJbw0rXfSqgMA4qK824EKo XWtVxxHCRW1Thsvxw6nZVFbjMq08BiULMjJAdpPRr34+WvGdAzcLtRJP6NHV2bAOrTyv ORIg== X-Gm-Message-State: AOJu0Yx4gXmSa8c9csVKLmO0UkAQ+4x9yWzhjtwftYrisXuaDsGMoray lFctHN9u3bG5cqADHotZK1OPz8DyrN+UXLrTpMXHvxHhVGJ/prGh81VotuoPSg== X-Google-Smtp-Source: AGHT+IHL9mYz18k3QjEkWU5YbvJMBb0fbp8YknTOD+ioScRXPB6XD6REp1IPUdO7uzrTv85PQWkyAQ== X-Received: by 2002:a05:600c:3b1a:b0:414:89bf:b77b with SMTP id m26-20020a05600c3b1a00b0041489bfb77bmr28030wms.1.1711479982958; Tue, 26 Mar 2024 12:06:22 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id g4-20020a05600c310400b0041462294fe3sm12325788wmo.42.2024.03.26.12.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:06:22 -0700 (PDT) Date: Tue, 26 Mar 2024 19:06:18 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 01/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <20240326183016.GK6245@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240326183016.GK6245@nvidia.com> On Tue, Mar 26, 2024 at 03:30:16PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 22, 2024 at 05:48:52PM +0000, Mostafa Saleh wrote: > > Hi Jason, > > > > On Mon, Mar 04, 2024 at 07:43:49PM -0400, Jason Gunthorpe wrote: > > > The SVA code is wired to assume that the SVA is programmed onto the > > > mm->pasid. The current core code always does this, so it is fine. > > > > > > Add a check for clarity. > > > > > > Tested-by: Nicolin Chen > > > Signed-off-by: Jason Gunthorpe > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > > > index 2610e82c0ecd0d..347c2fdd865c1a 100644 > > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c > > > @@ -581,6 +581,9 @@ static int arm_smmu_sva_set_dev_pasid(struct iommu_domain *domain, > > > int ret = 0; > > > struct mm_struct *mm = domain->mm; > > > > > > + if (mm_get_enqcmd_pasid(mm) != id) > > > + return -EINVAL; > > > + > > I am not sure if that is needed, the only caller in the tree is the IOMMU code > > and it does the right thing, as that check is removed later anyway, I don’t > > think this patch adds much. > > It really should be backported, when we get drivers that do other > things it creates a hazard. I've added a fixes line. Maybe I am misunderstanding the case, but AFAIU, the only caller for this is iommu_sva_bind_device() which is the function populating the pasid, so this condition should never hit with the current code. And Linux won’t backport new drivers, so there is no need to do that? Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2299DC6FD1F for ; Tue, 26 Mar 2024 19:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lgNzL57/xy1V4J3qRF4uRd7Lm1Gf66vldQ5kF5Lra/Y=; b=ZkXL1yrN0e378x E7Xa7INL2EHAnxrr9c/ekpZ3zAFbq2druGlHmZVinLREFTyQnM/syOer6WJ0BEs8+2EgQVsF97aKG dRnyFZMJGPpUvh1oeKHPrXZMS7nwBRCCoG3+VQzHS9Va30Yd6fDIpicrZriAMsdQ7NPaSe6w/vTB7 2WkEgbNADP6pb02ml2JucdoGwsdkeJW0aDyCGWjVVaNdVhTu9p1ZAgDdu5KKpM/pevC70u4U8AJvj EOZPhLQ/85AvY3IiRQy2INqpj5C0m3oIONBY8u9j8OsomWarvY7KTy/Xveq0dHBw8GocnvrVyAI2c 6LpyYH+/mbCXU0UuEyMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpC8W-000000064op-1q17; Tue, 26 Mar 2024 19:07:04 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpC7u-000000064c9-2hoe for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 19:06:29 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4146f72e2dfso17015e9.1 for ; Tue, 26 Mar 2024 12:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711479983; x=1712084783; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2O++aLuPGdPac9vhoK8OY9HLMIShoUjHnfyucoaDzxo=; b=mZadwbqgcd7ekfKHXbp0Pkc0kVlUN/YY5auzFwC1Y4GkBQ+/D/YH6MkQ/80FZAO3ch rA8/oALp4L7k+waXzFDv6RTuVE6nsyfmkC0PKFfogGtXIMa9UQ4Zj234FtwFEwUqDoxy WYAJLOQHBN3xmH10h5aGweQ95c5/fnZ0CvUlk0p8ym4zCq3vTDyz3oZYu1c/bkQMe+4K N4G8MZyVwRn5arfRSWwxQYplWkAXD+UqYKa0R0mUYExTPQ8VytmvEPXfM3lkeC3E8rnu 02qFINRHgE6Kz8ggWBVkmnDeInlFQfl3hUsbqB76iw4sYa9wz7d2csFqDC2nLNKL1Brw VltQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711479983; x=1712084783; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2O++aLuPGdPac9vhoK8OY9HLMIShoUjHnfyucoaDzxo=; b=ZKXzLg9FMJy8Mf52Blt7k4dmvxg7/BRz792YWu6VZe0MVQ6oiFRUkGURDQ7GQHLsgh eEP05lxmRnFYssNrKiUr1otsqmmaveX0UwxhDlVSzYGRBPAslJjN75Fo/NAh6K1guOi3 Xgarp2BLizOJ7QdswiTmCjVlnIPjiz/y8PTl7kfy5iLK6N3JEaxvzry7pYQvVPz/YYvF IYQ2MtdMGfRuXH7eRvEU2VNSVVZ87nMLAATTFKfzd+rT4xtqKxUJ1ak+p03kaQuiW0pN quB24P2q8Ia9UM5AO1BydUbPw+XO/Be4dlSFVF9ruJ+z03iIteTCLh7x+0cuIlvLfiMi qR0g== X-Forwarded-Encrypted: i=1; AJvYcCUXnbqs/+licPHKKmOLRihBDJsaDhRPJBGXrxwy1DTVOR5fatMbEqMISdZHg4sPa7mZCbfrMF862VP0o10tvkGadzEDGG5WpTo4K0Nwz0KF3fSZCyU= X-Gm-Message-State: AOJu0Yw4SAAVxTmq6Xcj4iYvD/QqJrlp9ZXqN7NPotM65F4MiCFrKvC9 SdqLwCpyZH7cDmcw1H55AGIbiWrIqJim+yW+1eDzDRR31bBpKBSg8ruhRBhxsA== X-Google-Smtp-Source: AGHT+IHL9mYz18k3QjEkWU5YbvJMBb0fbp8YknTOD+ioScRXPB6XD6REp1IPUdO7uzrTv85PQWkyAQ== X-Received: by 2002:a05:600c:3b1a:b0:414:89bf:b77b with SMTP id m26-20020a05600c3b1a00b0041489bfb77bmr28030wms.1.1711479982958; Tue, 26 Mar 2024 12:06:22 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id g4-20020a05600c310400b0041462294fe3sm12325788wmo.42.2024.03.26.12.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:06:22 -0700 (PDT) Date: Tue, 26 Mar 2024 19:06:18 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 01/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <1-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <20240326183016.GK6245@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326183016.GK6245@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_120626_868022_2DD73596 X-CRM114-Status: GOOD ( 29.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXIgMjYsIDIwMjQgYXQgMDM6MzA6MTZQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDIyLCAyMDI0IGF0IDA1OjQ4OjUyUE0gKzAwMDAsIE1vc3Rh ZmEgU2FsZWggd3JvdGU6Cj4gPiBIaSBKYXNvbiwKPiA+IAo+ID4gT24gTW9uLCBNYXIgMDQsIDIw MjQgYXQgMDc6NDM6NDlQTSAtMDQwMCwgSmFzb24gR3VudGhvcnBlIHdyb3RlOgo+ID4gPiBUaGUg U1ZBIGNvZGUgaXMgd2lyZWQgdG8gYXNzdW1lIHRoYXQgdGhlIFNWQSBpcyBwcm9ncmFtbWVkIG9u dG8gdGhlCj4gPiA+IG1tLT5wYXNpZC4gVGhlIGN1cnJlbnQgY29yZSBjb2RlIGFsd2F5cyBkb2Vz IHRoaXMsIHNvIGl0IGlzIGZpbmUuCj4gPiA+IAo+ID4gPiBBZGQgYSBjaGVjayBmb3IgY2xhcml0 eS4KPiA+ID4gCj4gPiA+IFRlc3RlZC1ieTogTmljb2xpbiBDaGVuIDxuaWNvbGluY0BudmlkaWEu Y29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BudmlkaWEuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11 LXYzLXN2YS5jIHwgMyArKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9h cm0tc21tdS12My1zdmEuYyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11 LXYzLXN2YS5jCj4gPiA+IGluZGV4IDI2MTBlODJjMGVjZDBkLi4zNDdjMmZkZDg2NWMxYSAxMDA2 NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMt c3ZhLmMKPiA+ID4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUt djMtc3ZhLmMKPiA+ID4gQEAgLTU4MSw2ICs1ODEsOSBAQCBzdGF0aWMgaW50IGFybV9zbW11X3N2 YV9zZXRfZGV2X3Bhc2lkKHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwKPiA+ID4gIAlpbnQg cmV0ID0gMDsKPiA+ID4gIAlzdHJ1Y3QgbW1fc3RydWN0ICptbSA9IGRvbWFpbi0+bW07Cj4gPiA+ ICAKPiA+ID4gKwlpZiAobW1fZ2V0X2VucWNtZF9wYXNpZChtbSkgIT0gaWQpCj4gPiA+ICsJCXJl dHVybiAtRUlOVkFMOwo+ID4gPiArCj4gPiBJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMgbmVlZGVk LCB0aGUgb25seSBjYWxsZXIgaW4gdGhlIHRyZWUgaXMgdGhlIElPTU1VIGNvZGUKPiA+IGFuZCBp dCBkb2VzIHRoZSByaWdodCB0aGluZywgYXMgdGhhdCBjaGVjayBpcyByZW1vdmVkIGxhdGVyIGFu eXdheSwgSSBkb27igJl0Cj4gPiB0aGluayB0aGlzIHBhdGNoIGFkZHMgbXVjaC4KPiAKPiBJdCBy ZWFsbHkgc2hvdWxkIGJlIGJhY2twb3J0ZWQsIHdoZW4gd2UgZ2V0IGRyaXZlcnMgdGhhdCBkbyBv dGhlcgo+IHRoaW5ncyBpdCBjcmVhdGVzIGEgaGF6YXJkLiBJJ3ZlIGFkZGVkIGEgZml4ZXMgbGlu ZS4KCk1heWJlIEkgYW0gbWlzdW5kZXJzdGFuZGluZyB0aGUgY2FzZSwgYnV0IEFGQUlVLCB0aGUg b25seSBjYWxsZXIgZm9yIHRoaXMgaXMKaW9tbXVfc3ZhX2JpbmRfZGV2aWNlKCkgd2hpY2ggaXMg dGhlIGZ1bmN0aW9uIHBvcHVsYXRpbmcgdGhlIHBhc2lkLCBzbyB0aGlzCmNvbmRpdGlvbiBzaG91 bGQgbmV2ZXIgaGl0IHdpdGggdGhlIGN1cnJlbnQgY29kZS4KQW5kIExpbnV4IHdvbuKAmXQgYmFj a3BvcnQgbmV3IGRyaXZlcnMsIHNvIHRoZXJlIGlzIG5vIG5lZWQgdG8gZG8gdGhhdD8KClRoYW5r cywKTW9zdGFmYQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=